Re: Static layout PNOR support in openpower-pnor-code-mgmt

["Andrew Jeffery" <andrew@aj.id.au>]

On Thu, 28 Feb 2019, at 17:47, Lei YU wrote:
> As a follow up of [VPNOR discussion][1], the static layout PNOR
> support in openpower-pnor-code-mgmt is implemented and pushed to gerrit
> starting from 
> https://gerrit.openbmc-project.xyz/#/c/openbmc/openpower-pnor-code-mgmt/+/18747/
> 
> Code reviews and tests are welcome.
> 
> To test the feature:
> 1. Pick the above gerrit commits and build with --disable-ubifs_layout

This is a monstrous nitpick, but any chance we can avoid mixing '-' and '_' in the option
name? I very much prefer just using '-' for visual consistency.

> 2. Generate pnor in static.tar.gz format, by below command:
>     ./generate-squashfs <xxx.pnor>   # xxx.pnor.static.tar.gz will be generated
>    This tar.gz will be used to do the code update.
> 3. Do code update, gard reset, factory reset the same as VPNOR, described in
>    [host-code-update.md][2] and [REST-cheatsheet.md][3]
> 
> I only tested it on Romulus, and will test it on Palmetto. Hopefully it will
> be tested on other OpenPOWER machines before the patches are merged.

Awesome work! Thanks for sorting this out.

> 
> Note: image verification feature is not implemented yet.
> 
> [1]: https://lists.ozlabs.org/pipermail/openbmc/2019-February/015104.html
> [2]: https://github.com/openbmc/docs/blob/master/code-update/host-code-update.md
> [3]: https://github.com/openbmc/docs/blob/master/REST-cheatsheet.md
>