From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] mk: allow application to override clean Date: Fri, 30 Jan 2015 11:46:07 +0100 Message-ID: <1768599.JE1HSW6J0Q@xps13> References: <1421993948-24785-1-git-send-email-stephen@networkplumber.org> <1902752B0C92F943AB7EA9EE13E2DEEC287AE6B39E@HQ1-EXCH02.corp.brocade.com> <20150129223641.75306372@uryu.home.lan> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev-VfR2kkLFssw@public.gmane.org To: Stephen Hemminger Return-path: In-Reply-To: <20150129223641.75306372-CA4OZQ/Yy2Lykuyl+CZolw@public.gmane.org> List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2015-01-29 22:36, Stephen Hemminger: > On Thu, 29 Jan 2015 02:52:45 -0800 > Thomas Monjalon wrote: > > > Hi Stephen, > > > > 2015-01-28 12:00, Olivier MATZ: > > > Hi Stephen, > > > > > > On 01/23/2015 07:19 AM, stephen-OTpzqLSitTUnbdJkjeBofR2eb7JE58TQ@public.gmane.org wrote: > > > > From: Stephen Hemminger > > > > > > > > In some cases application may want to have additional rules > > > > for clean. This can be handled by allowing the double colon > > > > form of rule. > > > > > > > > https://www.gnu.org/software/make/manual/html_node/Double_002dColon.html > > > > > > There is already a way to do that in dpdk makefiles: you can add > > > the following code in your application Makefile, before the line > > > that includes $(RTE_SDK)/mk/rte.app.mk: > > > > > > POSTCLEAN += my_clean > > > > > > .PHONY: my_clean > > > my_clean: > > > @echo executed after clean > > > > Does it fit with your needs? > > Should we revert your patch? Double-colon rules were avoided in DPDK. > > "Double-colon rules are somewhat obscure and not often very useful" > > > > Works for me. So the commit is now reverted: http://dpdk.org/browse/dpdk/commit/?id=785e1a0932b67136 -- Thomas