From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Date: Thu, 13 Aug 2015 21:19:03 +0000 Subject: Re: [PATCH] drm: rcar-du: Fix plane state free in plane reset handler Message-Id: <1768630.dTmQoR56Ge@avalon> List-Id: References: <1438820580-14301-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20150807125321.GE25792@ulmo> <2325494.jkNV16dCnQ@avalon> In-Reply-To: <2325494.jkNV16dCnQ@avalon> MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit To: Thierry Reding Cc: Daniel Vetter , Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org On Friday 07 August 2015 17:30:08 Laurent Pinchart wrote: > On Friday 07 August 2015 14:53:22 Thierry Reding wrote: > > On Thu, Aug 06, 2015 at 03:23:00AM +0300, Laurent Pinchart wrote: > > > The plane reset handler frees the plane state and allocates a new > > > default state, but when doing so attempt to free the plane state using > > > the base plane state pointer instead of casting it to the > > > driver-specific state object that has been allocated. Fix it by using > > > the rcar_du_plane_atomic_destroy_state() function to destroy the plane > > > state instead of duplicating the code. > > > > > > Signed-off-by: Laurent Pinchart > > > > > > --- > > > > > > drivers/gpu/drm/rcar-du/rcar_du_plane.c | 45 ++++++++++++-------------- > > > 1 file changed, 22 insertions(+), 23 deletions(-) > > > > > > Should the DRM core free the atomic state before calling the reset > > > operation ? That would simplify drivers. > > > > The core can't do that because drivers might have subclassed the state. > > But the core can call the .atomic_destroy_state() operation, can't it ? Thierry, Daniel, any comment on this ? > > Reviewed-by: Thierry Reding -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: [PATCH] drm: rcar-du: Fix plane state free in plane reset handler Date: Fri, 14 Aug 2015 00:19:03 +0300 Message-ID: <1768630.dTmQoR56Ge@avalon> References: <1438820580-14301-1-git-send-email-laurent.pinchart+renesas@ideasonboard.com> <20150807125321.GE25792@ulmo> <2325494.jkNV16dCnQ@avalon> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: Received: from galahad.ideasonboard.com (galahad.ideasonboard.com [185.26.127.97]) by gabe.freedesktop.org (Postfix) with ESMTPS id 9CD526E5D3 for ; Thu, 13 Aug 2015 14:18:08 -0700 (PDT) In-Reply-To: <2325494.jkNV16dCnQ@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Thierry Reding Cc: Daniel Vetter , Laurent Pinchart , dri-devel@lists.freedesktop.org, linux-sh@vger.kernel.org List-Id: dri-devel@lists.freedesktop.org T24gRnJpZGF5IDA3IEF1Z3VzdCAyMDE1IDE3OjMwOjA4IExhdXJlbnQgUGluY2hhcnQgd3JvdGU6 Cj4gT24gRnJpZGF5IDA3IEF1Z3VzdCAyMDE1IDE0OjUzOjIyIFRoaWVycnkgUmVkaW5nIHdyb3Rl Ogo+ID4gT24gVGh1LCBBdWcgMDYsIDIwMTUgYXQgMDM6MjM6MDBBTSArMDMwMCwgTGF1cmVudCBQ aW5jaGFydCB3cm90ZToKPiA+ID4gVGhlIHBsYW5lIHJlc2V0IGhhbmRsZXIgZnJlZXMgdGhlIHBs YW5lIHN0YXRlIGFuZCBhbGxvY2F0ZXMgYSBuZXcKPiA+ID4gZGVmYXVsdCBzdGF0ZSwgYnV0IHdo ZW4gZG9pbmcgc28gYXR0ZW1wdCB0byBmcmVlIHRoZSBwbGFuZSBzdGF0ZSB1c2luZwo+ID4gPiB0 aGUgYmFzZSBwbGFuZSBzdGF0ZSBwb2ludGVyIGluc3RlYWQgb2YgY2FzdGluZyBpdCB0byB0aGUK PiA+ID4gZHJpdmVyLXNwZWNpZmljIHN0YXRlIG9iamVjdCB0aGF0IGhhcyBiZWVuIGFsbG9jYXRl ZC4gRml4IGl0IGJ5IHVzaW5nCj4gPiA+IHRoZSByY2FyX2R1X3BsYW5lX2F0b21pY19kZXN0cm95 X3N0YXRlKCkgZnVuY3Rpb24gdG8gZGVzdHJveSB0aGUgcGxhbmUKPiA+ID4gc3RhdGUgaW5zdGVh ZCBvZiBkdXBsaWNhdGluZyB0aGUgY29kZS4KPiA+ID4gCj4gPiA+IFNpZ25lZC1vZmYtYnk6IExh dXJlbnQgUGluY2hhcnQKPiA+ID4gPGxhdXJlbnQucGluY2hhcnQrcmVuZXNhc0BpZGVhc29uYm9h cmQuY29tPgo+ID4gPiAtLS0KPiA+ID4gCj4gPiA+ICBkcml2ZXJzL2dwdS9kcm0vcmNhci1kdS9y Y2FyX2R1X3BsYW5lLmMgfCA0NSArKysrKysrKysrKystLS0tLS0tLS0tLS0tLQo+ID4gPiAgMSBm aWxlIGNoYW5nZWQsIDIyIGluc2VydGlvbnMoKyksIDIzIGRlbGV0aW9ucygtKQo+ID4gPiAKPiA+ ID4gU2hvdWxkIHRoZSBEUk0gY29yZSBmcmVlIHRoZSBhdG9taWMgc3RhdGUgYmVmb3JlIGNhbGxp bmcgdGhlIHJlc2V0Cj4gPiA+IG9wZXJhdGlvbiA/IFRoYXQgd291bGQgc2ltcGxpZnkgZHJpdmVy cy4KPiA+IAo+ID4gVGhlIGNvcmUgY2FuJ3QgZG8gdGhhdCBiZWNhdXNlIGRyaXZlcnMgbWlnaHQg aGF2ZSBzdWJjbGFzc2VkIHRoZSBzdGF0ZS4KPiAKPiBCdXQgdGhlIGNvcmUgY2FuIGNhbGwgdGhl IC5hdG9taWNfZGVzdHJveV9zdGF0ZSgpIG9wZXJhdGlvbiwgY2FuJ3QgaXQgPwoKVGhpZXJyeSwg RGFuaWVsLCBhbnkgY29tbWVudCBvbiB0aGlzID8KCj4gPiBSZXZpZXdlZC1ieTogVGhpZXJyeSBS ZWRpbmcgPHRyZWRpbmdAbnZpZGlhLmNvbT4KCi0tIApSZWdhcmRzLAoKTGF1cmVudCBQaW5jaGFy dAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRl dmVsIG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHA6Ly9s aXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5mby9kcmktZGV2ZWwK