All of lore.kernel.org
 help / color / mirror / Atom feed
From: David Ahern <dsahern@gmail.com>
To: Josh Hunt <johunt@akamai.com>, stephen@networkplumber.org
Cc: netdev@vger.kernel.org
Subject: Re: [PATCH v2] ss: add option to print socket information on one line
Date: Thu, 2 May 2019 17:11:34 -0600	[thread overview]
Message-ID: <17702d09-ebfa-c3a4-e1a6-403a3c552e37@gmail.com> (raw)
In-Reply-To: <1556674718-5081-1-git-send-email-johunt@akamai.com>

On 4/30/19 7:38 PM, Josh Hunt wrote:
> Multi-line output in ss makes it difficult to search for things with
> grep. This new option will make it easier to find sockets matching
> certain criteria with simple grep commands.
> 
...

> 
> Signed-off-by: Josh Hunt <johunt@akamai.com>
> ---
> 
> v1 -> v2
> * Update long option to --oneline to match other ip tools as per David.
> 
>  man/man8/ss.8 |  3 +++
>  misc/ss.c     | 51 +++++++++++++++++++++++++++++++++++++++++----------
>  2 files changed, 44 insertions(+), 10 deletions(-)
> 

> diff --git a/misc/ss.c b/misc/ss.c
> index 9cb3ee19e542..e8e7b62eb4a5 100644
> --- a/misc/ss.c
> +++ b/misc/ss.c
> @@ -121,6 +121,7 @@ static int follow_events;
>  static int sctp_ino;
>  static int show_tipcinfo;
>  static int show_tos;
> +int oneline = 0;
>  

dropped the ' = 0' which is unnecessary and applied to iproute2-next.



  reply	other threads:[~2019-05-02 23:11 UTC|newest]

Thread overview: 12+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-01  1:38 [PATCH v2] ss: add option to print socket information on one line Josh Hunt
2019-05-02 23:11 ` David Ahern [this message]
2019-05-30  9:11 ` Markus Elfring
2019-06-01  8:36 ` ss: Checking efficient analysis for network connections Markus Elfring
2019-06-01 23:48   ` David Miller
2019-06-02  5:40     ` Markus Elfring
2019-06-13 14:40     ` Markus Elfring
2019-07-23  8:25     ` Markus Elfring
2019-09-16 10:32     ` ss: Checking selected network ports Markus Elfring
2019-09-16 10:32       ` Markus Elfring
2019-10-22  6:00     ` [RFC] " Markus Elfring
2019-10-22  6:00       ` Markus Elfring

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17702d09-ebfa-c3a4-e1a6-403a3c552e37@gmail.com \
    --to=dsahern@gmail.com \
    --cc=johunt@akamai.com \
    --cc=netdev@vger.kernel.org \
    --cc=stephen@networkplumber.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.