From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 306DAC433F5 for ; Thu, 25 Nov 2021 19:33:01 +0000 (UTC) Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id 00B1382FA2; Thu, 25 Nov 2021 20:32:58 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 4ADA08321B; Thu, 25 Nov 2021 20:32:57 +0100 (CET) Received: from gloria.sntech.de (gloria.sntech.de [185.11.138.130]) (using TLSv1.3 with cipher TLS_AES_256_GCM_SHA384 (256/256 bits)) (No client certificate requested) by phobos.denx.de (Postfix) with ESMTPS id 6661A812BB for ; Thu, 25 Nov 2021 20:32:54 +0100 (CET) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=sntech.de Authentication-Results: phobos.denx.de; spf=none smtp.mailfrom=heiko@sntech.de Received: from ip5f5b2004.dynamic.kabel-deutschland.de ([95.91.32.4] helo=diego.localnet) by gloria.sntech.de with esmtpsa (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1mqKUG-0005nr-QN; Thu, 25 Nov 2021 20:32:52 +0100 From: Heiko =?ISO-8859-1?Q?St=FCbner?= To: u-boot@lists.denx.de, bmeng.cn@gmail.com, rick@andestech.com, anup.patel@wdc.com, atish.patra@wdc.com, hs@denx.de Cc: cyril.jean@microchip.com, lewis.hanly@microchip.com, conor.dooley@microchip.com, daire.mcnamara@microchip.com, ivan.griffin@microchip.com, valentina.fernandezalanis@microchip.com, Padmarao Begari , Padmarao Begari Subject: Re: macb clock handling (Was: [PATCH v1 4/5] net: macb: Compatible as per device tree) Date: Thu, 25 Nov 2021 20:32:51 +0100 Message-ID: <1771149.Og9QhtiVRx@diego> In-Reply-To: <4033485.bJdaIYV4bU@diego> References: <20211022085648.134655-1-padmarao.begari@microchip.com> <20211022085648.134655-5-padmarao.begari@microchip.com> <4033485.bJdaIYV4bU@diego> MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable Content-Type: text/plain; charset="iso-8859-1" X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.37 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi, Am Donnerstag, 11. November 2021, 10:41:46 CET schrieb Heiko St=FCbner: > not wanting to hijack this too much, but does the mac driver also need > some sort of clock handling? >=20 > Because on the Icicle I have here, I'm running into "TX timeout" errors: >=20 > RISC-V # dhcp > ethernet@20112000: PHY present at 9 > ethernet@20112000: Starting autonegotiation... > ethernet@20112000: Autonegotiation complete > ethernet@20112000: link up, 1000Mbps full-duplex (lpa: 0x3800) > BOOTP broadcast 1 > ethernet@20112000: TX timeout > BOOTP broadcast 2 > ethernet@20112000: TX timeout > BOOTP broadcast 3 > ethernet@20112000: TX timeout > BOOTP broadcast 4 > ethernet@20112000: TX timeout >=20 > The sifive variant of the macb distinguishes between speeds in its > cllk_init callback, so I guess the Icicle might need that as well? just for "the archive", i.e. when people read this in the future: I got this solved by updating the HSS to a recent release (2021.11 in this case). So now I do have working network in u-boot. Heiko > Am Freitag, 22. Oktober 2021, 10:56:47 CET schrieb Padmarao Begari: > > Update compatible as per Microchip PolarFire SoC ethernet > > device node. > >=20 > > Signed-off-by: Padmarao Begari > > --- > > drivers/net/macb.c | 2 +- > > 1 file changed, 1 insertion(+), 1 deletion(-) > >=20 > > diff --git a/drivers/net/macb.c b/drivers/net/macb.c > > index 8c6461e717..1b867bd5c2 100644 > > --- a/drivers/net/macb.c > > +++ b/drivers/net/macb.c > > @@ -1502,7 +1502,7 @@ static const struct udevice_id macb_eth_ids[] =3D= { > > { .compatible =3D "cdns,zynq-gem" }, > > { .compatible =3D "sifive,fu540-c000-gem", > > .data =3D (ulong)&sifive_config }, > > - { .compatible =3D "microchip,mpfs-mss-gem", > > + { .compatible =3D "microchip,mpfs-gem", > > .data =3D (ulong)µchip_config }, > > { } > > }; > >=20 >=20 >=20