From: Mathieu Desnoyers <mathieu.desnoyers@efficios.com>
To: Peter Zijlstra <peterz@infradead.org>
Cc: rostedt <rostedt@goodmis.org>,
linux-kernel <linux-kernel@vger.kernel.org>,
Ingo Molnar <mingo@kernel.org>,
"Joel Fernandes, Google" <joel@joelfernandes.org>,
Greg Kroah-Hartman <gregkh@linuxfoundation.org>,
"Gustavo A. R. Silva" <gustavo@embeddedor.com>,
Thomas Gleixner <tglx@linutronix.de>,
paulmck <paulmck@kernel.org>,
Josh Triplett <josh@joshtriplett.org>,
Lai Jiangshan <jiangshanlai@gmail.com>
Subject: Re: [PATCH v2] tracing/perf: Move rcu_irq_enter/exit_irqson() to perf trace point hook
Date: Wed, 12 Feb 2020 10:14:20 -0500 (EST) [thread overview]
Message-ID: <1771156780.158.1581520460744.JavaMail.zimbra@efficios.com> (raw)
In-Reply-To: <20200212080220.GO14897@hirez.programming.kicks-ass.net>
----- On Feb 12, 2020, at 3:02 AM, Peter Zijlstra peterz@infradead.org wrote:
> On Tue, Feb 11, 2020 at 12:35:21PM -0500, Mathieu Desnoyers wrote:
>
>> Minor nits:
>>
>> Why not make these an enum ?
>>
>> > +
>> > +#define trace_rcu_enter() \
>> > +({ \
>> > + unsigned long state = 0; \
>> > + if (!rcu_is_watching()) { \
>> > + if (in_nmi()) { \
>> > + state = __TR_NMI; \
>> > + rcu_nmi_enter(); \
>> > + } else { \
>> > + state = __TR_IRQ; \
>> > + rcu_irq_enter_irqson(); \
>> > + } \
>> > + } \
>> > + state; \
>> > +})
>> > +
>> > +#define trace_rcu_exit(state) \
>> > +do { \
>> > + switch (state) { \
>> > + case __TR_IRQ: \
>> > + rcu_irq_exit_irqson(); \
>> > + break; \
>> > + case __IRQ_NMI: \
>> > + rcu_nmi_exit(); \
>> > + break; \
>> > + default: \
>> > + break; \
>> > + } \
>> > +} while (0)
>>
>> And convert these into static inline functions ?
>
> Probably the same reason the rest of the file is macros; header hell.
>
> Now, I could probably make these inlines, but then I'd have to add more
> RCU function declariations to this file (which is outside of
> rcupdate.h). Do we want to do that?
Probably not :) I was just wondering why.
Thanks,
Mathieu
>
> The reason these were in this file is because I want to keep the comment
> and implementation near to nmi_enter/exit.
--
Mathieu Desnoyers
EfficiOS Inc.
http://www.efficios.com
prev parent reply other threads:[~2020-02-12 15:14 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-02-11 14:50 [PATCH v2] tracing/perf: Move rcu_irq_enter/exit_irqson() to perf trace point hook Steven Rostedt
2020-02-11 15:34 ` Mathieu Desnoyers
2020-02-11 15:46 ` Peter Zijlstra
2020-02-11 16:02 ` Mathieu Desnoyers
2020-02-11 15:34 ` Peter Zijlstra
2020-02-11 16:18 ` Steven Rostedt
2020-02-11 16:27 ` Mathieu Desnoyers
2020-02-11 16:35 ` Steven Rostedt
2020-02-11 17:29 ` Peter Zijlstra
2020-02-11 17:32 ` Peter Zijlstra
2020-02-11 18:54 ` Paul E. McKenney
2020-02-12 8:05 ` Peter Zijlstra
2020-02-12 9:05 ` Paul E. McKenney
2020-02-11 17:35 ` Mathieu Desnoyers
2020-02-12 8:02 ` Peter Zijlstra
2020-02-12 15:14 ` Mathieu Desnoyers [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=1771156780.158.1581520460744.JavaMail.zimbra@efficios.com \
--to=mathieu.desnoyers@efficios.com \
--cc=gregkh@linuxfoundation.org \
--cc=gustavo@embeddedor.com \
--cc=jiangshanlai@gmail.com \
--cc=joel@joelfernandes.org \
--cc=josh@joshtriplett.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mingo@kernel.org \
--cc=paulmck@kernel.org \
--cc=peterz@infradead.org \
--cc=rostedt@goodmis.org \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.