From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH 1/2] ring: synchronize the load and store of the tail Date: Sat, 27 Oct 2018 17:13:10 +0200 Message-ID: <17713879.gC9jYcxDUo@xps> References: <1537172244-64874-2-git-send-email-gavin.hu@arm.com> <1874944.OrACW1nkDZ@xps> <20181027150024.GA2294@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "Gavin Hu (Arm Technology China)" , "dev@dpdk.org" , Honnappa Nagarahalli , "stable@dpdk.org" , Ola Liljedahl , "olivier.matz@6wind.com" , "chaozhu@linux.vnet.ibm.com" , "bruce.richardson@intel.com" , "konstantin.ananyev@intel.com" To: Jerin Jacob Return-path: In-Reply-To: <20181027150024.GA2294@jerin> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 27/10/2018 17:00, Jerin Jacob: > From: Thomas Monjalon > > 17/10/2018 08:35, Gavin Hu (Arm Technology China): > > > Hi Jerin > > > > > > As the 1st one of the 3-patch set was not concluded, I submit this 2-patch series to unblock the merge. > > > > The thread is totally messed up because: > > - there is no cover letter > > - some different series (testpmd, i40e and doc) are in the same thread > > - v4 replies to a different series > > - this version should be a v5 but has no number > > - this version replies to the v3 > > - patchwork still shows v3 and "v5" > > - replies from Ola are not quoting previous discussion > > > > Because of all of this, it is really difficult to follow. > > This is probably the reason of the lack of review outside of Arm. > > > > One more issue: you must Cc the relevant maintainers. > > Here: > > - Olivier for rte_ring > > - Chao for IBM platform > > - Bruce and Konstantin for x86 > > > > Guys, it is really cool to have more Arm developpers in DPDK. > > But please consider better formatting your discussions, it is really > > important in our contribution workflow. > > > > I don't know what to do. > > I suggest to wait for more feedbacks and integrate it in -rc2. > > This series has been acked and tested. Sure, if we are looking for some > more feedback we can push to -rc2 if not it a good candidate to be > selected for -rc1. It has been acked and tested only for Arm platforms. And Olivier, the ring maintainer, was not Cc. I feel it is not enough.