From mboxrd@z Thu Jan 1 00:00:00 1970 From: laurent.pinchart@ideasonboard.com (Laurent Pinchart) Date: Tue, 29 Oct 2013 18:20:52 +0100 Subject: Build failure: shmobile drm driver references backlight symbols In-Reply-To: <20131029100413.GA8857@n2100.arm.linux.org.uk> References: <20131029100413.GA8857@n2100.arm.linux.org.uk> Message-ID: <1773467.v8Jb5caonk@avalon> To: linux-arm-kernel@lists.infradead.org List-Id: linux-arm-kernel.lists.infradead.org Hi Russell, On Tuesday 29 October 2013 10:04:13 Russell King - ARM Linux wrote: > My build system picked up on this failure: > > drivers/built-in.o: In function `shmob_drm_backlight_init': > fmc-chardev.c:(.text+0x9f2d0): undefined reference to > `backlight_device_register' drivers/built-in.o: In function > `shmob_drm_backlight_exit': > fmc-chardev.c:(.text+0x9f370): undefined reference to > `backlight_device_unregister' > > which is cuased by drivers/gpu/drm/shmobile/shmob_drm_backlight.c being > built without the backlight dependency being enabled. It looks like > the backlight dependency is a hard requirement, so needs ot be added > to the Kconfig entry for this driver in some way. Thank you for the report. I'll send a fix. -- Regards, Laurent Pinchart From mboxrd@z Thu Jan 1 00:00:00 1970 From: Laurent Pinchart Subject: Re: Build failure: shmobile drm driver references backlight symbols Date: Tue, 29 Oct 2013 18:20:52 +0100 Message-ID: <1773467.v8Jb5caonk@avalon> References: <20131029100413.GA8857@n2100.arm.linux.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Return-path: Received: from perceval.ideasonboard.com (perceval.ideasonboard.com [95.142.166.194]) by gabe.freedesktop.org (Postfix) with ESMTP id 219A8EEBF3 for ; Tue, 29 Oct 2013 10:20:26 -0700 (PDT) In-Reply-To: <20131029100413.GA8857@n2100.arm.linux.org.uk> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: dri-devel-bounces@lists.freedesktop.org Errors-To: dri-devel-bounces@lists.freedesktop.org To: Russell King - ARM Linux Cc: linux-arm-kernel@lists.infradead.org, dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org Hi Russell, On Tuesday 29 October 2013 10:04:13 Russell King - ARM Linux wrote: > My build system picked up on this failure: > > drivers/built-in.o: In function `shmob_drm_backlight_init': > fmc-chardev.c:(.text+0x9f2d0): undefined reference to > `backlight_device_register' drivers/built-in.o: In function > `shmob_drm_backlight_exit': > fmc-chardev.c:(.text+0x9f370): undefined reference to > `backlight_device_unregister' > > which is cuased by drivers/gpu/drm/shmobile/shmob_drm_backlight.c being > built without the backlight dependency being enabled. It looks like > the backlight dependency is a hard requirement, so needs ot be added > to the Kconfig entry for this driver in some way. Thank you for the report. I'll send a fix. -- Regards, Laurent Pinchart