From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [dpdk-stable] [PATCH v2] eventdev: make ethernet port identifiers 16 bit Date: Thu, 10 May 2018 16:54:45 +0200 Message-ID: <1779610.xE5Tc50yFF@xps> References: <1525893452-155596-1-git-send-email-nikhil.rao@intel.com> <18183719.QCaNLk8Ax1@xps> <20180510143020.GA21914@jerin> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: Nikhil Rao , ferruh.yigit@intel.com, lei.a.yao@intel.com, dev@dpdk.org To: Jerin Jacob Return-path: Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id 8B88A1BB54 for ; Thu, 10 May 2018 16:54:47 +0200 (CEST) In-Reply-To: <20180510143020.GA21914@jerin> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 10/05/2018 16:30, Jerin Jacob: > From: Thomas Monjalon > > 10/05/2018 06:31, Jerin Jacob: > > > > Date: Thu, 10 May 2018 02:22:40 +0530 > > > > From: Nikhil Rao > > > > > > > > Ethernet port ID data size has been extended to 16 bits size 17.11 > > > > Update the Rx event adapter interface and implementation accordingly. > > > > > > > > Fixes: 9c38b704d280 ("eventdev: add eth Rx adapter implementation") > > > > Signed-off-by: Nikhil Rao > > > > Cc: stable@dpdk.org > > > > > > Since it is an ABI change, please bump the library version. > > > eth_rx_adapter still under experimental tag, IMO, no deprecation notice is > > > required. > > > > The ABI changes must be described in the release notes too. > > > > There is no deprecation notice for this ABI change. > > According the the policy, you must send a notice in 18.05, > > and do the change in 18.08. > > Even for the APIs with experimental tag? No, experimental can change without prior notice. > If so, I don't see any > difference between experimental vs non experimental API? Rx adapter is not experimental as far as I know.