Re: [PATCH] generic/473: fix expectation properly in out file

[Chengguang Xu <cgxu519@mykernel.net>]

 ---- 在 星期四, 2021-02-25 00:50:57 Darrick J. Wong <djwong@kernel.org> 撰写 ----
 > On Tue, Feb 23, 2021 at 09:40:42PM +0800, Chengguang Xu wrote:
 > > It seems the expected result of testcase of "Hole + Data"
 > > in generic/473 is not correct, so just fix it properly.
 > > 
 > > Signed-off-by: Chengguang Xu <cgxu519@mykernel.net>
 > > ---
 > >  tests/generic/473.out | 2 +-
 > >  1 file changed, 1 insertion(+), 1 deletion(-)
 > > 
 > > diff --git a/tests/generic/473.out b/tests/generic/473.out
 > > index 75816388..f1ee5805 100644
 > > --- a/tests/generic/473.out
 > > +++ b/tests/generic/473.out
 > > @@ -6,7 +6,7 @@ Data + Hole
 > >  1: [256..287]: hole
 > >  Hole + Data
 > >  0: [0..127]: hole
 > > -1: [128..255]: data
 > > +1: [128..135]: data
 > 
 > This again.  While the FIEMAP documentation allows the call to return
 > file mapping data outside the requested range, it doesn't require it,
 > and neither XFS nor ext4 have ever done so.

I did more tests on ext4 and found in old 4.14 kernel ext4 returned whole extent range.


 > 
 > This test *enforces* that the FIEMAP implementation provide data outside
 > the requested range, which means it has never passed on xfs/ext4.  This
 > is no surprise, since it's enforcing one behavior where the spec allows
 > for two behaviors.  The only fs I know of where it passes is btrfs.

plus f2fs.

Thanks,
Chengguang

 > 
 > Delete this test or move it to tests/btrfs/, because it should not have
 > been added in the first place.
 > 
 > --D
 > 
 > >  Hole + Data + Hole
 > >  0: [0..127]: hole
 > >  1: [128..255]: data
 > > -- 
 > > 2.27.0
 > > 
 > > 
 >