From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: from mail-qk1-f195.google.com (mail-qk1-f195.google.com [209.85.222.195]) by gabe.freedesktop.org (Postfix) with ESMTPS id F3F19892DC for ; Wed, 20 Feb 2019 20:43:47 +0000 (UTC) Received: by mail-qk1-f195.google.com with SMTP id m9so2918238qkl.4 for ; Wed, 20 Feb 2019 12:43:47 -0800 (PST) Message-ID: <178261c5a84a9a7698b742d6b2b8c053ac01832a.camel@redhat.com> From: Lyude Paul Date: Wed, 20 Feb 2019 15:43:45 -0500 In-Reply-To: <20190220162530.31643-3-daniel.vetter@ffwll.ch> References: <20190220162530.31643-1-daniel.vetter@ffwll.ch> <20190220162530.31643-3-daniel.vetter@ffwll.ch> MIME-Version: 1.0 Subject: Re: [igt-dev] [PATCH i-g-t 3/9] tests/kms_lease: invalid corner-cases for create-lease ioctl List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Errors-To: igt-dev-bounces@lists.freedesktop.org Sender: "igt-dev" To: Daniel Vetter , IGT development Cc: Keith Packard List-ID: T24gV2VkLCAyMDE5LTAyLTIwIGF0IDE3OjI1ICswMTAwLCBEYW5pZWwgVmV0dGVyIHdyb3RlOgo+ IEZvdW5kIGEgZmV3IHRoaW5ncyBpbiB0aGUga2VybmVsIHRoYXQgbG9va3Mgc3VzcGljaW91cywg c2VwYXJhdGUKPiBwYXRjaGVzIG9uIHRoZWlyIHdheS4KPiAKPiBJIGFsc28gcmV2aWV3ZWQgY292 ZXJhZ2UgZm9yIGxpc3QtbGVzc2VzIGFuZCBnZXQtbGVhc2UsIGFuZCBjb3ZlcmFnZQo+IHNlZW1z IGNvbXBsZXRlIGZvciB0aGVzZS4KPiAKPiBDYzogS2VpdGggUGFja2FyZCA8a2VpdGhwQGtlaXRo cC5jb20+Cj4gU2lnbmVkLW9mZi1ieTogRGFuaWVsIFZldHRlciA8ZGFuaWVsLnZldHRlckBmZnds bC5jaD4KPiAtLS0KPiAgdGVzdHMva21zX2xlYXNlLmMgfCAxMDAKPiArKysrKysrKysrKysrKysr KysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysrKysKPiAgMSBmaWxlIGNoYW5nZWQs IDEwMCBpbnNlcnRpb25zKCspCj4gCj4gZGlmZiAtLWdpdCBhL3Rlc3RzL2ttc19sZWFzZS5jIGIv dGVzdHMva21zX2xlYXNlLmMKPiBpbmRleCBmYTk3ZjZlMTEzMzQuLjQwNjJhMGIzNjVjOSAxMDA2 NDQKPiAtLS0gYS90ZXN0cy9rbXNfbGVhc2UuYwo+ICsrKyBiL3Rlc3RzL2ttc19sZWFzZS5jCj4g QEAgLTYyMyw2ICs2MjMsMTAzIEBAIHN0YXRpYyB2b2lkIHJ1bl90ZXN0KGRhdGFfdCAqZGF0YSwg dm9pZAo+ICgqdGVzdGZ1bmMpKGRhdGFfdCAqKSkKPiAgCQkgICAgICAibm8gdmFsaWQgY3J0Yy9j b25uZWN0b3IgY29tYmluYXRpb25zIGZvdW5kXG4iKTsKPiAgfQo+ICAKPiArc3RhdGljIHZvaWQg aW52YWxpZF9jcmVhdGVfbGVhc2VzKGRhdGFfdCAqZGF0YSkKPiArewo+ICsJdWludDMyX3Qgb2Jq ZWN0X2lkc1s0XTsKPiArCXN0cnVjdCBsb2NhbF9kcm1fbW9kZV9jcmVhdGVfbGVhc2UgbWNsOwo+ ICsJZHJtTW9kZVJlcyAqcmVzb3VyY2VzOwo+ICsJaW50IHRtcF9mZDsKPiArCj4gKwkvKiBlbXB0 eSBsZWFzZSAqLwo+ICsJbWNsLm9iamVjdF9pZHMgPSAwOwo+ICsJbWNsLm9iamVjdF9jb3VudCA9 IDA7Cj4gKwltY2wuZmxhZ3MgPSAwOwo+ICsJaWd0X2Fzc2VydF9lcShjcmVhdGVfbGVhc2UoZGF0 YS0+bWFzdGVyLmZkLCAmbWNsKSwgLUVJTlZBTCk7Cj4gKwo+ICsJLyogTlVMTCBhcnJheSBwb2lu dGVyICovCj4gKwltY2wub2JqZWN0X2NvdW50ID0gMTsKPiArCWlndF9hc3NlcnRfZXEoY3JlYXRl X2xlYXNlKGRhdGEtPm1hc3Rlci5mZCwgJm1jbCksIC1FRkFVTFQpOwo+ICsKPiArCS8qIG5pbCBv YmplY3QgKi8KPiArCW9iamVjdF9pZHNbMF0gPSAwOwo+ICsJbWNsLm9iamVjdF9pZHMgPSAodWlu dDY0X3QpICh1aW50cHRyX3QpIG9iamVjdF9pZHM7Cj4gKwltY2wub2JqZWN0X2NvdW50ID0gMTsK PiArCWlndF9hc3NlcnRfZXEoY3JlYXRlX2xlYXNlKGRhdGEtPm1hc3Rlci5mZCwgJm1jbCksIC1F Tk9FTlQpOwo+ICsKPiArCS8qIG5vIGNydGMsIG5vbi11bml2ZXJzYWxfcGxhbmUgKi8KPiArCWRy bVNldENsaWVudENhcChkYXRhLT5tYXN0ZXIuZmQsIERSTV9DTElFTlRfQ0FQX1VOSVZFUlNBTF9Q TEFORVMsIDApOwo+ICsJb2JqZWN0X2lkc1swXSA9IGRhdGEtPm1hc3Rlci5kaXNwbGF5Lm91dHB1 dHNbMF0uaWQ7Cj4gKwlpZ3RfYXNzZXJ0X2VxKGNyZWF0ZV9sZWFzZShkYXRhLT5tYXN0ZXIuZmQs ICZtY2wpLCAtRUlOVkFMKTsKPiArCj4gKwkvKiBubyBjb25uZWN0b3IsIG5vbi11bml2ZXJzYWxf cGxhbmUgKi8KPiArCW9iamVjdF9pZHNbMF0gPSBkYXRhLT5tYXN0ZXIuZGlzcGxheS5waXBlc1sw XS5jcnRjX2lkOwo+ICsJaWd0X2Fzc2VydF9lcShjcmVhdGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZk LCAmbWNsKSwgLUVJTlZBTCk7Cj4gKwo+ICsJLyogc2FuaXR5IGNoZWNrICovCj4gKwlvYmplY3Rf aWRzWzBdID0gZGF0YS0+bWFzdGVyLmRpc3BsYXkucGlwZXNbMF0uY3J0Y19pZDsKPiArCW9iamVj dF9pZHNbMV0gPSBkYXRhLT5tYXN0ZXIuZGlzcGxheS5vdXRwdXRzWzBdLmlkOwo+ICsJbWNsLm9i amVjdF9jb3VudCA9IDI7Cj4gKwlpZ3RfYXNzZXJ0X2VxKGNyZWF0ZV9sZWFzZShkYXRhLT5tYXN0 ZXIuZmQsICZtY2wpLCAwKTsKPiArCWNsb3NlKG1jbC5mZCk7Cj4gKwo+ICsJLyogbm8gcGxhbmUs IHVuaXZlcnNhbCBwbGFuZXMgKi8KPiArCWRybVNldENsaWVudENhcChkYXRhLT5tYXN0ZXIuZmQs IERSTV9DTElFTlRfQ0FQX1VOSVZFUlNBTF9QTEFORVMsIDEpOwo+ICsJaWd0X2Fzc2VydF9lcShj cmVhdGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAmbWNsKSwgLUVJTlZBTCk7Cj4gKwo+ICsJLyog c2FuaXR5IGNoZWNrICovCj4gKwlvYmplY3RfaWRzWzJdID0gaWd0X3BpcGVfZ2V0X3BsYW5lX3R5 cGUoJmRhdGEtCj4gPm1hc3Rlci5kaXNwbGF5LnBpcGVzWzBdLAo+ICsJCQkJCQlEUk1fUExBTkVf VFlQRV9QUklNQVJZKS0KPiA+ZHJtX3BsYW5lLT5wbGFuZV9pZDsKPiArCW1jbC5vYmplY3RfY291 bnQgPSAzOwo+ICsJaWd0X2Fzc2VydF9lcShjcmVhdGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAm bWNsKSwgMCk7Cj4gKwljbG9zZShtY2wuZmQpOwo+ICsKPiArCS8qIGFycmF5IG92ZXJmbG93ICov Cj4gKwltY2wub2JqZWN0X2NvdW50ID0gVUlOVDMyX01BWCAvIHNpemVvZihvYmplY3RfaWRzWzBd KSArIDE7Cj4gKwlpZ3RfYXNzZXJ0X2VxKGNyZWF0ZV9sZWFzZShkYXRhLT5tYXN0ZXIuZmQsICZt Y2wpLCAtRU5PTUVNKTsKPiArCW1jbC5vYmplY3RfY291bnQgPSBVSU5UMzJfTUFYIC8gc2l6ZW9m KG9iamVjdF9pZHNbMF0pICsgMjsKPiArCWlndF9hc3NlcnRfZXEoY3JlYXRlX2xlYXNlKGRhdGEt Pm1hc3Rlci5mZCwgJm1jbCksIC1FTk9NRU0pOwo+ICsJbWNsLm9iamVjdF9jb3VudCA9IFVJTlQz Ml9NQVggLyBzaXplb2Yob2JqZWN0X2lkc1swXSkgKyAzOwo+ICsJaWd0X2Fzc2VydF9lcShjcmVh dGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAmbWNsKSwgLUVOT01FTSk7Cj4gKwltY2wub2JqZWN0 X2NvdW50ID0gVUlOVDMyX01BWCAvIHNpemVvZihvYmplY3RfaWRzWzBdKSArIDQ7Cj4gKwlpZ3Rf YXNzZXJ0X2VxKGNyZWF0ZV9sZWFzZShkYXRhLT5tYXN0ZXIuZmQsICZtY2wpLCAtRU5PTUVNKTsK Cm5pdHBpY2s6IGNvdWxkIHByb2JhYmx5IG1ha2UgdGhpcyBhIGxvb3AsIHVwIHRvIHlvdQoKPiAr Cj4gKwkvKiBpbnZhbGlkIGZsYWdzICovCj4gKwltY2wub2JqZWN0X2NvdW50ID0gMzsKPiArCW1j bC5mbGFncyA9IE9fQ0xPRVhFQyB8IE9fTk9OQkxPQ0s7Cj4gKwlpZ3RfYXNzZXJ0X2VxKGNyZWF0 ZV9sZWFzZShkYXRhLT5tYXN0ZXIuZmQsICZtY2wpLCAwKTsKPiArCWNsb3NlKG1jbC5mZCk7CgpJ IHRoaW5rIEknbSBtaXNzaW5nIHNvbWV0aGluZy4gVGhlIGh1bmsgYmVsb3cgdGhpcyBtYWtlcyBz ZW5zZSwgYnV0IEknbSBub3QKcXVpdGUgc3VyZSBJIHVuZGVyc3RhbmQgd2hhdCdzIGhhcHBlbmlu ZyBhYm92ZSBoZXJlPyBeCgpCZXNpZGVzIHRoYXQsIHRoZSByZXN0IG9mIHRoaXMgcGF0Y2ggbG9v a3MgZ29vZCB0byBtZQoKPiArCW1jbC5mbGFncyA9IC0xOwo+ICsJaWd0X2Fzc2VydF9lcShjcmVh dGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAmbWNsKSwgLUVJTlZBTCk7Cj4gKwo+ICsJLyogbm8g c3VibGVhc2luZyAqLwo+ICsJbWNsLm9iamVjdF9jb3VudCA9IDM7Cj4gKwltY2wuZmxhZ3MgPSAw Owo+ICsJaWd0X2Fzc2VydF9lcShjcmVhdGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAmbWNsKSwg MCk7Cj4gKwl0bXBfZmQgPSBtY2wuZmQ7Cj4gKwlpZ3RfYXNzZXJ0X2VxKGNyZWF0ZV9sZWFzZSh0 bXBfZmQsICZtY2wpLCAtRUlOVkFMKTsKPiArCWNsb3NlKHRtcF9mZCk7Cj4gKwo+ICsJLyogbm8g ZG91YmxlLWxlYXNpbmcgKi8KPiArCWlndF9hc3NlcnRfZXEoY3JlYXRlX2xlYXNlKGRhdGEtPm1h c3Rlci5mZCwgJm1jbCksIDApOwo+ICsJdG1wX2ZkID0gbWNsLmZkOwo+ICsJaWd0X2Fzc2VydF9l cShjcmVhdGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAmbWNsKSwgLUVCVVNZKTsKPiArCWNsb3Nl KHRtcF9mZCk7Cj4gKwo+ICsJLyogbm8gZG91YmxlIGxlYXNpbmcgKi8KPiArCW9iamVjdF9pZHNb M10gPSBvYmplY3RfaWRzWzJdOwo+ICsJbWNsLm9iamVjdF9jb3VudCA9IDQ7Cj4gKwkvKiBOb3Rl OiB0aGUgRU5PU1BDIGlzIGZyb20gaWRyIGRvdWJsZS1pbnNlcnRpb24gZmFpbGluZyAqLwo+ICsJ aWd0X2Fzc2VydF9lcShjcmVhdGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAmbWNsKSwgLUVOT1NQ Qyk7Cj4gKwo+ICsJLyogbm8gZW5jb2RlciBsZWFzaW5nICovCj4gKwlyZXNvdXJjZXMgPSBkcm1N b2RlR2V0UmVzb3VyY2VzKGRhdGEtPm1hc3Rlci5mZCk7Cj4gKwlpZ3RfYXNzZXJ0KHJlc291cmNl cyk7Cj4gKwlpZ3RfYXNzZXJ0KHJlc291cmNlcy0+Y291bnRfZW5jb2RlcnMgPiAwKTsKPiArCW9i amVjdF9pZHNbM10gPSByZXNvdXJjZXMtPmVuY29kZXJzWzBdOwo+ICsJaWd0X2Fzc2VydF9lcShj cmVhdGVfbGVhc2UoZGF0YS0+bWFzdGVyLmZkLCAmbWNsKSwgLUVJTlZBTCk7Cj4gKwlkcm1Nb2Rl RnJlZVJlc291cmNlcyhyZXNvdXJjZXMpOwo+ICt9Cj4gKwo+ICBpZ3RfbWFpbgo+ICB7Cj4gIAlk YXRhX3QgZGF0YTsKPiBAQCAtNjU1LDQgKzc1Miw3IEBAIGlndF9tYWluCj4gIAkJCXJ1bl90ZXN0 KCZkYXRhLCBmLT5mdW5jKTsKPiAgCQl9Cj4gIAl9Cj4gKwo+ICsJaWd0X3N1YnRlc3QoImludmFs aWQtY3JlYXRlLWxlYXNlcyIpCj4gKwkJaW52YWxpZF9jcmVhdGVfbGVhc2VzKCZkYXRhKTsKPiAg fQotLSAKQ2hlZXJzLAoJTHl1ZGUgUGF1bAoKX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX18KaWd0LWRldiBtYWlsaW5nIGxpc3QKaWd0LWRldkBsaXN0cy5mcmVl ZGVza3RvcC5vcmcKaHR0cHM6Ly9saXN0cy5mcmVlZGVza3RvcC5vcmcvbWFpbG1hbi9saXN0aW5m by9pZ3QtZGV2