From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomasz Figa Subject: Re: [PATCH v2 2/2] dt: binding: sound cs42l52 driver Date: Wed, 13 Nov 2013 17:47:07 +0100 Message-ID: <1783157.vhfWvslFgW@flatron> References: <1384357474-28653-1-git-send-email-brian.austin@cirrus.com> <1485256.GGQxcSNhvH@flatron> <20131113164328.GW878@sirena.org.uk> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Return-path: In-Reply-To: <20131113164328.GW878-GFdadSzt00ze9xe1eoZjHA@public.gmane.org> Sender: devicetree-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Mark Brown Cc: Brian Austin , alsa-devel-K7yf7f+aM1XWsZ/bQMPhNw@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, lgirdwood-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, rob.herring-bsGFqQB8/DxBDgjK7y7TUQ@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org List-Id: devicetree@vger.kernel.org On Wednesday 13 of November 2013 16:43:28 Mark Brown wrote: > On Wed, Nov 13, 2013 at 05:33:30PM +0100, Tomasz Figa wrote: > > On Wednesday 13 of November 2013 09:44:34 Brian Austin wrote: > > > > + - reset-gpio : GPIO controller's phandle and the number > > > + of the GPIO used to reset the codec. > > > As Kumar has already mentioned, all device-specific properties should be > > prefixed with vendor prefix, "cirrus," in this case. > > The best practice on this one seems to vary somewhat randomly - > sometimes it's a requirement, sometimes it isn't. AFAIR we decided on ARM Mini Summit to mandate this, but maybe my memory is misleading me. > > > > +codec: cs42l52@4a { > > > coding style: Node name should be generic, i.e. codec@4a. > > Is this a constructive thing from a style point of view? We're not > allowed to actually do anything useful with the value at runtime so > people may as well choose what they like. This is what ePAPR says and I believe this is reasonable, because looking at device tree sources you don't need to think what kind of hardware a cs42l52 is. The information that it's a cs42l52 is still contained inside compatible string. Best regards, Tomasz -- To unsubscribe from this list: send the line "unsubscribe devicetree" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html