From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH] i40e: fix shared code compile warning Date: Thu, 26 Jun 2014 14:22:13 +0200 Message-ID: <1785970.8gmsnpVZCs@xps13> References: <1403587377-10287-1-git-send-email-jing.d.chen@intel.com> <2601191342CEEE43887BDE71AB97725821333FA3@IRSMSX105.ger.corp.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: "dev-VfR2kkLFssw@public.gmane.org" To: "Zhang, Helin" , "Ananyev, Konstantin" , "Chen, Jing D" Return-path: In-Reply-To: List-Id: patches and discussions about DPDK List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces-VfR2kkLFssw@public.gmane.org Sender: "dev" 2014-06-24 14:43, Ananyev, Konstantin: > Yes, it is much nicer to fix it in i40e_lan_hmc.c. > But I don't really want us to open that door. > So my vote would be to initial Mark's patch: add '-Wno-error' in the > Makefile. 2014-06-24 15:25, Zhang, Helin: > We should not modify code in shared code, if we do not want to maintain > those huge code base. I think Mark's patch good for now, we can report that > issue to shared code maintainers, and try to get them to fix it later. 2014-06-25 05:36, Chen, Jing D: > my committed patch to ignore the warning on that file and continue the > compile . By doing so, the logic is right and didn't change code's > behavior. We also needn't maintain it. Even in bad case we find bugs > hidden behind the '--CFLAGS_i40e_lan_hmc.0' warning in future, we can fix > it after bug occurred. That's simple. Applied for version 1.7.0. Thanks -- Thomas