Re: [PATCH 06/11] nfs-utils: mount: AUTH_NONE mounts

From: Neil Brown <neilb@suse.de>
To: Steve Dickson <SteveD@redhat.com>
Cc: nfs@lists.sourceforge.net
Subject: Re: [PATCH 06/11] nfs-utils: mount:  AUTH_NONE mounts
Date: Tue, 27 Feb 2007 17:14:29 +1100	[thread overview]
Message-ID: <17891.52293.103984.465480@notabene.brown> (raw)
In-Reply-To: message from Steve Dickson on Monday February 26

On Monday February 26, SteveD@redhat.com wrote:
> commit 0ffd74c990aca3761b79316d47e1b1778273681c
> Author: Steve Dickson <steved@redhat.com>
> Date:   Sat Feb 24 15:27:46 2007 -0500
> 
>     Added support to specify the AUTH_NONE security flavor (i.e. -o sec=none)

If you specify "-o sec=none" then data.pseudoflavor will == AUTH_NONE,
but

>     
>     Signed-off-by: Steve Dickson <steved@redhat.com>
> 
> diff --git a/utils/mount/nfsmount.c b/utils/mount/nfsmount.c
> index d437036..7759260 100644
> --- a/utils/mount/nfsmount.c
> +++ b/utils/mount/nfsmount.c
> @@ -1093,12 +1093,14 @@ nfsmount(const char *spec, const char *node, int *flags,
>  
>  		flavor = mountres->auth_flavors.auth_flavors_val;
>  		while (--i >= 0) {
> -			if (flavor[i] == data.pseudoflavor)
> -				yum = 1;
>  #ifdef NFS_MOUNT_DEBUG
> -			printf("auth flavor %d: %d\n",
> -				i, flavor[i]);
> +			printf("auth flavor[%d] %d\n", i, flavor[i]);
>  #endif
> +			if (flavor[i] == data.pseudoflavor ||
> +				flavor[i] == AUTH_NONE) {
> +				yum = 1;
> +				break;
> +			}

You are testing if flavor[i] == AUTH_NONE, which doesn't make sense to
me....

NeilBrown

-------------------------------------------------------------------------
Take Surveys. Earn Cash. Influence the Future of IT
Join SourceForge.net's Techsay panel and you'll get the chance to share your
opinions on IT & business topics through brief surveys-and earn cash
http://www.techsay.com/default.php?page=join.php&p=sourceforge&CID=DEVDEV
_______________________________________________
NFS maillist  -  NFS@lists.sourceforge.net
https://lists.sourceforge.net/lists/listinfo/nfs