From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 04/22] drm/i915: Hold a ref to the ring while retiring Date: Mon, 18 Mar 2019 10:46:28 +0000 Message-ID: <178d3bdf-4964-a210-49fa-d840ff2ddaa5@linux.intel.com> References: <20190318095204.9913-1-chris@chris-wilson.co.uk> <20190318095204.9913-4-chris@chris-wilson.co.uk> <3187f2b5-b5a4-8b9d-54cf-e2b8914e1193@linux.intel.com> <155290544484.4168.2554450930128320701@skylake-alporthouse-com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga12.intel.com (mga12.intel.com [192.55.52.136]) by gabe.freedesktop.org (Postfix) with ESMTPS id 4A7C58923C for ; Mon, 18 Mar 2019 10:46:31 +0000 (UTC) In-Reply-To: <155290544484.4168.2554450930128320701@skylake-alporthouse-com> Content-Language: en-US List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzAzLzIwMTkgMTA6MzcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE5LTAzLTE4IDEwOjMxOjU3KQo+Pgo+PiBPbiAxOC8wMy8yMDE5IDA5OjUx LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBBcyB0aGUgZmluYWwgcmVxdWVzdCBvbiBhIHJpbmcg bWF5IGhvbGQgdGhlIHJlZmVyZW5jZSB0byB0aGlzIHJpbmcgKHZpYQo+Pj4gcmV0aXJpbmcgdGhl IGxhc3QgcGlubmVkIGNvbnRleHQpLCB3ZSBtYXkgZmluZCBvdXJzZWx2ZXMgY2hhc2luZyBhCj4+ PiBkYW5nbGluZyBwb2ludGVyIG9uIGNvbXBsZXRpb24gb2YgdGhlIGxpc3QuCj4+Pgo+Pj4gQSBx dWljayBzb2x1dGlvbiBpcyB0byBob2xkIGEgcmVmZXJlbmNlIHRvIHRoZSByaW5nIGl0c2VsZiBh cyB3ZSByZXRpcmUKPj4+IGFsb25nIGl0IHNvIHRoYXQgd2Ugb25seSBmcmVlIGl0IGFmdGVyIHdl IHN0b3AgZGVyZWZlcmVuY2luZyBpdC4KPj4KPj4gSXMgdGhlcmUgYSBndWlsdHkgY29tbWl0IHRv IHJlZmVyZW5jZSBhcyBGaXhlczogPwo+IAo+IEl0IG9ubHkgYmVjb21lcyBhIHByb2JsZW0gd2l0 aCB2ZW5nIGFzIHdlIGdhaW4gYW4gaW1tZWRpYXRlIGZyZWUgcGF0aCwKPiB3aGVyZWFzIGF0IHRo ZSBtb21lbnQsIGNvbnRleHQgZnJlZXMgYXJlIGRlZmVycmVkIHVudGlsIHRoZXkgY2FuIGFjcXVp cmUKPiB0aGUgc3RydWN0X211dGV4LiBXZSBjYW5ub3QgaGl0IHRoaXMgcGF0aCBhdCB0aGUgbW9t ZW50LCBidXQgdGhhdCB3ZSBoYWQKPiB0byB1c2UgdGhlIHNhZmUgaXRlcmF0b3IgaW1wbGllcyB0 aGF0IHdlIHdlcmUgYXdhcmUgdGhhdCB0aGUgcmluZyBpdHNlbGYKPiBjb3VsZCBkaXNhcHBlYXIu IElmIHlvdSB3YW50ZWQgdG8gcGluIGl0IG9uIHNvbWV0aGluZywKPiAKPiBSZWZlcmVuY2VzOiBi ODg3ZDYxNTQ2MjQgKCJkcm0vaTkxNTogUmV0aXJlIHJlcXVlc3RzIGFsb25nIHJpbmdzIikKPiAK Pj4+IFNpZ25lZC1vZmYtYnk6IENocmlzIFdpbHNvbiA8Y2hyaXNAY2hyaXMtd2lsc29uLmNvLnVr Pgo+Pj4gLS0tCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYyAgICAg ICAgICB8ICA2ICsrKysrLQo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfZW5naW5l X3R5cGVzLmggICAgfCAgMiArKwo+Pj4gICAgZHJpdmVycy9ncHUvZHJtL2k5MTUvaW50ZWxfbHJj LmMgICAgICAgICAgICAgfCAgNCArKy0tCj4+PiAgICBkcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF9yaW5nYnVmZmVyLmMgICAgICB8ICA5ICsrKysrLS0tLQo+Pj4gICAgZHJpdmVycy9ncHUvZHJt L2k5MTUvaW50ZWxfcmluZ2J1ZmZlci5oICAgICAgfCAxMyArKysrKysrKysrKystCj4+PiAgICBk cml2ZXJzL2dwdS9kcm0vaTkxNS9zZWxmdGVzdHMvbW9ja19lbmdpbmUuYyB8ICAxICsKPj4+ICAg IDYgZmlsZXMgY2hhbmdlZCwgMjcgaW5zZXJ0aW9ucygrKSwgOCBkZWxldGlvbnMoLSkKPj4+Cj4+ PiBkaWZmIC0tZ2l0IGEvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMgYi9kcml2 ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3JlcXVlc3QuYwo+Pj4gaW5kZXggOTUzM2E4NWNiMGIzLi4w YTNkOTQ1MTdkMGEgMTAwNjQ0Cj4+PiAtLS0gYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pOTE1X3Jl cXVlc3QuYwo+Pj4gKysrIGIvZHJpdmVycy9ncHUvZHJtL2k5MTUvaTkxNV9yZXF1ZXN0LmMKPj4+ IEBAIC0xMzMyLDggKzEzMzIsMTIgQEAgdm9pZCBpOTE1X3JldGlyZV9yZXF1ZXN0cyhzdHJ1Y3Qg ZHJtX2k5MTVfcHJpdmF0ZSAqaTkxNSkKPj4+ICAgICAgICBpZiAoIWk5MTUtPmd0LmFjdGl2ZV9y ZXF1ZXN0cykKPj4+ICAgICAgICAgICAgICAgIHJldHVybjsKPj4+ICAgIAo+Pj4gLSAgICAgbGlz dF9mb3JfZWFjaF9lbnRyeV9zYWZlKHJpbmcsIHRtcCwgJmk5MTUtPmd0LmFjdGl2ZV9yaW5ncywg YWN0aXZlX2xpbmspCj4+PiArICAgICBsaXN0X2Zvcl9lYWNoX2VudHJ5X3NhZmUocmluZywgdG1w LAo+Pj4gKyAgICAgICAgICAgICAgICAgICAgICAgICAgICAgICZpOTE1LT5ndC5hY3RpdmVfcmlu Z3MsIGFjdGl2ZV9saW5rKSB7Cj4+PiArICAgICAgICAgICAgIGludGVsX3JpbmdfZ2V0KHJpbmcp OyAvKiBsYXN0IHJxIGhvbGRzIHJlZmVyZW5jZSEgKi8KPj4+ICAgICAgICAgICAgICAgIHJpbmdf cmV0aXJlX3JlcXVlc3RzKHJpbmcpOwo+Pj4gKyAgICAgICAgICAgICBpbnRlbF9yaW5nX3B1dChy aW5nKTsKPj4+ICsgICAgIH0KPj4KPj4gV2hlcmUgZG9lcyBpdCBjaGFzZSBhIGRhbmdsaW5nIHBv aW50ZXI/IEl0IHVzZWQgdGhlIHNhZmUgaXRlcmF0b3IgYWxyZWFkeS4KPiAKPiBJbnNpZGUgcmlu Z19yZXRpcmVfcmVxdWVzdHMoKTsgdGhlIHVzZSBvZiBfc2FmZSBoZXJlIGFjdHVhbGx5IGltcGxp ZXMgd2UKPiBtZXQgdGhpcyBwcm9ibGVtIGFscmVhZHkgOikKCkkgZ2V0IGl0LCB0aGUgaXNzdWUg aXMgZHVyaW5nIHJpbmctPnJlcXVlc3RfbGlzdCBpdGVyYXRpb24gaW4gCnJpbmdfcmV0aXJlX3Jl cXVlc3RzLiBIb3cgYWJvdXQgbW92ZSByaW5nIHBpbm5pbmcgaW4gdGhlcmUgc28gaXQgaXMgY2xl YXJlcj8KClJlZ2FyZHMsCgpUdnJ0a28KX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19f X19fX19fX19fX19fX18KSW50ZWwtZ2Z4IG1haWxpbmcgbGlzdApJbnRlbC1nZnhAbGlzdHMuZnJl ZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlzdHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGlu Zm8vaW50ZWwtZ2Z4