From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-13.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 3E2DCC64E7C for ; Wed, 2 Dec 2020 19:10:28 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id DDCA422254 for ; Wed, 2 Dec 2020 19:10:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2389705AbgLBTK1 convert rfc822-to-8bit (ORCPT ); Wed, 2 Dec 2020 14:10:27 -0500 Received: from youngberry.canonical.com ([91.189.89.112]:52727 "EHLO youngberry.canonical.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S2387967AbgLBTK0 (ORCPT ); Wed, 2 Dec 2020 14:10:26 -0500 Received: from 1.general.jvosburgh.uk.vpn ([10.172.196.206] helo=famine.localdomain) by youngberry.canonical.com with esmtpsa (TLS1.2:ECDHE_RSA_AES_128_GCM_SHA256:128) (Exim 4.86_2) (envelope-from ) id 1kkXVU-00028c-Gv; Wed, 02 Dec 2020 19:09:40 +0000 Received: by famine.localdomain (Postfix, from userid 1000) id 15B995FEE8; Wed, 2 Dec 2020 11:09:39 -0800 (PST) Received: from famine (localhost [127.0.0.1]) by famine.localdomain (Postfix) with ESMTP id 0FF229FAB0; Wed, 2 Dec 2020 11:09:39 -0800 (PST) From: Jay Vosburgh To: Tobias Waldekranz cc: davem@davemloft.net, kuba@kernel.org, andrew@lunn.ch, vivien.didelot@gmail.com, f.fainelli@gmail.com, olteanv@gmail.com, vfalico@gmail.com, andy@greyhouse.net, netdev@vger.kernel.org Subject: Re: [PATCH v3 net-next 1/4] net: bonding: Notify ports about their initial state In-reply-to: <20201202091356.24075-2-tobias@waldekranz.com> References: <20201202091356.24075-1-tobias@waldekranz.com> <20201202091356.24075-2-tobias@waldekranz.com> Comments: In-reply-to Tobias Waldekranz message dated "Wed, 02 Dec 2020 10:13:53 +0100." X-Mailer: MH-E 8.6+git; nmh 1.6; GNU Emacs 27.0.50 MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <17901.1606936179.1@famine> Content-Transfer-Encoding: 8BIT Date: Wed, 02 Dec 2020 11:09:39 -0800 Message-ID: <17902.1606936179@famine> Precedence: bulk List-ID: X-Mailing-List: netdev@vger.kernel.org Tobias Waldekranz wrote: >When creating a static bond (e.g. balance-xor), all ports will always >be enabled. This is set, and the corresponding notification is sent >out, before the port is linked to the bond upper. > >In the offloaded case, this ordering is hard to deal with. > >The lower will first see a notification that it can not associate with >any bond. Then the bond is joined. After that point no more >notifications are sent, so all ports remain disabled. > >This change simply sends an extra notification once the port has been >linked to the upper to synchronize the initial state. I'm not objecting to this per se, but looking at team and net_failover (failover_slave_register), those drivers do not send the same first notification that bonding does (the "can not associate" one), but only send a notification after netdev_master_upper_dev_link is complete. Does it therefore make more sense to move the existing notification within bonding to take place after the upper_dev_link (where you're adding this new call to bond_lower_state_changed)? If the existing notification is effectively useless, this would make the sequence of notifications consistent across drivers. -J >Signed-off-by: Tobias Waldekranz >--- > drivers/net/bonding/bond_main.c | 2 ++ > 1 file changed, 2 insertions(+) > >diff --git a/drivers/net/bonding/bond_main.c b/drivers/net/bonding/bond_main.c >index e0880a3840d7..d6e1f9cf28d5 100644 >--- a/drivers/net/bonding/bond_main.c >+++ b/drivers/net/bonding/bond_main.c >@@ -1922,6 +1922,8 @@ int bond_enslave(struct net_device *bond_dev, struct net_device *slave_dev, > goto err_unregister; > } > >+ bond_lower_state_changed(new_slave); >+ > res = bond_sysfs_slave_add(new_slave); > if (res) { > slave_dbg(bond_dev, slave_dev, "Error %d calling bond_sysfs_slave_add\n", res); >-- >2.17.1 > --- -Jay Vosburgh, jay.vosburgh@canonical.com