From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7 6/9] ethdev: add common devargs parser Date: Tue, 24 Apr 2018 21:53:38 +0200 Message-ID: <1794949.DGStqB9iLD@xps> References: <20180328135433.20203-1-declan.doherty@intel.com> <20180416130605.6509-1-declan.doherty@intel.com> <20180416130605.6509-7-declan.doherty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Adrien Mazarguil , Ferruh Yigit , Shahaf Shuler To: Declan Doherty , Remy Horton Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 363C82C2F for ; Tue, 24 Apr 2018 21:53:41 +0200 (CEST) In-Reply-To: <20180416130605.6509-7-declan.doherty@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 16/04/2018 15:06, Declan Doherty: > From: Remy Horton > > Introduces a new structure, rte_eth_devargs, to support generic > ethdev arguments common across NET PMDs, with a new API > rte_eth_devargs_parse API to support PMD parsing these arguments. Most of the parsing functions should be removed when the new devargs framework will be ready. So I won't look specifically at this code. But I would like to review the devargs you are standardizing. Unfortunately, I cannot find a documentation about it. How users are supposed to use it? Can you, at least, describe the syntax in the commit log, please?