From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B9D57C4338F for ; Tue, 10 Aug 2021 15:36:02 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 9EA8C60720 for ; Tue, 10 Aug 2021 15:36:02 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S243280AbhHJPgX (ORCPT ); Tue, 10 Aug 2021 11:36:23 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:49300 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S242041AbhHJPgR (ORCPT ); Tue, 10 Aug 2021 11:36:17 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628609755; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=pQuJr7Ds39z6uYEw+kh5aIvtiC3dxt3i1eb/vtWoNzI=; b=GfWbdR7jyxbMbwKRfWLNJJjJ8mZQZ4V8Kd+V4aicDDxxxoJb1CZ+t++x8y0aHfvvtYxRg3 A8hKDbWp2bhoN93HVMwR8NZeN0M+swJxpnKm2yWJQlyL4yPOMUYIxa7ycd3N2nTNPes6+R rg9W6KL0FTzqb6DL4T47eCQynRWTArU= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-82-cYEMvEvLNe-WOlg089RZLg-1; Tue, 10 Aug 2021 11:35:51 -0400 X-MC-Unique: cYEMvEvLNe-WOlg089RZLg-1 Received: from smtp.corp.redhat.com (int-mx02.intmail.prod.int.phx2.redhat.com [10.5.11.12]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 9CB37801AE7; Tue, 10 Aug 2021 15:35:48 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 02E2C60C05; Tue, 10 Aug 2021 15:35:45 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-24-willy@infradead.org> References: <20210715033704.692967-24-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Vlastimil Babka , William Kucharski , Christoph Hellwig , "Kirill A . Shutemov" Subject: Re: [PATCH v14 023/138] mm/swap: Add folio_rotate_reclaimable() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1796498.1628609745.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 16:35:45 +0100 Message-ID: <1796499.1628609745@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.79 on 10.5.11.12 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > Convert rotate_reclaimable_page() to folio_rotate_reclaimable(). This > eliminates all five of the calls to compound_head() in this function, > saving 75 bytes at the cost of adding 15 bytes to its one caller, > end_page_writeback(). We also save 36 bytes from pagevec_move_tail_fn() > due to using folios there. Net 96 bytes savings. > > Also move its declaration to mm/internal.h as it's only used by filemap.c. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Vlastimil Babka > Reviewed-by: William Kucharski > Reviewed-by: Christoph Hellwig > Acked-by: Kirill A. Shutemov Reviewed-by: David Howells