From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 2F38BC432BE for ; Wed, 1 Sep 2021 17:37:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 0699A60FDC for ; Wed, 1 Sep 2021 17:37:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1344506AbhIARiA (ORCPT ); Wed, 1 Sep 2021 13:38:00 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:23365 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231852AbhIARh6 (ORCPT ); Wed, 1 Sep 2021 13:37:58 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630517820; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=xhdpu5W1fJXLeojM24bKC1MSSzMuWR+Cf49l2mlXcbA=; b=QYhBsp8LKCkVthp2pGFQp4b53rwNsuYnxeg+pARmkaEKdokzl2hJax6xeRzDx4qHEQDXyk LqrtCikHgoP87X0qkhSjlGRhDlazEfSFuXagWUjkyJ9Bk+dxYChiexVavtNxnCwC49jkZv qHbQAvPDMHwmDMQSTJln9jB4WyQOoBI= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-377-vPtR8mibOjGdW4PL0N-50A-1; Wed, 01 Sep 2021 13:36:59 -0400 X-MC-Unique: vPtR8mibOjGdW4PL0N-50A-1 Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id E2A7C801A92; Wed, 1 Sep 2021 17:36:57 +0000 (UTC) Received: from x2.localnet (unknown [10.22.8.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 74C9A5C1BB; Wed, 1 Sep 2021 17:36:56 +0000 (UTC) From: Steve Grubb To: Cai Huoqing , Eugene Syromiatnikov Cc: linux-audit@redhat.com, strace development discussions , linux-api@vger.kernel.org, davem@davemloft.net, yoshfuji@linux-ipv6.org, dsahern@kernel.org, kuba@kernel.org, netdev@vger.kernel.org, linux-kernel@vger.kernel.org, ldv@strace.io Subject: Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files Date: Wed, 01 Sep 2021 13:36:54 -0400 Message-ID: <1797920.tdWV9SEqCh@x2> Organization: Red Hat In-Reply-To: <20210901165202.GA4518@asgard.redhat.com> References: <20210813120803.101-1-caihuoqing@baidu.com> <20210901160244.GA5957@asgard.redhat.com> <20210901165202.GA4518@asgard.redhat.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Hello, Thanks for the heads up. On Wednesday, September 1, 2021 12:52:02 PM EDT Eugene Syromiatnikov wrote: > Adding linux-audit, strace-devel, and linux-api to CC:. > > On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote: > > On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote: > > > commit <47595e32869f> ("") > > > indicated the ipx network layer as obsolete in Jan 2018, > > > updated in the MAINTAINERS file > > > > > > now, after being exposed for 3 years to refactoring, so to > > > delete uapi/linux/ipx.h and net/ipx.h header files for good. > > > additionally, there is no module that depends on ipx.h except > > > a broken staging driver(r8188eu) > > > > > > Signed-off-by: Cai Huoqing > > > > This removal breaks audit[1] and potentially breaks strace[2][3], at > > least. I wouldn't say breaks so much as needs coordination with. :-) If ipx is being dropped in its entirety, I can just make that part of the code conditional to the header existing. -Steve > > [1] > > https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e1 > > 40c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2] > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e > > d7106d6b/src/net.c#L34 [3] > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e > > d7106d6b/src/sockaddr.c#L30 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-16.1 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,MENTIONS_GIT_HOSTING,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8C7AC432BE for ; Wed, 1 Sep 2021 17:47:36 +0000 (UTC) Received: from us-smtp-delivery-124.mimecast.com (us-smtp-delivery-124.mimecast.com [216.205.24.124]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3D7B461059 for ; Wed, 1 Sep 2021 17:47:36 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 3D7B461059 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=tempfail smtp.mailfrom=redhat.com DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1630518455; h=from:from:sender:sender:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references:list-id:list-help: list-unsubscribe:list-subscribe:list-post; bh=slpIfw+tdqJFtmpIR+Y1eXdo3Znu4f5fyt2gaValpwA=; b=hVp2/eb4vtqw50Qf7ogjEaH0K6LbFtvrJcpSnYJQPy6X8zuCJXKkCOL/NY4jCtoxjZA+s2 nF739VmbSPeSpYy5YpEMRoeT8vDTXBXB31azEcdTMkRPhdQ5TvT2wBZnvIsqVtfmggZA+H wjMzuQZ4OxtpwVy7Mi0Y3Ep5BTX0I9E= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-311-sGj58Js9OsybuhjcG8qyKQ-1; Wed, 01 Sep 2021 13:47:33 -0400 X-MC-Unique: sGj58Js9OsybuhjcG8qyKQ-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D466B5131; Wed, 1 Sep 2021 17:47:29 +0000 (UTC) Received: from colo-mx.corp.redhat.com (colo-mx01.intmail.prod.int.phx2.redhat.com [10.5.11.20]) by smtp.corp.redhat.com (Postfix) with ESMTPS id 7FE5510074E0; Wed, 1 Sep 2021 17:47:28 +0000 (UTC) Received: from lists01.pubmisc.prod.ext.phx2.redhat.com (lists01.pubmisc.prod.ext.phx2.redhat.com [10.5.19.33]) by colo-mx.corp.redhat.com (Postfix) with ESMTP id 19C991809C98; Wed, 1 Sep 2021 17:47:26 +0000 (UTC) Received: from smtp.corp.redhat.com (int-mx06.intmail.prod.int.phx2.redhat.com [10.5.11.16]) by lists01.pubmisc.prod.ext.phx2.redhat.com (8.13.8/8.13.8) with ESMTP id 181HavcY009715 for ; Wed, 1 Sep 2021 13:36:57 -0400 Received: by smtp.corp.redhat.com (Postfix) id E106E5C25A; Wed, 1 Sep 2021 17:36:57 +0000 (UTC) Received: from x2.localnet (unknown [10.22.8.210]) by smtp.corp.redhat.com (Postfix) with ESMTP id 74C9A5C1BB; Wed, 1 Sep 2021 17:36:56 +0000 (UTC) From: Steve Grubb To: Cai Huoqing , Eugene Syromiatnikov Subject: Re: [PATCH 1/2] net: Remove net/ipx.h and uapi/linux/ipx.h header files Date: Wed, 01 Sep 2021 13:36:54 -0400 Message-ID: <1797920.tdWV9SEqCh@x2> Organization: Red Hat In-Reply-To: <20210901165202.GA4518@asgard.redhat.com> References: <20210813120803.101-1-caihuoqing@baidu.com> <20210901160244.GA5957@asgard.redhat.com> <20210901165202.GA4518@asgard.redhat.com> MIME-Version: 1.0 X-Scanned-By: MIMEDefang 2.79 on 10.5.11.16 X-loop: linux-audit@redhat.com Cc: yoshfuji@linux-ipv6.org, linux-api@vger.kernel.org, dsahern@kernel.org, linux-kernel@vger.kernel.org, ldv@strace.io, linux-audit@redhat.com, netdev@vger.kernel.org, kuba@kernel.org, davem@davemloft.net, strace development discussions X-BeenThere: linux-audit@redhat.com X-Mailman-Version: 2.1.12 Precedence: junk List-Id: Linux Audit Discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Sender: linux-audit-bounces@redhat.com Errors-To: linux-audit-bounces@redhat.com X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=linux-audit-bounces@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Hello, Thanks for the heads up. On Wednesday, September 1, 2021 12:52:02 PM EDT Eugene Syromiatnikov wrote: > Adding linux-audit, strace-devel, and linux-api to CC:. > > On Wed, Sep 01, 2021 at 06:02:44PM +0200, Eugene Syromiatnikov wrote: > > On Fri, Aug 13, 2021 at 08:08:02PM +0800, Cai Huoqing wrote: > > > commit <47595e32869f> ("") > > > indicated the ipx network layer as obsolete in Jan 2018, > > > updated in the MAINTAINERS file > > > > > > now, after being exposed for 3 years to refactoring, so to > > > delete uapi/linux/ipx.h and net/ipx.h header files for good. > > > additionally, there is no module that depends on ipx.h except > > > a broken staging driver(r8188eu) > > > > > > Signed-off-by: Cai Huoqing > > > > This removal breaks audit[1] and potentially breaks strace[2][3], at > > least. I wouldn't say breaks so much as needs coordination with. :-) If ipx is being dropped in its entirety, I can just make that part of the code conditional to the header existing. -Steve > > [1] > > https://github.com/linux-audit/audit-userspace/blob/ce58837d44b7d9fcb4e1 > > 40c23f68e0c94d95ab6e/auparse/interpret.c#L48 [2] > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e > > d7106d6b/src/net.c#L34 [3] > > https://gitlab.com/strace/strace/-/blob/9fe63f42df8badd22fb7eef9c12fc07e > > d7106d6b/src/sockaddr.c#L30 -- Linux-audit mailing list Linux-audit@redhat.com https://listman.redhat.com/mailman/listinfo/linux-audit