All of lore.kernel.org
 help / color / mirror / Atom feed
* [PATCH] Fix rate computation
@ 2017-03-21  9:54 Julien Castets
  2017-03-21 14:48 ` Wiles, Keith
  0 siblings, 1 reply; 2+ messages in thread
From: Julien Castets @ 2017-03-21  9:54 UTC (permalink / raw)
  To: dev; +Cc: Julien Castets

From: Julien Castets <jcastets@scaleway.com>

Signed-off-by: Julien Castets <jcastets@scaleway.com>
---
 app/pktgen.c | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/app/pktgen.c b/app/pktgen.c
index e315bff..9a304c0 100644
--- a/app/pktgen.c
+++ b/app/pktgen.c
@@ -110,7 +110,7 @@ pktgen_packet_rate(port_info_t *info)
 	uint64_t cpp = (pps > 0) ? (pktgen.hz / pps) : (pktgen.hz / 4);
 
 	info->tx_pps    = pps;
-	info->tx_cycles = ((cpp * info->tx_burst) / get_port_txcnt(pktgen.l2p, info->pid));
+	info->tx_cycles = ((cpp * info->tx_burst) * get_port_txcnt(pktgen.l2p, info->pid));
 }
 
 /**************************************************************************//**
-- 
2.11.0

^ permalink raw reply related	[flat|nested] 2+ messages in thread

* Re: [PATCH] Fix rate computation
  2017-03-21  9:54 [PATCH] Fix rate computation Julien Castets
@ 2017-03-21 14:48 ` Wiles, Keith
  0 siblings, 0 replies; 2+ messages in thread
From: Wiles, Keith @ 2017-03-21 14:48 UTC (permalink / raw)
  To: Julien Castets; +Cc: dev, Julien Castets


> On Mar 21, 2017, at 4:54 AM, Julien Castets <castets.j@gmail.com> wrote:
> 
> From: Julien Castets <jcastets@scaleway.com>
> 
> Signed-off-by: Julien Castets <jcastets@scaleway.com>
> ---
> app/pktgen.c | 2 +-
> 1 file changed, 1 insertion(+), 1 deletion(-)
> 
> diff --git a/app/pktgen.c b/app/pktgen.c
> index e315bff..9a304c0 100644
> --- a/app/pktgen.c
> +++ b/app/pktgen.c
> @@ -110,7 +110,7 @@ pktgen_packet_rate(port_info_t *info)
> 	uint64_t cpp = (pps > 0) ? (pktgen.hz / pps) : (pktgen.hz / 4);
> 
> 	info->tx_pps    = pps;
> -	info->tx_cycles = ((cpp * info->tx_burst) / get_port_txcnt(pktgen.l2p, info->pid));
> +	info->tx_cycles = ((cpp * info->tx_burst) * get_port_txcnt(pktgen.l2p, info->pid));
> }

I have already made the change, thanks for the patch. I assumed it fixed the problem as I have not found an email confirming the fix. Thanks.

> 
> /**************************************************************************//**
> -- 
> 2.11.0
> 

Regards,
Keith

^ permalink raw reply	[flat|nested] 2+ messages in thread

end of thread, other threads:[~2017-03-21 14:48 UTC | newest]

Thread overview: 2+ messages (download: mbox.gz / follow: Atom feed)
-- links below jump to the message on this page --
2017-03-21  9:54 [PATCH] Fix rate computation Julien Castets
2017-03-21 14:48 ` Wiles, Keith

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.