From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-15.3 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 15A80C4743C for ; Wed, 23 Jun 2021 10:53:09 +0000 (UTC) Received: from phobos.denx.de (phobos.denx.de [85.214.62.61]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 3414E60FF2 for ; Wed, 23 Jun 2021 10:53:08 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 3414E60FF2 Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: from h2850616.stratoserver.net (localhost [IPv6:::1]) by phobos.denx.de (Postfix) with ESMTP id D7BA580EC5; Wed, 23 Jun 2021 12:53:05 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=u-boot-bounces@lists.denx.de Received: by phobos.denx.de (Postfix, from userid 109) id 47103829C3; Wed, 23 Jun 2021 12:53:04 +0200 (CEST) Received: from mx.socionext.com (mx.socionext.com [202.248.49.38]) by phobos.denx.de (Postfix) with ESMTP id 1E8F180050 for ; Wed, 23 Jun 2021 12:52:59 +0200 (CEST) Authentication-Results: phobos.denx.de; dmarc=none (p=none dis=none) header.from=socionext.com Authentication-Results: phobos.denx.de; spf=pass smtp.mailfrom=hayashi.kunihiko@socionext.com Received: from unknown (HELO iyokan2-ex.css.socionext.com) ([172.31.9.54]) by mx.socionext.com with ESMTP; 23 Jun 2021 19:52:57 +0900 Received: from mail.mfilter.local (m-filter-1 [10.213.24.61]) by iyokan2-ex.css.socionext.com (Postfix) with ESMTP id 6C1A8205902A; Wed, 23 Jun 2021 19:52:57 +0900 (JST) Received: from 172.31.9.51 (172.31.9.51) by m-FILTER with ESMTP; Wed, 23 Jun 2021 19:52:57 +0900 Received: from yuzu2.css.socionext.com (yuzu2 [172.31.9.57]) by kinkan2.css.socionext.com (Postfix) with ESMTP id E39C4B62BA; Wed, 23 Jun 2021 19:52:56 +0900 (JST) Received: from [10.212.21.250] (unknown [10.212.21.250]) by yuzu2.css.socionext.com (Postfix) with ESMTP id C0F676DE45; Wed, 23 Jun 2021 19:52:54 +0900 (JST) Subject: Re: [PATCH] serial: zynq: Add support for serial parameters To: Michal Simek Cc: u-boot@lists.denx.de References: <1624335861-4025-1-git-send-email-hayashi.kunihiko@socionext.com> <3f3f0bca-b293-aecf-9c76-9309686467d6@xilinx.com> From: Kunihiko Hayashi Message-ID: <179a1920-3f43-d549-26f2-df4188a5f5ea@socionext.com> Date: Wed, 23 Jun 2021 19:52:53 +0900 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:78.0) Gecko/20100101 Thunderbird/78.9.1 MIME-Version: 1.0 In-Reply-To: <3f3f0bca-b293-aecf-9c76-9309686467d6@xilinx.com> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit X-BeenThere: u-boot@lists.denx.de X-Mailman-Version: 2.1.34 Precedence: list List-Id: U-Boot discussion List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: u-boot-bounces@lists.denx.de Sender: "U-Boot" X-Virus-Scanned: clamav-milter 0.103.2 at phobos.denx.de X-Virus-Status: Clean Hi Michal, On 2021/06/22 21:44, Michal Simek wrote: > Hi, > > On 6/22/21 6:24 AM, Kunihiko Hayashi wrote: >> This adds serial parameters that include stop bit mode, parity mode, >> and character length. Mark parity and space parity modes are not >> supported. >> >> Signed-off-by: Kunihiko Hayashi >> --- >> drivers/serial/serial_zynq.c | 64 ++++++++++++++++++++++++++++++++++++++++++++ >> 1 file changed, 64 insertions(+) [snip] > I am just curious how you have tested it because only hook is in > test/dm/serial.c and I can't see no way how to change this setting via > u-boot command line. I was misunderstanding. Surely there is no way to execute .setconfig function, and neither command line nor devicetree actually affects the serial mode. The mode just inherits that of the previous firmware. > That being said I see that this change adds 184 bytes which is quite a > lot especially for SPL on zynqmp. That's why would like to know how this > feature should be used. If make sense for example to limit it to only > full U-Boot. I see. I didn't think enough about the size limit of SPL. Anyway, I withdraw this patch. Thank you, --- Best Regards Kunihiko Hayashi