From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1753231AbdLMOE3 (ORCPT ); Wed, 13 Dec 2017 09:04:29 -0500 Received: from www1.m-privacy.de ([85.214.254.135]:32906 "EHLO www1.m-privacy.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1752909AbdLMOEY (ORCPT ); Wed, 13 Dec 2017 09:04:24 -0500 X-Greylist: delayed 617 seconds by postgrey-1.27 at vger.kernel.org; Wed, 13 Dec 2017 09:04:23 EST Subject: Re: [PATCH] mm: save current->journal_info before calling fault/page_mkwrite To: "Yan, Zheng" , linux-kernel@vger.kernel.org, linux-fsdevel@vger.kernel.org, ceph-devel@vger.kernel.org, linux-ext4@vger.kernel.org Cc: akpm@linux-foundation.org, viro@zeniv.linux.org.uk, jlayton@redhat.com References: <20171213035836.916-1-zyan@redhat.com> From: Amon Ott Message-ID: <17a0b877-fa5e-fb1d-aa6d-2390d792c6e6@m-privacy.de> Date: Wed, 13 Dec 2017 14:53:55 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:52.0) Gecko/20100101 Thunderbird/52.5.0 MIME-Version: 1.0 In-Reply-To: <20171213035836.916-1-zyan@redhat.com> Content-Type: text/plain; charset=utf-8 Content-Language: de-DE Content-Transfer-Encoding: 8bit Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Am 13.12.2017 um 04:58 schrieb Yan, Zheng: > We recently got an Oops report: > > BUG: unable to handle kernel NULL pointer dereference at (null) > IP: jbd2__journal_start+0x38/0x1a2 > [...] > Call Trace: > ext4_page_mkwrite+0x307/0x52b > _ext4_get_block+0xd8/0xd8 > do_page_mkwrite+0x6e/0xd8 > handle_mm_fault+0x686/0xf9b > mntput_no_expire+0x1f/0x21e > __do_page_fault+0x21d/0x465 > dput+0x4a/0x2f7 > page_fault+0x22/0x30 > copy_user_generic_string+0x2c/0x40 > copy_page_to_iter+0x8c/0x2b8 > generic_file_read_iter+0x26e/0x845 > timerqueue_del+0x31/0x90 > ceph_read_iter+0x697/0xa33 [ceph] > hrtimer_cancel+0x23/0x41 > futex_wait+0x1c8/0x24d > get_futex_key+0x32c/0x39a > __vfs_read+0xe0/0x130 > vfs_read.part.1+0x6c/0x123 > handle_mm_fault+0x831/0xf9b > __fget+0x7e/0xbf > SyS_read+0x4d/0xb5 > > The reason is that page fault can happen when one filesystem copies > data from/to userspace, the filesystem may set current->journal_info. > If the userspace memory is mapped to a file on another filesystem, > the later filesystem may also want to use current->journal_info. > > Signed-off-by: "Yan, Zheng" Reported-and-tested-by: Amon Ott Thanks a lot for the patch! I have ported your patch to 4.9.68, tested and the bug seems fixed now. Amon Ott -- Dr. Amon Ott m-privacy GmbH Tel: +49 30 24342334 Werner-Voß-Damm 62 Fax: +49 30 99296856 12101 Berlin http://www.m-privacy.de Amtsgericht Charlottenburg, HRB 84946 Geschäftsführer: Dipl.-Kfm. Holger Maczkowsky, Roman Maczkowsky GnuPG-Key-ID: 0x2DD3A649