From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tomi Valkeinen Subject: Re: [PATCHv3 00/30] drm/omap: miscallaneous improvements Date: Wed, 29 Mar 2017 17:19:12 +0300 Message-ID: <17a81c6b-2eec-9280-1d41-2eda4b039ef8@ti.com> References: <1490706496-4959-1-git-send-email-tomi.valkeinen@ti.com> <1570543.OfyNdZDSlj@avalon> Mime-Version: 1.0 Content-Type: multipart/mixed; boundary="===============1842783596==" Return-path: Received: from fllnx210.ext.ti.com (fllnx210.ext.ti.com [198.47.19.17]) by gabe.freedesktop.org (Postfix) with ESMTPS id E7C236E026 for ; Wed, 29 Mar 2017 14:19:18 +0000 (UTC) In-Reply-To: <1570543.OfyNdZDSlj@avalon> List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dri-devel-bounces@lists.freedesktop.org Sender: "dri-devel" To: Laurent Pinchart Cc: Jyri Sarha , dri-devel@lists.freedesktop.org List-Id: dri-devel@lists.freedesktop.org --===============1842783596== Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="BdtKoVjxtXFLIxsCbOPT7Tf4LxdQwD1dR" --BdtKoVjxtXFLIxsCbOPT7Tf4LxdQwD1dR Content-Type: multipart/mixed; boundary="IVIM8mNvbjSisgAORB05JW6UNRorc73QN"; protected-headers="v1" From: Tomi Valkeinen To: Laurent Pinchart Cc: dri-devel@lists.freedesktop.org, Jyri Sarha Message-ID: <17a81c6b-2eec-9280-1d41-2eda4b039ef8@ti.com> Subject: Re: [PATCHv3 00/30] drm/omap: miscallaneous improvements References: <1490706496-4959-1-git-send-email-tomi.valkeinen@ti.com> <1570543.OfyNdZDSlj@avalon> In-Reply-To: <1570543.OfyNdZDSlj@avalon> --IVIM8mNvbjSisgAORB05JW6UNRorc73QN Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable On 29/03/17 15:09, Laurent Pinchart wrote: > Hi Tomi, >=20 > On Tuesday 28 Mar 2017 16:07:46 Tomi Valkeinen wrote: >> This is the third revision of this series. Note that this series depen= ds on >> "drm/atomic: Introduce drm_atomic_helper_shutdown" which has not yet b= een >> merged to drm-next. >=20 > I've reviewed all patches but the omapdss-base split. While it doesn't = look=20 > bad to me, it's hard to judge whether the code is correctly architectur= ed=20 > without seeing the omapdss6 driver. Thanks. I think time will tell if it's correctly done, but I'm quite confident that it can't mess up much. It consists really of two parts: separating the common base stuff into a separate module, and the dispc_ops. While the common module could use some cleanup, I think it makes sense. The dispc_ops really just change from calling functions directly to use function pointers. You can find dss6 driver from https://git.ti.com/ti-linux-kernel/ti-linux-kernel/trees/ti-linux-4.9.y/d= rivers/gpu/drm/omapdrm/dss The dss6 and dispc6 files. But it's really just a smaller, cleaner (well, the driver is not clean yet) version of dss5. Conceptually the same, different registers. Tomi --IVIM8mNvbjSisgAORB05JW6UNRorc73QN-- --BdtKoVjxtXFLIxsCbOPT7Tf4LxdQwD1dR Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 iQIcBAEBCAAGBQJY28JgAAoJEPo9qoy8lh71AvkP/RzcnHx/9OYthQz0GM6u+DyP 6D1YXVUVS5q4V6eSBgG+lEv+7GqZGeT0HZP4qXnh1tiUDvHOg98SROkQnSoMF4b7 CKNGEM3OIGBZqjSIm6G1Iwh+rUvQr3mC5dJOw4Bw2rrMKXVj51YDTxKdi2+MtC6y 00VCgnYvy84Y4JDi481QyMYSkrR1P37JJed73KsbRhCIuWbtKPduQkSQrgotUijh 5rqsVbuVVRkbynwjP9eiut72z/ksL//A1+liheZmKGFco/VqblCkjSqegQB4O/qg MzYQdie5ZnzKHuuwn8LP3Jrwv1/3yJGoYdFXULm1ySAPinP6CleOnrYJxBNRVELS zG8BewyRlj+7c+rtD4MLJ+YACCQsRiny3U2eTJnpq/sQmeylON1QF1lPHHA9GqHp GAiiLArILJ7CfWdcgmm4dkhe6wOGeiRpsvi4T6uF/kHY4T+/Fx9N7sykpRp6yHve hvEG7191ASvTxuV39cRtxBfLwMKvqTkZ5sVqsnCcSetNJnM/dvhov4kkiU9d9oP2 cJADBlq1Td5Z8pKcN3qnUN3gJJbRB8VIZLHUr0iu8gAz9x5cL9xCth64rKLeTje6 DNNIkwRxp4CiQ+abnzHpZQoqA7obOl2KL1QwnkHo2/zItYi8Hcm6P8ITn2EV2v6A ZHmAli60R8DARkyqksiX =r9mR -----END PGP SIGNATURE----- --BdtKoVjxtXFLIxsCbOPT7Tf4LxdQwD1dR-- --===============1842783596== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KZHJpLWRldmVs IG1haWxpbmcgbGlzdApkcmktZGV2ZWxAbGlzdHMuZnJlZWRlc2t0b3Aub3JnCmh0dHBzOi8vbGlz dHMuZnJlZWRlc2t0b3Aub3JnL21haWxtYW4vbGlzdGluZm8vZHJpLWRldmVsCg== --===============1842783596==--