From: Ferruh Yigit <ferruh.yigit@intel.com>
To: Thomas Monjalon <thomas@monjalon.net>, Rami Rosen <ramirose@gmail.com>
Cc: dev@dpdk.org, naga.sureshx.somarowthu@intel.com,
reshma.pattan@intel.com, dpdk-stable <stable@dpdk.org>
Subject: Re: [PATCH] test: fix broken "make test"
Date: Tue, 12 Feb 2019 17:52:32 +0000 [thread overview]
Message-ID: <17cb2757-23fe-7a3b-f33d-44d94797b2cf@intel.com> (raw)
In-Reply-To: <10690305.j51yestHYH@xps>
On 2/12/2019 11:24 AM, Thomas Monjalon wrote:
> 12/02/2019 10:36, Ferruh Yigit:
>> On 2/11/2019 6:38 PM, Rami Rosen wrote:
>>> This patch fixes a broken build; when running
>>> make test
>>> we get the following error:
>>> ...
>>> Traceback (most recent call last):
>>> File "/work/src/dpdk-19.02/test/test/autotest.py", line 49, in <module>
>>> num_fails = runner.run_all_tests()
>>> File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 345, in
>>> run_all_tests
>>> self.parallel_tests)
>>> File "/work/src/dpdk-19.02/test/test/autotest_runner.py", line 264, in
>>> __filter_test
>>> test_cmd = test["Command"]
>>> KeyError: 'Command'
>>> ...
>>> The reason is that the pdump autotest entry uses "Comamnd"
>>> instead of "Command"; this patch fixes it.
>>>
>>> Bugzilla ID: 205
>>> Fixes: 086eb64db39e ("test/pdump: add unit test for pdump library")
>>> Signed-off-by: Rami Rosen <ramirose@gmail.com>
>>
>> Reviewed-by: Ferruh Yigit <ferruh.yigit@intel.com>
>>
>> Good catch! But it seems 19.02 released autotest broken, so this needs to be
>> backported to 19.02:
>>
>> Cc: stable@dpdk.org
>
> Applied, thanks
>
>
>> Thomas,
>> What do you think adding autotest into DPDK community lab testing? I will bring
>> the the suggestion in next meeting.
>
> Yes, sure.
> It has already been discussed but no task was created:
> https://bugs.dpdk.org/buglist.cgi?product=lab
> Let's follow-up in next meeting.
It has been discussed again, and following task created for lab:
https://bugs.dpdk.org/show_bug.cgi?id=212
prev parent reply other threads:[~2019-02-12 17:52 UTC|newest]
Thread overview: 5+ messages / expand[flat|nested] mbox.gz Atom feed top
2019-02-11 18:38 [PATCH] test: fix broken "make test" Rami Rosen
2019-02-12 9:36 ` Ferruh Yigit
2019-02-12 9:59 ` David Marchand
2019-02-12 11:24 ` Thomas Monjalon
2019-02-12 17:52 ` Ferruh Yigit [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17cb2757-23fe-7a3b-f33d-44d94797b2cf@intel.com \
--to=ferruh.yigit@intel.com \
--cc=dev@dpdk.org \
--cc=naga.sureshx.somarowthu@intel.com \
--cc=ramirose@gmail.com \
--cc=reshma.pattan@intel.com \
--cc=stable@dpdk.org \
--cc=thomas@monjalon.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.