From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5AC35C433DF for ; Tue, 13 Oct 2020 14:49:31 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id C3C322489A for ; Tue, 13 Oct 2020 14:49:30 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org C3C322489A Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=intel.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 646BD1DCC4; Tue, 13 Oct 2020 16:49:28 +0200 (CEST) Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by dpdk.org (Postfix) with ESMTP id B93AD1DC8F; Tue, 13 Oct 2020 16:49:25 +0200 (CEST) IronPort-SDR: AAV8B7GM+E9kktdsGvV4hMQwJMVYIn+vopsFm+dHTHkmqGnHC7fIsXBrHbIgFwXTI3DXU5WPqB 4nLhPvjToFtw== X-IronPort-AV: E=McAfee;i="6000,8403,9772"; a="165130986" X-IronPort-AV: E=Sophos;i="5.77,371,1596524400"; d="scan'208";a="165130986" X-Amp-Result: SKIPPED(no attachment in message) X-Amp-File-Uploaded: False Received: from orsmga005.jf.intel.com ([10.7.209.41]) by fmsmga103.fm.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 07:49:23 -0700 IronPort-SDR: DMIVUEjpvLg/6rzlDfQk914ulD+tEWBrTsy5tv14YzB3ejgi/FIEHz7EliPo4kjU1W+ZmmcyUw VMmWPjUveUOw== X-IronPort-AV: E=Sophos;i="5.77,371,1596524400"; d="scan'208";a="530418111" Received: from fyigit-mobl1.ger.corp.intel.com (HELO [10.213.214.64]) ([10.213.214.64]) by orsmga005-auth.jf.intel.com with ESMTP/TLS/ECDHE-RSA-AES256-GCM-SHA384; 13 Oct 2020 07:49:22 -0700 To: Gaetan Rivet , dev@dpdk.org Cc: longli@microsoft.com, stable@dpdk.org References: From: Ferruh Yigit Message-ID: <17ea8dd8-c747-8f4c-2337-c32ff7fe1ee0@intel.com> Date: Tue, 13 Oct 2020 15:49:18 +0100 MIME-Version: 1.0 In-Reply-To: Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Subject: Re: [dpdk-dev] [dpdk-stable] [PATCH] net/failsafe: fix state synchro cleanup X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 10/12/2020 3:19 PM, Gaetan Rivet wrote: > During a hotplug attempt, failsafe will try to bring a subdevice that > just appeared to its internal state. On error, the subdevice is marked > for removal and will be cleaned up. > > However failsafe_dev_remove() only remove active devices. Devices that > failed during probe will be stuck in DEV_PARSED state repeatedly. > > Consider all devices when doing a removal round, but limit burst control > and stats saving to active devices. > > Fixes: 598fb8aec6f6 ("net/failsafe: support device removal") > Cc: stable@dpdk.org > Signed-off-by: Gaetan Rivet Applied to dpdk-next-net/main, thanks.