From: Sagi Grimberg <sagi@grimberg.me>
To: "Engel, Amit" <Amit.Engel@Dell.com>, Christoph Hellwig <hch@lst.de>
Cc: "linux-nvme@lists.infradead.org" <linux-nvme@lists.infradead.org>
Subject: Re: [PATCH] nvmet: Set ctrl->kato to a default NVMET_DISC_KATO value
Date: Wed, 19 Aug 2020 08:24:00 -0700 [thread overview]
Message-ID: <17f4ef7f-1a1f-4e0c-5219-117bc752d959@grimberg.me> (raw)
In-Reply-To: <MN2PR19MB300552C9AAC6400847E51042EE5D0@MN2PR19MB3005.namprd19.prod.outlook.com>
> Actually the spec says that NVME/TCP requires keep alive so it shouldn’t be 0.
Nothing in this language requires it. The keyword should means advice.
> Maybe we do need to set a default value in case of zero kato value ?
No, the patch is fine.
> NVMe-oF 1.1:
> 7.4.8 Keep Alive
> The NVMe/TCP Transport requires the use of the Keep Alive feature (refer to section 7.12 in the NVMe base specification). The NVMe/TCP Transport does not impose any limitations on the minimum and maximum Keep Alive Timeout value. The minimum should be set large enough to account for any transient fabric interconnect failures between the host and controller.
> TCP level Keep Alive functionality is not prohibited but it is recommended that TCP level Keep Alive timeout is set to a higher value than the NVMe Keep Alive Timeout to avoid conflicting policies.
_______________________________________________
Linux-nvme mailing list
Linux-nvme@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-nvme
next prev parent reply other threads:[~2020-08-19 15:24 UTC|newest]
Thread overview: 12+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-08-18 6:51 [PATCH] nvmet: Set ctrl->kato to a default NVMET_DISC_KATO value amit.engel
2020-08-18 16:27 ` Christoph Hellwig
2020-08-18 20:54 ` Sagi Grimberg
2020-08-18 20:58 ` Sagi Grimberg
2020-08-19 7:15 ` Engel, Amit
2020-08-19 14:29 ` Engel, Amit
2020-08-19 15:24 ` Sagi Grimberg [this message]
2020-08-19 16:04 ` Engel, Amit
2020-09-13 15:18 ` Engel, Amit
2020-09-14 23:53 ` Sagi Grimberg
2020-09-15 6:43 ` Christoph Hellwig
2020-09-15 7:00 ` Engel, Amit
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17f4ef7f-1a1f-4e0c-5219-117bc752d959@grimberg.me \
--to=sagi@grimberg.me \
--cc=Amit.Engel@Dell.com \
--cc=hch@lst.de \
--cc=linux-nvme@lists.infradead.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.