All of lore.kernel.org
 help / color / mirror / Atom feed
From: Nguyen, Anthony L <anthony.l.nguyen@intel.com>
To: intel-wired-lan@osuosl.org
Subject: [Intel-wired-lan] [PATCH v1 1/1] e1000e: Add space to the debug print
Date: Mon, 14 Jun 2021 21:22:55 +0000	[thread overview]
Message-ID: <17f7910ef523253e4e42dbdc81e0e80cb14c5e1d.camel@intel.com> (raw)
In-Reply-To: <20210614072452.480186-1-sasha.neftin@intel.com>

On Mon, 2021-06-14 at 10:24 +0300, Sasha Neftin wrote:
> Complete to commit 3cf31b1a9eff ("e1000e: bump up timeout to
> wait when ME un-configures ULP mode")
> Minor fixes to allow debug prints more readable.
> 
> Fixes: 3cf31b1a9eff ("e1000e: bump up timeout to
> wait when ME un-configures ULP mode")

The Fixes should all be on one line.
	Fixes tag: Fixes: 3cf31b1a9eff ("e1000e: bump up timeout to
	Has these problem(s):
		- Subject has leading but no trailing parentheses
		- Subject has leading but no trailing quotes


> Signed-off-by: Sasha Neftin <sasha.neftin@intel.com>
> ---
>  drivers/net/ethernet/intel/e1000e/ich8lan.c | 4 ++--
>  1 file changed, 2 insertions(+), 2 deletions(-)
> 
> diff --git a/drivers/net/ethernet/intel/e1000e/ich8lan.c
> b/drivers/net/ethernet/intel/e1000e/ich8lan.c
> index 5b008c88beb7..a3cf0af7aedd 100644
> --- a/drivers/net/ethernet/intel/e1000e/ich8lan.c
> +++ b/drivers/net/ethernet/intel/e1000e/ich8lan.c
> @@ -1271,9 +1271,9 @@ static s32 e1000_disable_ulp_lpt_lp(struct
> e1000_hw *hw, bool force)
>  			usleep_range(10000, 11000);
>  		}
>  		if (firmware_bug)
> -			e_warn("ULP_CONFIG_DONE took %dmsec.  This is a
> firmware bug\n", i * 10);
> +			e_warn("ULP_CONFIG_DONE took %d msec.  This is
> a firmware bug\n", i * 10);
>  		else
> -			e_dbg("ULP_CONFIG_DONE cleared after %dmsec\n",
> i * 10);
> +			e_dbg("ULP_CONFIG_DONE cleared after %d
> msec\n", i * 10);

nit: Since there will be a new version, can you put the 'i * 10's on a
new line?
WARNING: line length of 81 exceeds 80 columns
WARNING: line length of 98 exceeds 80 columns


>  
>  		if (force) {
>  			mac_reg = er32(H2ME);

      reply	other threads:[~2021-06-14 21:22 UTC|newest]

Thread overview: 2+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2021-06-14  7:24 [Intel-wired-lan] [PATCH v1 1/1] e1000e: Add space to the debug print Sasha Neftin
2021-06-14 21:22 ` Nguyen, Anthony L [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=17f7910ef523253e4e42dbdc81e0e80cb14c5e1d.camel@intel.com \
    --to=anthony.l.nguyen@intel.com \
    --cc=intel-wired-lan@osuosl.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.