From: Juergen Gross <jgross@suse.com>
To: Olaf Hering <olaf@aepfle.de>, xen-devel@lists.xenproject.org
Cc: Ian Jackson <iwj@xenproject.org>, Wei Liu <wl@xen.org>
Subject: Re: [PATCH v1] tools: add newlines to xenstored WRL_LOG
Date: Mon, 10 May 2021 09:31:41 +0200 [thread overview]
Message-ID: <17f8a84f-13c3-2d55-13b0-79abc7f83855@suse.com> (raw)
In-Reply-To: <20210503154712.508-1-olaf@aepfle.de>
[-- Attachment #1.1.1: Type: text/plain, Size: 362 bytes --]
On 03.05.21 17:47, Olaf Hering wrote:
> According to syslog(3) the fmt string does not need a newline.
> The mini-os implementation of syslog requires the trailing newline.
> Other calls to syslog do include the newline already, add it also to WRL_LOG.
Mind doing the same for the two syslog() calls in xenstored_core.c
lacking the newline?
Juergen
[-- Attachment #1.1.2: OpenPGP_0xB0DE9DD628BF132F.asc --]
[-- Type: application/pgp-keys, Size: 3135 bytes --]
[-- Attachment #2: OpenPGP digital signature --]
[-- Type: application/pgp-signature, Size: 495 bytes --]
next prev parent reply other threads:[~2021-05-10 7:31 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-05-03 15:47 [PATCH v1] tools: add newlines to xenstored WRL_LOG Olaf Hering
2021-05-10 7:31 ` Juergen Gross [this message]
2021-05-10 8:34 ` Olaf Hering
2021-05-10 8:38 ` Juergen Gross
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=17f8a84f-13c3-2d55-13b0-79abc7f83855@suse.com \
--to=jgross@suse.com \
--cc=iwj@xenproject.org \
--cc=olaf@aepfle.de \
--cc=wl@xen.org \
--cc=xen-devel@lists.xenproject.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.