From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Burakov, Anatoly" Subject: Re: [PATCH v5 10/10] mk: remove unnecessary make rules of test Date: Wed, 18 Jul 2018 09:56:35 +0100 Message-ID: <17f96606-377c-4eaa-92e9-ab1b57465cd7@intel.com> References: <1531843225-14638-1-git-send-email-reshma.pattan@intel.com> <1531843225-14638-11-git-send-email-reshma.pattan@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Cc: jananeex.m.parthasarathy@intel.com, stable@dpdk.org, ferruh.yigit@intel.com To: Reshma Pattan , thomas@monjalon.net, dev@dpdk.org Return-path: In-Reply-To: <1531843225-14638-11-git-send-email-reshma.pattan@intel.com> Content-Language: en-US List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" On 17-Jul-18 5:00 PM, Reshma Pattan wrote: > make rule test-basic is duplicate of test rule. > removed unused test-mempool and test-ring make rules. > > Fixes: a3df7f8d9c ("mk: rename test related rules") > Fixes: a3df7f8d9c ("mk: rename test related rules") Fixline appears two times :) Thomas can fix it on apply though. > CC: stable@dpdk.org > CC: ferruh.yigit@intel.com > > Signed-off-by: Reshma Pattan > --- > mk/rte.sdkroot.mk | 4 ++-- > mk/rte.sdktest.mk | 7 +++---- > 2 files changed, 5 insertions(+), 6 deletions(-) > > diff --git a/mk/rte.sdkroot.mk b/mk/rte.sdkroot.mk > index ea3473ebf..18c88017e 100644 > --- a/mk/rte.sdkroot.mk > +++ b/mk/rte.sdkroot.mk > @@ -68,8 +68,8 @@ config defconfig showconfigs showversion showversionum: > cscope gtags tags etags: > $(Q)$(RTE_SDK)/devtools/build-tags.sh $@ $T > > -.PHONY: test test-basic test-fast test-ring test-mempool test-perf coverage test-drivers test-dump > -test test-basic test-fast test-ring test-mempool test-perf coverage test-drivers test-dump: > +.PHONY: test test-fast test-perf coverage test-drivers test-dump > +test test-fast test-perf coverage test-drivers test-dump: > $(Q)$(MAKE) -f $(RTE_SDK)/mk/rte.sdktest.mk $@ > > test: test-build > diff --git a/mk/rte.sdktest.mk b/mk/rte.sdktest.mk > index 13d1efb6a..295592809 100644 > --- a/mk/rte.sdktest.mk > +++ b/mk/rte.sdktest.mk > @@ -18,7 +18,7 @@ DIR := $(shell basename $(RTE_OUTPUT)) > # > # test: launch auto-tests, very simple for now. > # > -.PHONY: test test-basic test-fast test-perf test-drivers test-dump coverage > +.PHONY: test test-fast test-perf test-drivers test-dump coverage > > PERFLIST=ring_perf,mempool_perf,memcpy_perf,hash_perf,timer_perf,\ > reciprocal_division,reciprocal_division_perf,lpm_perf,red_all,\ > @@ -31,8 +31,7 @@ DRIVERSLIST=link_bonding,link_bonding_mode4,link_bonding_rssconf,\ > cryptodev_scheduler,cryptodev_aesni_gcm,cryptodev_null,\ > cryptodev_sw_snow3g,cryptodev_sw_kasumi,cryptodev_sw_zuc > DUMPLIST=dump_struct_sizes,dump_mempool,dump_malloc_stats,dump_devargs,\ > - dump_log_types,dump_ring,quit,dump_physmem,dump_memzone,\ > - devargs_autotest > + dump_log_types,dump_ring,dump_physmem,dump_memzone > > SPACESTR:= > SPACESTR+= > @@ -46,7 +45,7 @@ test-perf: WHITELIST=$(STRIPPED_PERFLIST) > test-drivers: WHITELIST=$(STRIPPED_DRIVERSLIST) > test-dump: WHITELIST=$(STRIPPED_DUMPLIST) > > -test test-basic test-fast test-perf test-drivers test-dump: > +test test-fast test-perf test-drivers test-dump: > @mkdir -p $(AUTOTEST_DIR) ; \ > cd $(AUTOTEST_DIR) ; \ > if [ -f $(RTE_OUTPUT)/app/test ]; then \ > Reviewed-by: Anatoly Burakov -- Thanks, Anatoly