From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-0.6 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 358E0C3A5A9 for ; Wed, 4 Sep 2019 07:46:52 +0000 (UTC) Received: from dpdk.org (dpdk.org [92.243.14.124]) by mail.kernel.org (Postfix) with ESMTP id 643E322CED for ; Wed, 4 Sep 2019 07:46:51 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (1024-bit key) header.d=monjalon.net header.i=@monjalon.net header.b="XnhBE3kQ"; dkim=fail reason="signature verification failed" (2048-bit key) header.d=messagingengine.com header.i=@messagingengine.com header.b="RGuiID4Y" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 643E322CED Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=monjalon.net Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=dev-bounces@dpdk.org Received: from [92.243.14.124] (localhost [127.0.0.1]) by dpdk.org (Postfix) with ESMTP id 6E9151EB9D; Wed, 4 Sep 2019 09:46:50 +0200 (CEST) Received: from out1-smtp.messagingengine.com (out1-smtp.messagingengine.com [66.111.4.25]) by dpdk.org (Postfix) with ESMTP id B11421EB90 for ; Wed, 4 Sep 2019 09:46:48 +0200 (CEST) Received: from compute1.internal (compute1.nyi.internal [10.202.2.41]) by mailout.nyi.internal (Postfix) with ESMTP id 42968220CB; Wed, 4 Sep 2019 03:46:46 -0400 (EDT) Received: from mailfrontend1 ([10.202.2.162]) by compute1.internal (MEProxy); Wed, 04 Sep 2019 03:46:46 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=monjalon.net; h= from:to:cc:subject:date:message-id:in-reply-to:references :mime-version:content-transfer-encoding:content-type; s=mesmtp; bh=+yy0jZBYNTlclD0e3ydyMTwTC5H8uySWL+pexC5Q3BQ=; b=XnhBE3kQNsWm /iSvvKIP4wi36vELHO6yyJpdofUQb8Si9pbSAJEfQTfvYVSktBo735kJaCZC8mph bAYCgGsUO5apMSZoE08fO/fqLwfn2X3a+3clroFnn17Rz0J9N0bqsBra/EeBJkfV UTLRvJSq6CsJmw4/AhjbdHPfyKAhk+g= DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d= messagingengine.com; h=cc:content-transfer-encoding:content-type :date:from:in-reply-to:message-id:mime-version:references :subject:to:x-me-proxy:x-me-proxy:x-me-sender:x-me-sender :x-sasl-enc; s=fm3; bh=+yy0jZBYNTlclD0e3ydyMTwTC5H8uySWL+pexC5Q3 BQ=; b=RGuiID4YLwF2DsHpSbfAZvt0y26qHN5BEkIEZsVL3WEIZ/xQaf1jNtGDo doy/Q+OBZLv5DtknhFEGpn7dYvrl7M0HSkyxufvqSmx1B9rkx/nqsEhkTkmEj4Rq WGu6X3zp9nsXzZojTmmFAWr9p2qn8xHV20OCWxe2sABiRwvgmO6lHg/ufTkoXxLI bK3iMl5BUxjXCNV5XkKtEVCO7HQcUKqG4XNx3EB3Tfpfpr18OAC20Z8iuo13/oWU hPjFP66Ww4EbUlDblPmnYd+9BYQcpe+jLvKtnSTVL625yUU8XqKhzkySbCV7BZG3 /4wIQ+GtxziNaasbsCzh9XMyFXKzQ== X-ME-Sender: X-ME-Proxy-Cause: gggruggvucftvghtrhhoucdtuddrgeduvddrudejgedguddulecutefuodetggdotefrod ftvfcurfhrohhfihhlvgemucfhrghsthforghilhdpqfgfvfdpuffrtefokffrpgfnqfgh necuuegrihhlohhuthemuceftddtnecusecvtfgvtghiphhivghnthhsucdlqddutddtmd enucfjughrpefhvffufffkjghfggfgtgesthfuredttddtvdenucfhrhhomhepvfhhohhm rghsucfoohhnjhgrlhhonhcuoehthhhomhgrshesmhhonhhjrghlohhnrdhnvghtqeenuc fkphepjeejrddufeegrddvtdefrddukeegnecurfgrrhgrmhepmhgrihhlfhhrohhmpeht hhhomhgrshesmhhonhhjrghlohhnrdhnvghtnecuvehluhhsthgvrhfuihiivgeptd X-ME-Proxy: Received: from xps.localnet (184.203.134.77.rev.sfr.net [77.134.203.184]) by mail.messagingengine.com (Postfix) with ESMTPA id 859F68005A; Wed, 4 Sep 2019 03:46:44 -0400 (EDT) From: Thomas Monjalon To: Anoob Joseph Cc: Radu Nicolau , "dev@dpdk.org" , "akhil.goyal@nxp.com" , "konstantin.ananyev@intel.com" , "bernard.iremonger@intel.com" , "declan.doherty@intel.com" , "stephen@networkplumber.org" , ferruh.yigit@intel.com Date: Wed, 04 Sep 2019 09:46:42 +0200 Message-ID: <18019128.8lTUtv1f9t@xps> In-Reply-To: References: <1567515451-7764-1-git-send-email-radu.nicolau@intel.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" Subject: Re: [dpdk-dev] [EXT] [PATCH] security: update doxygen fields X-BeenThere: dev@dpdk.org X-Mailman-Version: 2.1.15 Precedence: list List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 04/09/2019 05:41, Anoob Joseph: > Hi Radu, > > Most parts of the file(rte_security.h) follows 'description after item' methodology. Do you think we should stick to that? > > @Akhil, @Thomas, what is the recommended way of documenting individual members of structure? Is it 'description after the item' or 'description before the item'? In general, it is better to have the description before. The description "after" is preferred for short descriptions of struct items which fit on the same line with the item.