From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1758923AbbA2Xrw (ORCPT ); Thu, 29 Jan 2015 18:47:52 -0500 Received: from mout.kundenserver.de ([212.227.17.24]:53741 "EHLO mout.kundenserver.de" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1751732AbbA2Xrv (ORCPT ); Thu, 29 Jan 2015 18:47:51 -0500 From: Arnd Bergmann To: Murali Karicheri Cc: w-kwok2@ti.com, davem@davemloft.net, mugunthanvnm@ti.com, tony@atomide.com, prabhakar.csengg@gmail.com, grygorii.strashko@ti.com, lokeshvutla@ti.com, mpa@pengutronix.de, lsorense@csclub.uwaterloo.ca, netdev@vger.kernel.org, linux-kernel@vger.kernel.org Subject: Re: [PATCH net-next] drivers: net: cpsw: make cpsw_ale.c a module to allow re-use on Keystone Date: Fri, 30 Jan 2015 00:47:33 +0100 Message-ID: <1802322.NDR3d5ZRSA@wuerfel> User-Agent: KMail/4.11.5 (Linux/3.16.0-10-generic; KDE/4.11.5; x86_64; ; ) In-Reply-To: <1422573351-5603-2-git-send-email-m-karicheri2@ti.com> References: <1422573351-5603-1-git-send-email-m-karicheri2@ti.com> <1422573351-5603-2-git-send-email-m-karicheri2@ti.com> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-Provags-ID: V03:K0:y+nJCL7krOSj9D+WJ7dcoNx1TmSS7hTY9cpsjQUhQOatcLn1lew Pg3uN3t7txdxdSY+tqM5606wDReXMNQikMkDSWmLGQIZ5ZkRxJQwyPvr3/Ia/ByeRT7UzUw h6adgSjGM9ctjeh/khsn3mPAyAyQo7fhuo5eIdR20sqzdu0pR3fiYtjW/HQ8SRU53lp6QMt rE03Ybyr3/l+E8cqmhUVg== X-UI-Out-Filterresults: notjunk:1; Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On Thursday 29 January 2015 18:15:51 Murali Karicheri wrote: > NetCP on Keystone has cpsw ale function similar to other TI SoCs > and this driver is re-used. To allow both ti cpsw and keystone netcp > to re-use the driver, convert the cpsw ale to a module and configure > it through Kconfig option CONFIG_TI_CPSW_ALE. Currently it is statically > linked to both TI CPSW and NetCP and this causes issues when the above > drivers are built as dynamic modules. This patch addresses this issue > > While at it, fix the Makefile and code to build both netcp_core and > netcp_ethss as dynamic modules. This is needed to support arm allmodconfig. > This also requires exporting of API calls provided by netcp_core so that > both the above can be dynamic modules. > > Signed-off-by: Murali Karicheri > --- > drivers/net/ethernet/ti/Kconfig | 19 +++++++++++++++++-- > drivers/net/ethernet/ti/Makefile | 8 +++++--- > drivers/net/ethernet/ti/cpsw_ale.c | 26 ++++++++++++++++++++++++-- > drivers/net/ethernet/ti/netcp_core.c | 8 ++++++++ > drivers/net/ethernet/ti/netcp_ethss.c | 5 +++++ > 5 files changed, 59 insertions(+), 7 deletions(-) I was hoping there would be a way without exporting all those symbols, but I also couldn't come up with a better solution. I'm putting this into the randconfig build test for now, but I'm guessing it's fine. Unless you hear something else from me tomorrow after the tests are through: Acked-by: Arnd Bergmann