All of lore.kernel.org
 help / color / mirror / Atom feed
From: Thomas Monjalon <thomas@monjalon.net>
To: adham@mellanox.com
Cc: dev@dpdk.org, Bruce Richardson <bruce.richardson@intel.com>
Subject: Re: [dpdk-dev] [PATCH] doc: fix helloworld build on Windows
Date: Wed, 29 May 2019 12:55:58 +0200	[thread overview]
Message-ID: <1804166.xB7ryfxGPb@xps> (raw)
In-Reply-To: <20190520090423.GA1343@bricha3-MOBL.ger.corp.intel.com>

20/05/2019 11:04, Bruce Richardson:
> On Mon, May 20, 2019 at 11:19:52AM +0300, adham@mellanox.com wrote:
> > From: Adham Masarwah <adham@mellanox.com>
> > 
> > The option -Dexamples=helloworld is missing.
> > The helloworld binary name was wrong.
> > Forcing clang may be required in some environments.
> > 
> > Fixes: 196c650b8b63 ("doc: add guide for Windows")
> > 
> > Signed-off-by: Adham Masarwah <adham@mellanox.com>
> > ---
> Acked-by: Bruce Richardson <bruce.richardson@intel.com>

Applied, thanks




      reply	other threads:[~2019-05-29 10:56 UTC|newest]

Thread overview: 3+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2019-05-20  8:19 adham
2019-05-20  9:04 ` Bruce Richardson
2019-05-29 10:55   ` Thomas Monjalon [this message]

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=1804166.xB7ryfxGPb@xps \
    --to=thomas@monjalon.net \
    --cc=adham@mellanox.com \
    --cc=bruce.richardson@intel.com \
    --cc=dev@dpdk.org \
    --subject='Re: [dpdk-dev] [PATCH] doc: fix helloworld build on Windows' \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link

This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.