From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 5B0AEC4338F for ; Tue, 10 Aug 2021 20:07:04 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 3EF2360F25 for ; Tue, 10 Aug 2021 20:07:04 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232888AbhHJUHZ (ORCPT ); Tue, 10 Aug 2021 16:07:25 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:27862 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232836AbhHJUHV (ORCPT ); Tue, 10 Aug 2021 16:07:21 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628626019; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=Mb5VBTkb8S88umgyEx90HwHXvZnu9/1GybLMu7zbg4A=; b=MudRFDEUCauBggYS05NPau25zgxR3EAksGcx3k3rbt8Vojc8TMriuBYJ9NWP9JGyPYfATM ZWPWSAQN7xNzg92F8v2wVAJMWTs1rACzKh/Mk6LPixvGQIpURNMiUL1yBgY2hDQoKtsoxD U/1LYs5gZK/sXlPv86CNLNhebItvBP0= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-456-kHx-yYzKO2meQHTDf3jW6w-1; Tue, 10 Aug 2021 16:06:55 -0400 X-MC-Unique: kHx-yYzKO2meQHTDf3jW6w-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id 6D0B53639F; Tue, 10 Aug 2021 20:06:54 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id EEFE5100EBB0; Tue, 10 Aug 2021 20:06:52 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-36-willy@infradead.org> References: <20210715033704.692967-36-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Michal Hocko , Johannes Weiner , Christoph Hellwig Subject: Re: [PATCH v14 035/138] mm/memcg: Use the node id in mem_cgroup_update_tree() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1809567.1628626012.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 21:06:52 +0100 Message-ID: <1809568.1628626012@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > By using the node id in mem_cgroup_update_tree(), we can delete > soft_limit_tree_from_page() and mem_cgroup_page_nodeinfo(). Saves 42 > bytes of kernel text on my config. > > Signed-off-by: Matthew Wilcox (Oracle) > Acked-by: Michal Hocko > Acked-by: Johannes Weiner > Reviewed-by: Christoph Hellwig Reviewed-by: David Howells Though I wonder if: > - mz = mem_cgroup_page_nodeinfo(memcg, page); > + mz = memcg->nodeinfo[nid]; should still have some sort of wrapper function.