From mboxrd@z Thu Jan 1 00:00:00 1970 From: Tvrtko Ursulin Subject: Re: [PATCH 2/2] drm/i915: Flush the RING stop bit after clearing RING_HEAD in reset Date: Fri, 18 May 2018 11:02:04 +0100 Message-ID: <180a51c4-d94f-d989-4c30-4f1e99d581b1@linux.intel.com> References: <20180517142442.16979-1-chris@chris-wilson.co.uk> <20180517142442.16979-2-chris@chris-wilson.co.uk> <74bbb686-71d7-39cf-7ccc-d1ef15ec59f2@linux.intel.com> <152663684782.4210.173099292201688911@mail.alporthouse.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8"; Format="flowed" Content-Transfer-Encoding: base64 Return-path: Received: from mga14.intel.com (mga14.intel.com [192.55.52.115]) by gabe.freedesktop.org (Postfix) with ESMTPS id 6394A6ECD8 for ; Fri, 18 May 2018 10:02:08 +0000 (UTC) In-Reply-To: <152663684782.4210.173099292201688911@mail.alporthouse.com> Content-Language: en-GB List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: intel-gfx-bounces@lists.freedesktop.org Sender: "Intel-gfx" To: Chris Wilson , intel-gfx@lists.freedesktop.org List-Id: intel-gfx@lists.freedesktop.org Ck9uIDE4LzA1LzIwMTggMTA6NDcsIENocmlzIFdpbHNvbiB3cm90ZToKPiBRdW90aW5nIFR2cnRr byBVcnN1bGluICgyMDE4LTA1LTE4IDEwOjMzOjQ0KQo+Pgo+PiBPbiAxNy8wNS8yMDE4IDE1OjI0 LCBDaHJpcyBXaWxzb24gd3JvdGU6Cj4+PiBJbnNpZGUgdGhlIGxpdmVfaGFuZ2NoZWNrIChyZXNl dCkgc2VsZnRlc3RzLCB3ZSBvY2Nhc2lvbmFsbHkgc2VlCj4+PiBmYWlsdXJlcyBsaWtlCj4+Pgo+ Pj4gPDc+WyAgMjM5LjA5NDg0MF0gaTkxNV9nZW1fc2V0X3dlZGdlZCByY3MwCj4+PiA8Nz5bICAy MzkuMDk0ODQzXSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgY3VycmVudCBzZXFubyAxOWE5 OCwgbGFzdCAxOWE5YSwgaGFuZ2NoZWNrIDAgWzUxNTggbXNdCj4+PiA8Nz5bICAyMzkuMDk0ODQ2 XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgUmVzZXQgY291bnQ6IDYyMzkgKGdsb2JhbCAx KQo+Pj4gPDc+WyAgMjM5LjA5NDg0OF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIFJlcXVl c3RzOgo+Pj4gPDc+WyAgMjM5LjA5NTA1Ml0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgICAg ICAgICAgZmlyc3QgIDE5YTk5IFtlOGM6NWZdIHByaW89MTAyNCBAIDUxNTltczogKG51bGwpCj4+ PiA8Nz5bICAyMzkuMDk1MDU2XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgICAgICAgICBs YXN0ICAgMTlhOWEgW2U4MToxYV0gcHJpbz0xMzkgQCA1MTU5bXM6IGlndC9yY3MwWzU5NzddLzEK Pj4+IDw3PlsgIDIzOS4wOTUwNTldIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICAgICAgICAg IGFjdGl2ZSAxOWE5OSBbZThjOjVmXSBwcmlvPTEwMjQgQCA1MTU5bXM6IChudWxsKQo+Pj4gPDc+ WyAgMjM5LjA5NTA2Ml0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgICAgICAgICAgW2hlYWQg MDIyMCwgcG9zdGZpeCAwMjgwLCB0YWlsIDAyYTgsIGJhdGNoIDB4ZmZmZmZmZmZfZmZmZmZmZmZd Cj4+PiA8Nz5bICAyMzkuMTAwMDUwXSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgICAgICAg ICByaW5nLT5zdGFydDogIDB4MDAyODMwMDAKPj4+IDw3PlsgIDIzOS4xMDAwNTNdIGk5MTVfZ2Vt X3NldF93ZWRnZWQgICAgICAgICAgICAgICAgIHJpbmctPmhlYWQ6ICAgMHgwMDAwMDFmOAo+Pj4g PDc+WyAgMjM5LjEwMDA1NV0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgICAgICAgICAgcmlu Zy0+dGFpbDogICAweDAwMDAwMmE4Cj4+PiA8Nz5bICAyMzkuMTAwMDU3XSBpOTE1X2dlbV9zZXRf d2VkZ2VkICAgICAgICAgICAgICAgICByaW5nLT5lbWl0OiAgIDB4MDAwMDAyYTgKPj4+IDw3Plsg IDIzOS4xMDAwNTldIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICAgICAgICAgIHJpbmctPnNw YWNlOiAgMHgwMDAwMGYxMAo+Pj4gPDc+WyAgMjM5LjEwMDA4NV0gaTkxNV9nZW1fc2V0X3dlZGdl ZCAgICAgICAgIFJJTkdfU1RBUlQ6IDB4MDAyODMwMDAKPj4+IDw3PlsgIDIzOS4xMDAwODhdIGk5 MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICBSSU5HX0hFQUQ6ICAweDAwMDAwMjYwCj4+PiA8Nz5b ICAyMzkuMTAwMDkxXSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgUklOR19UQUlMOiAgMHgw MDAwMDJhOAo+Pj4gPDc+WyAgMjM5LjEwMDA5NF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAg IFJJTkdfQ1RMOiAgIDB4MDAwMDAwMDEKPj4+IDw3PlsgIDIzOS4xMDAwOTddIGk5MTVfZ2VtX3Nl dF93ZWRnZWQgICAgICAgICBSSU5HX01PREU6ICAweDAwMDAwMzAwIFtpZGxlXQo+Pj4gPDc+WyAg MjM5LjEwMDEwMF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIFJJTkdfSU1SOiBmZmZmZmVm ZQo+Pj4gPDc+WyAgMjM5LjEwMDEwNF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIEFDVEhE OiAgMHgwMDAwMDAwMF8wMDAwNjA5Ywo+Pj4gPDc+WyAgMjM5LjEwMDEwOF0gaTkxNV9nZW1fc2V0 X3dlZGdlZCAgICAgICAgIEJCQUREUjogMHgwMDAwMDAwMF8wMDAwNjA5ZAo+Pj4gPDc+WyAgMjM5 LjEwMDExMV0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIERNQV9GQUREUjogMHgwMDAwMDAw MF8wMDI4MzI2MAo+Pj4gPDc+WyAgMjM5LjEwMDExNF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAg ICAgIElQRUlSOiAweDAwMDAwMDAwCj4+PiA8Nz5bICAyMzkuMTAwMTE3XSBpOTE1X2dlbV9zZXRf d2VkZ2VkICAgICAgICAgSVBFSFI6IDB4MDI4MDAwMDAKPj4+IDw3PlsgIDIzOS4xMDAxMjBdIGk5 MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICBFeGVjbGlzdCBzdGF0dXM6IDB4MDAwNDQwNTIgMDAw MDAwMDIKPj4+IDw3PlsgIDIzOS4xMDAxMjRdIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICBF eGVjbGlzdCBDU0IgcmVhZCA1IFs1IGNhY2hlZF0sIHdyaXRlIDUgWzUgZnJvbSBod3NdLCBpbnRl cnJ1cHQgcG9zdGVkPyBubywgdGFza2xldCBxdWV1ZWQ/IG5vIChlbmFibGVkKQo+Pj4gPDc+WyAg MjM5LjEwMDEyOF0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgICAgICAgICAgRUxTUFswXSBj b3VudD0xLCByaW5nLT5zdGFydD0wMDI4MzAwMCwgcnE6IDE5YTk5IFtlOGM6NWZdIHByaW89MTAy NCBAIDUxNjRtczogKG51bGwpCj4+PiA8Nz5bICAyMzkuMTAwMTMyXSBpOTE1X2dlbV9zZXRfd2Vk Z2VkICAgICAgICAgICAgICAgICBFTFNQWzFdIGNvdW50PTEsIHJpbmctPnN0YXJ0PTAwMjU3MDAw LCBycTogMTlhOWEgW2U4MToxYV0gcHJpbz0xMzkgQCA1MTY0bXM6IGlndC9yY3MwWzU5NzddLzEK Pj4+IDw3PlsgIDIzOS4xMDAxMzVdIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICAgICAgICAg IEhXIGFjdGl2ZT8gMHg1Cj4+PiA8Nz5bICAyMzkuMTAwMjUwXSBpOTE1X2dlbV9zZXRfd2VkZ2Vk ICAgICAgICAgICAgICAgICBFIDE5YTk5IFtlOGM6NWZdIHByaW89MTAyNCBAIDUxNjRtczogKG51 bGwpCj4+PiA8Nz5bICAyMzkuMTAwMzM4XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgICAg ICAgICBFIDE5YTlhIFtlODE6MWFdIHByaW89MTM5IEAgNTE2NG1zOiBpZ3QvcmNzMFs1OTc3XS8x Cj4+PiA8Nz5bICAyMzkuMTAwMzQwXSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgICAgICAg ICBRdWV1ZSBwcmlvcml0eTogMTM5Cj4+PiA8Nz5bICAyMzkuMTAwMzQzXSBpOTE1X2dlbV9zZXRf d2VkZ2VkICAgICAgICAgICAgICAgICBRIDAgW2U5ODoxOV0gcHJpbz0xMzIgQCA1MTY0bXM6IGln dC9yY3MwWzU5NzddLzgKPj4+IDw3PlsgIDIzOS4xMDAzNDZdIGk5MTVfZ2VtX3NldF93ZWRnZWQg ICAgICAgICAgICAgICAgIFEgMCBbZTg0OjE5XSBwcmlvPTEyMSBAIDUxNjVtczogaWd0L3JjczBb NTk3N10vMgo+Pj4gPDc+WyAgMjM5LjEwMDM0OV0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAg ICAgICAgICAgUSAwIFtlODc6MTldIHByaW89ODIgQCA1MTY1bXM6IGlndC9yY3MwWzU5NzddLzMK Pj4+IDw3PlsgIDIzOS4xMDAzNTJdIGk5MTVfZ2VtX3NldF93ZWRnZWQgICAgICAgICAgICAgICAg IFEgMCBbZTg0OjFhXSBwcmlvPTQ0IEAgNTE2NG1zOiBpZ3QvcmNzMFs1OTc3XS8yCj4+PiA8Nz5b ICAyMzkuMTAwMzU2XSBpOTE1X2dlbV9zZXRfd2VkZ2VkICAgICAgICAgICAgICAgICBRIDAgW2U4 YjoxOV0gcHJpbz0yMCBAIDUxNjVtczogaWd0L3JjczBbNTk3N10vNAo+Pj4gPDc+WyAgMjM5LjEw MDM2Ml0gaTkxNV9nZW1fc2V0X3dlZGdlZCAgICAgICAgIGRydl9zZWxmdGVzdCBbNTg5NF0gd2Fp dGluZyBmb3IgMTlhOTkKPj4+Cj4+PiB3aGVyZSB0aGUgR1BVIHNhdyBhbiBhcmJpdHJhdGlvbiBw b2ludCBhbmQgaWRsZXM7IEFORCBIQVMgTk9UIEJFRU4gUkVTRVQhCj4+PiBUaGUgUklOR19NT0RF IGluZGljYXRlcyB0aGF0IGlzIGlkbGUgYW5kIGhhcyB0aGUgU1RPUF9SSU5HIGJpdCBzZXQsIHNv Cj4+PiB0cnkgY2xlYXJpbmcgaXQuCj4+Pgo+Pj4gU2lnbmVkLW9mZi1ieTogQ2hyaXMgV2lsc29u IDxjaHJpc0BjaHJpcy13aWxzb24uY28udWs+Cj4+PiAtLS0KPj4+ICAgIGRyaXZlcnMvZ3B1L2Ry bS9pOTE1L2ludGVsX3VuY29yZS5jIHwgMiArKwo+Pj4gICAgMSBmaWxlIGNoYW5nZWQsIDIgaW5z ZXJ0aW9ucygrKQo+Pj4KPj4+IGRpZmYgLS1naXQgYS9kcml2ZXJzL2dwdS9kcm0vaTkxNS9pbnRl bF91bmNvcmUuYyBiL2RyaXZlcnMvZ3B1L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4+PiBpbmRl eCBiMzZhM2I1NzM2YTAuLjA4MmIwMDQ1YWM4YyAxMDA2NDQKPj4+IC0tLSBhL2RyaXZlcnMvZ3B1 L2RybS9pOTE1L2ludGVsX3VuY29yZS5jCj4+PiArKysgYi9kcml2ZXJzL2dwdS9kcm0vaTkxNS9p bnRlbF91bmNvcmUuYwo+Pj4gQEAgLTE3MjAsNiArMTcyMCw4IEBAIHN0YXRpYyB2b2lkIGdlbjNf c3RvcF9lbmdpbmUoc3RydWN0IGludGVsX2VuZ2luZV9jcyAqZW5naW5lKQo+Pj4gICAgICAgIGlm IChJOTE1X1JFQURfRlcoUklOR19IRUFEKGJhc2UpKSAhPSAwKQo+Pj4gICAgICAgICAgICAgICAg RFJNX0RFQlVHX0RSSVZFUigiJXM6IHJpbmcgaGVhZCBub3QgcGFya2VkXG4iLAo+Pj4gICAgICAg ICAgICAgICAgICAgICAgICAgICAgICAgICBlbmdpbmUtPm5hbWUpOwo+Pj4gKwo+Pj4gKyAgICAg STkxNV9XUklURV9GVyhSSU5HX01JX01PREUoYmFzZSksIF9NQVNLRURfQklUX0RJU0FCTEUoU1RP UF9SSU5HKSk7Cj4+PiAgICB9Cj4+PiAgICAKPj4+ICAgIHN0YXRpYyB2b2lkIGk5MTVfc3RvcF9l bmdpbmVzKHN0cnVjdCBkcm1faTkxNV9wcml2YXRlICpkZXZfcHJpdiwKPj4+Cj4+Cj4+IFJpZ2h0 LCBzbyBleHBlY3RhdGlvbiBpcyBhZnRlciByZXNldCBTVE9QX1JJTkcgd2lsbCBub3QgYmUgc2V0 LCBidXQgaXQKPj4gc29tZXRpbWVzIGlzPwo+IAo+IFllcy4KCkFsc28gdGhlcmUgaXMgYSBjb21t ZW50IGluIHRoZXJlIHdoaWNoIHNheXMgZW5naW5lIG11c3QgYmUgc3RvcHBlZCAKYmVmb3JlIHJl c2V0IG9uIHNvbWUgcGxhdGZvcm1zLiBTbyBzaG91bGRuJ3QgdGhlIG1hbnVhbCBhdHRlbXB0IHRv IAp1bnN0dWNrIGl0IGdvIGFmdGVyIHRoZSByZXNldCBhbmQgbm90IGluIGdlbjNfc3RvcF9lbmdp bmU/CgpMaWtlIHRoZSBzdWdnZXN0ZWQgaTkxNV9jaGVja19lbmdpbmVfcnVubmluZzoKCmlmIChz dG9wcGVkKSB7CglEUk1fTk9USUNFKE1hbnVhbGx5IHN0YXJ0aW5nIGVuZ2luZSBhZnRlciByZXNl dCk7CgljbGVhcl9zdG9wX3Jpbmc7Cn0KCj8KCgo+PiBTaG91bGQgd2UgYWxzbyBhZGQgYSBub3Rp Y2Ugb3IgaW5mbyBpZiBpdCBpcyBzZXQgaW4gaW50ZWxfZ3B1X3Jlc2V0LAo+PiBhZnRlciB0aGUg cmVzZXQgaXMgY2FsbGVkPyBDb3VsZCBhZGQgaTkxNV9jaGVja19lbmdpbmVfcnVubmluZyguLikK Pj4gaGVscGVyIG9yIHNvbWV0aGluZy4KPiAKPiBDb3VsZCBkbywgd2lsbCBiZSBhbnkgbW9yZSB1 c2VmdWwgdGhhbiB0aGUgZHVtcCB3ZSBnaXZlIGFib3ZlPyA7KQo+IE1pZ2h0IGJlIGludGVyZXN0 aW5nIHRvIGRvIHRoZSBkdW1wIG9uIHVudXN1YWwgc3RhdGUgb24gdGFrZW92ZXIganVzdAo+IGZv ciByZWZlcmVuY2UgaW4gbGF0ZXIgZmFpbHMuCj4gLUNocmlzCj4gCl9fX19fX19fX19fX19fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCkludGVsLWdmeCBtYWlsaW5nIGxpc3QKSW50 ZWwtZ2Z4QGxpc3RzLmZyZWVkZXNrdG9wLm9yZwpodHRwczovL2xpc3RzLmZyZWVkZXNrdG9wLm9y Zy9tYWlsbWFuL2xpc3RpbmZvL2ludGVsLWdmeAo=