From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-18.8 required=3.0 tests=BAYES_00,DKIM_INVALID, DKIM_SIGNED,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED, USER_AGENT_SANE_1 autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id C788FC4338F for ; Mon, 16 Aug 2021 18:17:56 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 4433C604D7 for ; Mon, 16 Aug 2021 18:17:56 +0000 (UTC) DMARC-Filter: OpenDMARC Filter v1.4.1 mail.kernel.org 4433C604D7 Authentication-Results: mail.kernel.org; dmarc=fail (p=none dis=none) header.from=redhat.com Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=nongnu.org Received: from localhost ([::1]:46096 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1mFhBK-0001VT-Vl for qemu-devel@archiver.kernel.org; Mon, 16 Aug 2021 14:17:54 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:34698) by lists.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFh9s-0000d7-Ty for qemu-devel@nongnu.org; Mon, 16 Aug 2021 14:16:24 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:25922) by eggs.gnu.org with esmtps (TLS1.2:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.90_1) (envelope-from ) id 1mFh9m-0005Bs-CW for qemu-devel@nongnu.org; Mon, 16 Aug 2021 14:16:22 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1629137775; h=from:from:reply-to:reply-to:subject:subject:date:date: message-id:message-id:to:to:cc:cc:mime-version:mime-version: content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=O47pu5mh1B3W/peaUXLmf7ZqpjIt+GjL8j54t66fvNI=; b=EBVYvsuJzOFL03ApAf0yL2jmOiK1DfuF8W/gpTQj+g96UlvQNQXVjWihPUuuIrMnc5gqL0 oIUBA8BeSDxYDmNY8UGxhRE/zo2gAMEB1cn7Z+175+38YHgGkzyjdBqvcO2NDnRo3EQOwc k6qthmt8Z7phtWAJFi527Fc13Vgbciw= Received: from mail-pj1-f72.google.com (mail-pj1-f72.google.com [209.85.216.72]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-353-Wv5t5BoEMiiJuN_GFMQSaw-1; Mon, 16 Aug 2021 14:16:12 -0400 X-MC-Unique: Wv5t5BoEMiiJuN_GFMQSaw-1 Received: by mail-pj1-f72.google.com with SMTP id v18-20020a17090abb92b0290178fa401bdcso13102667pjr.4 for ; Mon, 16 Aug 2021 11:16:12 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:reply-to:subject:to:cc:references:from :message-id:date:user-agent:mime-version:in-reply-to :content-transfer-encoding:content-language; bh=O47pu5mh1B3W/peaUXLmf7ZqpjIt+GjL8j54t66fvNI=; b=Rd4FcwMmjJTnoV5zPYMKIyU9sSlr4/Ew1m4h5fHyCea4jW6E5Yycpb7GWbdih3Ghe9 WTjtkiuNRmzY6HdvbDnKO0kks2KNzw645Ompmazc1/Sx1O6SBZQA7IU76A37ABq6TNga PAAOow016ZAx/NSRb6dyyugvvRfATp2oHE1hJeHLM7Kc6dvfF2JMB8ml8bGVxlbHm5OW b7zb+XAQISNUKLtLjwibosnvbaXWY5FP4lmoXeP1EJi2KKQidwtbv1TKNtHU05a3Knll vcUkEtZR5d+6JihVWFoUKzl7+wzBfu0qpl1kukMiyEgS8miAmGEN6AZ6b4ZjCWRCDzUw IQAQ== X-Gm-Message-State: AOAM532C72OWrD/98sO4v03dkh+ojQ2RfQfZwLPwfvm4ywAFLCKkjl+H OZQiq5KQ7egdXceUGcEEdyaK8TaJu6b7p1hdPQL/I82Dzr9XyU9EDfaMM43N7Qwq7kCEUAWtahm WoNBoVAezvbFVhi8= X-Received: by 2002:a62:878c:0:b029:3c5:f729:ef00 with SMTP id i134-20020a62878c0000b02903c5f729ef00mr17672667pfe.43.1629137771577; Mon, 16 Aug 2021 11:16:11 -0700 (PDT) X-Google-Smtp-Source: ABdhPJz9wLZaYtNCo94UnJH3ioCN3Zs6t4vlzTPd3myeewRTSonsbsCuOB7XC8RSxN9DddXE3aQ6IA== X-Received: by 2002:a62:878c:0:b029:3c5:f729:ef00 with SMTP id i134-20020a62878c0000b02903c5f729ef00mr17672656pfe.43.1629137771352; Mon, 16 Aug 2021 11:16:11 -0700 (PDT) Received: from wainer-laptop.localdomain ([179.154.241.196]) by smtp.gmail.com with ESMTPSA id s5sm146319pji.56.2021.08.16.11.16.07 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 16 Aug 2021 11:16:10 -0700 (PDT) Subject: Re: [PATCH 1/2] Acceptance Tests: add standard clean up at test tearDown() To: Cleber Rosa , qemu-devel@nongnu.org, Peter Maydell References: <20210803193447.3946219-1-crosa@redhat.com> <20210803193447.3946219-2-crosa@redhat.com> From: Wainer dos Santos Moschetta Message-ID: <180dc18d-0a8f-7a6a-ca57-940f8d7505ab@redhat.com> Date: Mon, 16 Aug 2021 15:16:05 -0300 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.11.0 MIME-Version: 1.0 In-Reply-To: <20210803193447.3946219-2-crosa@redhat.com> Authentication-Results: relay.mimecast.com; auth=pass smtp.auth=CUSA124A263 smtp.mailfrom=wainersm@redhat.com X-Mimecast-Spam-Score: 0 X-Mimecast-Originator: redhat.com Content-Type: text/plain; charset=utf-8; format=flowed Content-Transfer-Encoding: 7bit Content-Language: en-US Received-SPF: pass client-ip=216.205.24.124; envelope-from=wainersm@redhat.com; helo=us-smtp-delivery-124.mimecast.com X-Spam_score_int: -71 X-Spam_score: -7.2 X-Spam_bar: ------- X-Spam_report: (-7.2 / 5.0 requ) BAYES_00=-1.9, DKIMWL_WL_HIGH=-0.698, DKIM_SIGNED=0.1, DKIM_VALID=-0.1, DKIM_VALID_AU=-0.1, DKIM_VALID_EF=-0.1, NICE_REPLY_A=-3.71, RCVD_IN_DNSWL_LOW=-0.7, RCVD_IN_MSPIKE_H2=-0.001, SPF_HELO_NONE=0.001, SPF_PASS=-0.001 autolearn=ham autolearn_force=no X-Spam_action: no action X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Reply-To: wainersm@redhat.com Cc: Thomas Huth , Beraldo Leal , =?UTF-8?Q?Philippe_Mathieu-Daud=c3=a9?= , Auger Eric , Willian Rampazzo , =?UTF-8?Q?Alex_Benn=c3=a9e?= , Eduardo Habkost Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" Hi, On 8/3/21 4:34 PM, Cleber Rosa wrote: > The avocado.Test class, used as the basis of the avocado_qemu.Test > class, performs a clean of temporary directories up as part of its own > tearDown() implementation. > > But the avocado_qemu.Test class is currently missing the same clean > up, as it implemented its own tearDown() method without resorting to > the upper class behavior. Good catch Peter! > > This brings avocado_qemu.Test behavior in sync with the standard > avocado.Test behavior and prevents temporary directories from > cluttering the test results directory (unless instructed to do so with > Avocado's "--keep-tmp" option). > > Reported-by: Peter Maydell > Signed-off-by: Cleber Rosa > --- > tests/acceptance/avocado_qemu/__init__.py | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/tests/acceptance/avocado_qemu/__init__.py b/tests/acceptance/avocado_qemu/__init__.py > index 2c4fef3e14..1e807e2e55 100644 > --- a/tests/acceptance/avocado_qemu/__init__.py > +++ b/tests/acceptance/avocado_qemu/__init__.py > @@ -276,6 +276,7 @@ def tearDown(self): > for vm in self._vms.values(): > vm.shutdown() > self._sd = None > + super(Test, self).tearDown() Could you use the new form of super [1] to make the pylint happier? [1] https://www.python.org/dev/peps/pep-3135/ Thanks! - Wainer > > def fetch_asset(self, name, > asset_hash=None, algorithm=None,