All of lore.kernel.org
 help / color / mirror / Atom feed
From: Li Chen <lchen.firstlove@zohomail.com>
To: "Mark Brown" <broonie@kernel.org>,
	"linux-kernel" <linux-kernel@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"linux-gpio" <linux-gpio@vger.kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"linux-arm-kernel" <linux-arm-kernel@lists.infradead.org>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"linux-sunxi" <linux-sunxi@lists.linux.dev>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>, "Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>
Subject: [PATCH 4/4] pinctrl: st: Switch to use regmap_field_test_bits
Date: Sat, 21 May 2022 07:29:29 -0700	[thread overview]
Message-ID: <180e705f8de.1012cdc8c45890.1645144071309904245@zohomail.com> (raw)
In-Reply-To: <180e702a15f.e737e37e45859.3135149506136486394@zohomail.com>

From: Li Chen <lchen@ambarella.com>

Appropriately change calls to regmap_field_read() with
regmap_field_test_bits() for improved readability.

Signed-off-by: Li Chen <lchen@ambarella.com>
---
 drivers/pinctrl/pinctrl-st.c | 23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 0fea71fd9a00..971b54bb478a 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -573,23 +573,18 @@ static void st_pinconf_set_retime_dedicated(struct st_pinctrl *info,
 static void st_pinconf_get_direction(struct st_pio_control *pc,
 	int pin, unsigned long *config)
 {
-	unsigned int oe_value, pu_value, od_value;
-
 	if (pc->oe) {
-		regmap_field_read(pc->oe, &oe_value);
-		if (oe_value & BIT(pin))
+		if (regmap_field_test_bits(pc->oe, BIT(pin)))
 			ST_PINCONF_PACK_OE(*config);
 	}
 
 	if (pc->pu) {
-		regmap_field_read(pc->pu, &pu_value);
-		if (pu_value & BIT(pin))
+		if (regmap_field_test_bits(pc->pu, BIT(pin)))
 			ST_PINCONF_PACK_PU(*config);
 	}
 
 	if (pc->od) {
-		regmap_field_read(pc->od, &od_value);
-		if (od_value & BIT(pin))
+		if (regmap_field_test_bits(pc->od, &od_value, BIT(pin)))
 			ST_PINCONF_PACK_OD(*config);
 	}
 }
@@ -599,22 +594,22 @@ static int st_pinconf_get_retime_packed(struct st_pinctrl *info,
 {
 	const struct st_pctl_data *data = info->data;
 	struct st_retime_packed *rt_p = &pc->rt.rt_p;
-	unsigned int delay_bits, delay, delay0, delay1, val;
+	unsigned int delay_bits, delay, delay0, delay1;
 	int output = ST_PINCONF_UNPACK_OE(*config);
 
-	if (!regmap_field_read(rt_p->retime, &val) && (val & BIT(pin)))
+	if (!regmap_field_test_bits(rt_p->retime, BIT(pin)))
 		ST_PINCONF_PACK_RT(*config);
 
-	if (!regmap_field_read(rt_p->clk1notclk0, &val) && (val & BIT(pin)))
+	if (!regmap_field_test_bits(rt_p->clk1notclk0, BIT(pin)))
 		ST_PINCONF_PACK_RT_CLK(*config, 1);
 
-	if (!regmap_field_read(rt_p->clknotdata, &val) && (val & BIT(pin)))
+	if (!regmap_field_test_bits(rt_p->clknotdata, BIT(pin)))
 		ST_PINCONF_PACK_RT_CLKNOTDATA(*config);
 
-	if (!regmap_field_read(rt_p->double_edge, &val) && (val & BIT(pin)))
+	if (!regmap_field_test_bits(rt_p->double_edge, BIT(pin)))
 		ST_PINCONF_PACK_RT_DOUBLE_EDGE(*config);
 
-	if (!regmap_field_read(rt_p->invertclk, &val) && (val & BIT(pin)))
+	if (!regmap_field_test_bits(rt_p->invertclk, BIT(pin)))
 		ST_PINCONF_PACK_RT_INVERTCLK(*config);
 
 	regmap_field_read(rt_p->delay_0, &delay0);
-- 
2.36.1



WARNING: multiple messages have this Message-ID
From: Li Chen <lchen.firstlove@zohomail.com>
To: "Mark Brown" <broonie@kernel.org>,
	"linux-kernel" <linux-kernel@vger.kernel.org>,
	"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
	"Rafael J. Wysocki" <rafael@kernel.org>,
	"linux-gpio" <linux-gpio@vger.kernel.org>,
	"Linus Walleij" <linus.walleij@linaro.org>,
	"linux-arm-kernel" <linux-arm-kernel@lists.infradead.org>,
	"Patrice Chotard" <patrice.chotard@foss.st.com>,
	"linux-sunxi" <linux-sunxi@lists.linux.dev>,
	"Liam Girdwood" <lgirdwood@gmail.com>,
	"Jaroslav Kysela" <perex@perex.cz>,
	"Takashi Iwai" <tiwai@suse.com>, "Chen-Yu Tsai" <wens@csie.org>,
	"Jernej Skrabec" <jernej.skrabec@gmail.com>,
	"Samuel Holland" <samuel@sholland.org>,
	"Philipp Zabel" <p.zabel@pengutronix.de>
Subject: [PATCH 4/4] pinctrl: st: Switch to use regmap_field_test_bits
Date: Sat, 21 May 2022 07:29:29 -0700	[thread overview]
Message-ID: <180e705f8de.1012cdc8c45890.1645144071309904245@zohomail.com> (raw)
In-Reply-To: <180e702a15f.e737e37e45859.3135149506136486394@zohomail.com>

From: Li Chen <lchen@ambarella.com>

Appropriately change calls to regmap_field_read() with
regmap_field_test_bits() for improved readability.

Signed-off-by: Li Chen <lchen@ambarella.com>
---
 drivers/pinctrl/pinctrl-st.c | 23 +++++++++--------------
 1 file changed, 9 insertions(+), 14 deletions(-)

diff --git a/drivers/pinctrl/pinctrl-st.c b/drivers/pinctrl/pinctrl-st.c
index 0fea71fd9a00..971b54bb478a 100644
--- a/drivers/pinctrl/pinctrl-st.c
+++ b/drivers/pinctrl/pinctrl-st.c
@@ -573,23 +573,18 @@ static void st_pinconf_set_retime_dedicated(struct st_pinctrl *info,
 static void st_pinconf_get_direction(struct st_pio_control *pc,
 	int pin, unsigned long *config)
 {
-	unsigned int oe_value, pu_value, od_value;
-
 	if (pc->oe) {
-		regmap_field_read(pc->oe, &oe_value);
-		if (oe_value & BIT(pin))
+		if (regmap_field_test_bits(pc->oe, BIT(pin)))
 			ST_PINCONF_PACK_OE(*config);
 	}
 
 	if (pc->pu) {
-		regmap_field_read(pc->pu, &pu_value);
-		if (pu_value & BIT(pin))
+		if (regmap_field_test_bits(pc->pu, BIT(pin)))
 			ST_PINCONF_PACK_PU(*config);
 	}
 
 	if (pc->od) {
-		regmap_field_read(pc->od, &od_value);
-		if (od_value & BIT(pin))
+		if (regmap_field_test_bits(pc->od, &od_value, BIT(pin)))
 			ST_PINCONF_PACK_OD(*config);
 	}
 }
@@ -599,22 +594,22 @@ static int st_pinconf_get_retime_packed(struct st_pinctrl *info,
 {
 	const struct st_pctl_data *data = info->data;
 	struct st_retime_packed *rt_p = &pc->rt.rt_p;
-	unsigned int delay_bits, delay, delay0, delay1, val;
+	unsigned int delay_bits, delay, delay0, delay1;
 	int output = ST_PINCONF_UNPACK_OE(*config);
 
-	if (!regmap_field_read(rt_p->retime, &val) && (val & BIT(pin)))
+	if (!regmap_field_test_bits(rt_p->retime, BIT(pin)))
 		ST_PINCONF_PACK_RT(*config);
 
-	if (!regmap_field_read(rt_p->clk1notclk0, &val) && (val & BIT(pin)))
+	if (!regmap_field_test_bits(rt_p->clk1notclk0, BIT(pin)))
 		ST_PINCONF_PACK_RT_CLK(*config, 1);
 
-	if (!regmap_field_read(rt_p->clknotdata, &val) && (val & BIT(pin)))
+	if (!regmap_field_test_bits(rt_p->clknotdata, BIT(pin)))
 		ST_PINCONF_PACK_RT_CLKNOTDATA(*config);
 
-	if (!regmap_field_read(rt_p->double_edge, &val) && (val & BIT(pin)))
+	if (!regmap_field_test_bits(rt_p->double_edge, BIT(pin)))
 		ST_PINCONF_PACK_RT_DOUBLE_EDGE(*config);
 
-	if (!regmap_field_read(rt_p->invertclk, &val) && (val & BIT(pin)))
+	if (!regmap_field_test_bits(rt_p->invertclk, BIT(pin)))
 		ST_PINCONF_PACK_RT_INVERTCLK(*config);
 
 	regmap_field_read(rt_p->delay_0, &delay0);
-- 
2.36.1



_______________________________________________
linux-arm-kernel mailing list
linux-arm-kernel@lists.infradead.org
http://lists.infradead.org/mailman/listinfo/linux-arm-kernel

  parent reply	other threads:[~2022-05-21 14:30 UTC|newest]

Thread overview: 44+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2022-05-21 14:25 [PATCH 0/4] Add regmap_field helpers for simple bit operations Li Chen
2022-05-21 14:25 ` Li Chen
2022-05-21 14:26 ` [PATCH 1/4] regmap: provide " Li Chen
2022-05-21 14:26   ` Li Chen
2022-05-21 14:27 ` [PATCH 2/4] ASoC: sunxi: Use {regmap/regmap_field}_{set/clear}_bits helpers Li Chen
2022-05-21 14:27   ` Li Chen
2022-05-21 14:28 ` [PATCH 3/4] pinctrl: bcm: Use regmap_field_{set/clear}_bits helpers Li Chen
2022-05-21 14:28   ` Li Chen
2022-05-21 14:29 ` Li Chen [this message]
2022-05-21 14:29   ` [PATCH 4/4] pinctrl: st: Switch to use regmap_field_test_bits Li Chen
2022-05-22 16:03   ` kernel test robot
2022-05-22 16:03     ` kernel test robot
2022-05-23  2:22 ` [PATCH v2 0/4] Add regmap_field helpers for simple bit operations Li Chen
2022-05-23  2:22   ` Li Chen
2022-05-23  2:23   ` [PATCH v2 1/4] regmap: provide " Li Chen
2022-05-23  2:23     ` Li Chen
2022-05-23  3:09     ` Samuel Holland
2022-05-23  3:09       ` Samuel Holland
2022-05-23  3:30       ` Li Chen
2022-05-23  3:30         ` Li Chen
2022-05-23  2:24   ` [PATCH v2 2/4] ASoC: sunxi: Use {regmap/regmap_field}_{set/clear}_bits helpers Li Chen
2022-05-23  2:24     ` Li Chen
2022-05-23  2:25   ` [PATCH v2 3/4] pinctrl: bcm: Use regmap_field_{set/clear}_bits helpers Li Chen
2022-05-23  2:25     ` Li Chen
2022-05-23  2:25   ` [PATCH v2 4/4] pinctrl: st: Switch to use regmap_field_test_bits Li Chen
2022-05-23  2:25     ` Li Chen
2022-05-23 11:39   ` [PATCH v2 0/4] Add regmap_field helpers for simple bit operations Mark Brown
2022-05-23 11:39     ` Mark Brown
2022-05-23 13:19     ` Li Chen
2022-05-23 13:19       ` Li Chen
2022-05-23  3:26 ` [PATCH v3 " Li Chen
2022-05-23  3:26   ` Li Chen
2022-05-23  3:26   ` [PATCH v3 1/4] regmap: provide " Li Chen
2022-05-23  3:26     ` Li Chen
2022-05-23  3:27   ` [PATCH v3 2/4] ASoC: sunxi: Use {regmap/regmap_field}_{set/clear}_bits helpers Li Chen
2022-05-23  3:27     ` Li Chen
2022-05-23  3:28   ` [PATCH v3 3/4] pinctrl: bcm: Use regmap_field_{set/clear}_bits helpers Li Chen
2022-05-23  3:28     ` Li Chen
2022-05-23  3:29   ` [PATCH v3 4/4] pinctrl: st: Switch to use regmap_field_test_bits Li Chen
2022-05-23  3:29     ` Li Chen
2022-06-15 16:59   ` [PATCH v3 0/4] Add regmap_field helpers for simple bit operations Mark Brown
2022-06-15 16:59     ` Mark Brown
2022-06-15 17:08   ` (subset) " Mark Brown
2022-06-15 17:08     ` Mark Brown

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=180e705f8de.1012cdc8c45890.1645144071309904245@zohomail.com \
    --to=lchen.firstlove@zohomail.com \
    --cc=broonie@kernel.org \
    --cc=gregkh@linuxfoundation.org \
    --cc=jernej.skrabec@gmail.com \
    --cc=lgirdwood@gmail.com \
    --cc=linus.walleij@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-gpio@vger.kernel.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-sunxi@lists.linux.dev \
    --cc=p.zabel@pengutronix.de \
    --cc=patrice.chotard@foss.st.com \
    --cc=perex@perex.cz \
    --cc=rafael@kernel.org \
    --cc=samuel@sholland.org \
    --cc=tiwai@suse.com \
    --cc=wens@csie.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is an external index of several public inboxes,
see mirroring instructions on how to clone and mirror
all data and code used by this external index.