From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id DA4BEC433FE for ; Wed, 1 Dec 2021 07:05:40 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1347100AbhLAHJA (ORCPT ); Wed, 1 Dec 2021 02:09:00 -0500 Received: from cpanel.siel.si ([46.19.9.99]:40652 "EHLO cpanel.siel.si" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1347093AbhLAHI5 (ORCPT ); Wed, 1 Dec 2021 02:08:57 -0500 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version: Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0HHMdY7fH0VJJ8PY9BgTfcGDckAtgaxqMGwy0bZ1jWA=; b=IiC1fVHbnhjVsbphiyWNRppGL6 SbfcGMptqAziTVkRHCv4ADFPkY6LhEV8DNuNip7EIErX4/8lellSeqUXWb/xlOk2lPDBSTgSfxXi1 54DW88/zTkLzeGn0pFNi6SUWt8usRwhcNMluz3Nq3qtBHNxpw38RxI3RJySUVJ/py9iKEnfsTs8Wi A5oxr0OnfsPG0CqWUFhfGI4zdaCQozc5jU3HbUsScV4c+JRIa9b1DVd0/bXS5I0L9xWgirfU+KLvK iNRC5yRp0FFVRPfmPgulcBs5oKUtOoMJfUBGv0vQvFLx4afrDsS5fvWS+uUNt1uVqwGzRj+1tJn32 e5Uu0rWA==; Received: from [89.212.21.243] (port=58890 helo=[192.168.69.215]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1msJgE-007VqG-KX; Wed, 01 Dec 2021 08:05:33 +0100 Subject: Re: [PATCH v2 3/4] dt-bindings: watchdog: da9062: add watchdog timeout mode To: Guenter Roeck , Adam Thomson Cc: Support Opensource , "wim@linux-watchdog.org" , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-imx@nxp.com" , "linux-arm-kernel@lists.infradead.org" References: <20211130134242.3516619-1-andrej.picej@norik.com> <20211130134242.3516619-3-andrej.picej@norik.com> <4591cdd6-9a7b-cd1d-817d-8950c8976d10@roeck-us.net> <8257f965-7f0f-f513-9d86-e43baf010967@roeck-us.net> From: Andrej Picej Message-ID: <180e8f8e-f31c-fa80-ef64-24758a634abf@norik.com> Date: Wed, 1 Dec 2021 08:05:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <8257f965-7f0f-f513-9d86-e43baf010967@roeck-us.net> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 8bit X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - vger.kernel.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org On 1. 12. 21 08:01, Guenter Roeck wrote: > On 11/30/21 10:42 PM, Andrej Picej wrote: >> >> On 30. 11. 21 18:46, Adam Thomson wrote: >>> On 30 November 2021 16:40, Guenter Roeck wrote: >>> >>>>>> Why does it need a value ? Why not just bool ? >>>>> >>>>> One argument might be that if the property isn't provided then the OTP >>>>> configured value can persist without needing a FW change around >>>>> this DT >>>> binding. >>>>> >>>>> My belief though is that the majority of users would have this >>>>> property set to 0 >>>>> by default in OTP, so a boolean would be OK I think here to enable >>>>> watchdog >>>>> shutdown. >>>>> >>>> >>>> Sorry, you lost me. >>>>     dlg,wdt-sd = <0>; >>>> is the current situation, and identical to not having the property in >>>> the first place. >>>>     dlg,wdt-sd = <1>; >>>> is new. I don't see the difference to >>>>     dlg,wdt-sd; >>>> vs. not having the property at all (which is, again, the current >>>> situation). >>>> Since it has to be backward compatible, >>>>     dlg,wdt-sd = <0>; >>>> will always be identical to not having the property at all. >>>> I can not find a situation where an integer would have any benefits >>>> over a >>>> boolean. >>> >>> So if you have a binary DT binding, it's either there or it isn't >>> which implies >>> the bit to be set to 0/1 in this case. If you have a binding which >>> has a value, >>> there can be 3 outcomes in this discussion: >>> >>>   1) Binding = 0, bit is set to 0 >>>   2) Binding = 1, bit is set to 1 >>>   3) Binding NOT present in DT, OTP default value in HW remains >>> untouched >>> >>> Say a platform updates to a later kernel version, but sticks with >>> existing DT >>> FW (i.e. the new boolean binding isn't present in FW), then the >>> following could >>> happen: >>> >>>   1) OTP for DA9061/2 has this bit set to 1, system expectation is >>> that watchdog >>>      triggers SHUTDOWN. >>>   2) New driver checks existance of 'dlg,wdt-sd' but it's obviously >>> not there so >>>      assumes the bit should be set to 0 and does so >>>   3) When the watchdog fires, it will no longer trigger SHUTDOWN but >>> instead >>>      POWER-DOWN due to binary handling of new boolean binding. >>> >> >> This was my thinking exactly. I also first thought about boolean >> value, but I then moved to the integer value of 0 or 1 after checking >> the OTP default for this bit. The da9062 I'm working with has the bit >> set to 1 by default. > > That needs to be be documented. > > Guenter Ok, I will add a note about the default value and how it is defined by OTP. Will submit a v3. Thanks for review. BR, Andrej From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id 2842CC433EF for ; Wed, 1 Dec 2021 07:07:04 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender:Content-Type: Content-Transfer-Encoding:List-Subscribe:List-Help:List-Post:List-Archive: List-Unsubscribe:List-Id:In-Reply-To:MIME-Version:Date:Message-ID:From: References:Cc:To:Subject:Reply-To:Content-ID:Content-Description:Resent-Date: Resent-From:Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Owner; bh=ZBdtxSZ0q0lYMeQVR/ZlxqHbt3/+ZQz7X7pVWRVrOW8=; b=d0TDw22wmY+A5qJ9wGO8c6mw6t znhz0UR8ecoZPLJP527tK9JT/T3jR9v9HqYHJlQ1II7oA7kQH4yHWYiozhgU2E0HTtWFmqfmyVMZA PF6xA3KitxagG2My6OEUaAjSe58XkSc+PfkeizT8BogUirj1z4ykwnKzxgPnikcbIy2NjAg5cSoyj bKATwsbfuAahrIGb6rvFigattLLAB2mmvSPadDx9uqAzzit7A0gjHT9m3VSr7YklXoyNMo2lrh63E pBsDMclzMwhcwW6+HDGVUwL/bnMilnUNvhZuEJlIPjBa3gojBtvO9pMwG35n5mUNT/NYRtcRWWrbB nAvpjk5g==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1msJgV-007b2U-0w; Wed, 01 Dec 2021 07:05:43 +0000 Received: from cpanel.siel.si ([46.19.9.99]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1msJgQ-007b1H-MM for linux-arm-kernel@lists.infradead.org; Wed, 01 Dec 2021 07:05:40 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=norik.com; s=default; h=Content-Transfer-Encoding:Content-Type:In-Reply-To:MIME-Version: Date:Message-ID:From:References:Cc:To:Subject:Sender:Reply-To:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Id:List-Help:List-Unsubscribe:List-Subscribe: List-Post:List-Owner:List-Archive; bh=0HHMdY7fH0VJJ8PY9BgTfcGDckAtgaxqMGwy0bZ1jWA=; b=IiC1fVHbnhjVsbphiyWNRppGL6 SbfcGMptqAziTVkRHCv4ADFPkY6LhEV8DNuNip7EIErX4/8lellSeqUXWb/xlOk2lPDBSTgSfxXi1 54DW88/zTkLzeGn0pFNi6SUWt8usRwhcNMluz3Nq3qtBHNxpw38RxI3RJySUVJ/py9iKEnfsTs8Wi A5oxr0OnfsPG0CqWUFhfGI4zdaCQozc5jU3HbUsScV4c+JRIa9b1DVd0/bXS5I0L9xWgirfU+KLvK iNRC5yRp0FFVRPfmPgulcBs5oKUtOoMJfUBGv0vQvFLx4afrDsS5fvWS+uUNt1uVqwGzRj+1tJn32 e5Uu0rWA==; Received: from [89.212.21.243] (port=58890 helo=[192.168.69.215]) by cpanel.siel.si with esmtpsa (TLS1.2) tls TLS_ECDHE_RSA_WITH_AES_128_GCM_SHA256 (Exim 4.94.2) (envelope-from ) id 1msJgE-007VqG-KX; Wed, 01 Dec 2021 08:05:33 +0100 Subject: Re: [PATCH v2 3/4] dt-bindings: watchdog: da9062: add watchdog timeout mode To: Guenter Roeck , Adam Thomson Cc: Support Opensource , "wim@linux-watchdog.org" , "linux-watchdog@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "robh+dt@kernel.org" , "devicetree@vger.kernel.org" , "shawnguo@kernel.org" , "s.hauer@pengutronix.de" , "kernel@pengutronix.de" , "festevam@gmail.com" , "linux-imx@nxp.com" , "linux-arm-kernel@lists.infradead.org" References: <20211130134242.3516619-1-andrej.picej@norik.com> <20211130134242.3516619-3-andrej.picej@norik.com> <4591cdd6-9a7b-cd1d-817d-8950c8976d10@roeck-us.net> <8257f965-7f0f-f513-9d86-e43baf010967@roeck-us.net> From: Andrej Picej Message-ID: <180e8f8e-f31c-fa80-ef64-24758a634abf@norik.com> Date: Wed, 1 Dec 2021 08:05:35 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:78.0) Gecko/20100101 Thunderbird/78.14.0 MIME-Version: 1.0 In-Reply-To: <8257f965-7f0f-f513-9d86-e43baf010967@roeck-us.net> Content-Language: en-US X-AntiAbuse: This header was added to track abuse, please include it with any abuse report X-AntiAbuse: Primary Hostname - cpanel.siel.si X-AntiAbuse: Original Domain - lists.infradead.org X-AntiAbuse: Originator/Caller UID/GID - [47 12] / [47 12] X-AntiAbuse: Sender Address Domain - norik.com X-Get-Message-Sender-Via: cpanel.siel.si: authenticated_id: andrej.picej@norik.com X-Authenticated-Sender: cpanel.siel.si: andrej.picej@norik.com X-Source: X-Source-Args: X-Source-Dir: X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20211130_230538_929410_972046F2 X-CRM114-Status: GOOD ( 19.13 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Transfer-Encoding: base64 Content-Type: text/plain; charset="utf-8"; Format="flowed" Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org CgpPbiAxLiAxMi4gMjEgMDg6MDEsIEd1ZW50ZXIgUm9lY2sgd3JvdGU6Cj4gT24gMTEvMzAvMjEg MTA6NDIgUE0sIEFuZHJlaiBQaWNlaiB3cm90ZToKPj4KPj4gT24gMzAuIDExLiAyMSAxODo0Niwg QWRhbSBUaG9tc29uIHdyb3RlOgo+Pj4gT24gMzAgTm92ZW1iZXIgMjAyMSAxNjo0MCwgR3VlbnRl ciBSb2VjayB3cm90ZToKPj4+Cj4+Pj4+PiBXaHkgZG9lcyBpdCBuZWVkIGEgdmFsdWUgPyBXaHkg bm90IGp1c3QgYm9vbCA/Cj4+Pj4+Cj4+Pj4+IE9uZSBhcmd1bWVudCBtaWdodCBiZSB0aGF0IGlm IHRoZSBwcm9wZXJ0eSBpc24ndCBwcm92aWRlZCB0aGVuIHRoZSBPVFAKPj4+Pj4gY29uZmlndXJl ZCB2YWx1ZSBjYW4gcGVyc2lzdCB3aXRob3V0IG5lZWRpbmcgYSBGVyBjaGFuZ2UgYXJvdW5kIAo+ Pj4+PiB0aGlzIERUCj4+Pj4gYmluZGluZy4KPj4+Pj4KPj4+Pj4gTXkgYmVsaWVmIHRob3VnaCBp cyB0aGF0IHRoZSBtYWpvcml0eSBvZiB1c2VycyB3b3VsZCBoYXZlIHRoaXMgCj4+Pj4+IHByb3Bl cnR5IHNldCB0byAwCj4+Pj4+IGJ5IGRlZmF1bHQgaW4gT1RQLCBzbyBhIGJvb2xlYW4gd291bGQg YmUgT0sgSSB0aGluayBoZXJlIHRvIGVuYWJsZSAKPj4+Pj4gd2F0Y2hkb2cKPj4+Pj4gc2h1dGRv d24uCj4+Pj4+Cj4+Pj4KPj4+PiBTb3JyeSwgeW91IGxvc3QgbWUuCj4+Pj4gwqDCoMKgwqBkbGcs d2R0LXNkID0gPDA+Owo+Pj4+IGlzIHRoZSBjdXJyZW50IHNpdHVhdGlvbiwgYW5kIGlkZW50aWNh bCB0byBub3QgaGF2aW5nIHRoZSBwcm9wZXJ0eSBpbgo+Pj4+IHRoZSBmaXJzdCBwbGFjZS4KPj4+ PiDCoMKgwqDCoGRsZyx3ZHQtc2QgPSA8MT47Cj4+Pj4gaXMgbmV3LiBJIGRvbid0IHNlZSB0aGUg ZGlmZmVyZW5jZSB0bwo+Pj4+IMKgwqDCoMKgZGxnLHdkdC1zZDsKPj4+PiB2cy4gbm90IGhhdmlu ZyB0aGUgcHJvcGVydHkgYXQgYWxsICh3aGljaCBpcywgYWdhaW4sIHRoZSBjdXJyZW50IAo+Pj4+ IHNpdHVhdGlvbikuCj4+Pj4gU2luY2UgaXQgaGFzIHRvIGJlIGJhY2t3YXJkIGNvbXBhdGlibGUs Cj4+Pj4gwqDCoMKgwqBkbGcsd2R0LXNkID0gPDA+Owo+Pj4+IHdpbGwgYWx3YXlzIGJlIGlkZW50 aWNhbCB0byBub3QgaGF2aW5nIHRoZSBwcm9wZXJ0eSBhdCBhbGwuCj4+Pj4gSSBjYW4gbm90IGZp bmQgYSBzaXR1YXRpb24gd2hlcmUgYW4gaW50ZWdlciB3b3VsZCBoYXZlIGFueSBiZW5lZml0cyAK Pj4+PiBvdmVyIGEKPj4+PiBib29sZWFuLgo+Pj4KPj4+IFNvIGlmIHlvdSBoYXZlIGEgYmluYXJ5 IERUIGJpbmRpbmcsIGl0J3MgZWl0aGVyIHRoZXJlIG9yIGl0IGlzbid0IAo+Pj4gd2hpY2ggaW1w bGllcwo+Pj4gdGhlIGJpdCB0byBiZSBzZXQgdG8gMC8xIGluIHRoaXMgY2FzZS4gSWYgeW91IGhh dmUgYSBiaW5kaW5nIHdoaWNoIAo+Pj4gaGFzIGEgdmFsdWUsCj4+PiB0aGVyZSBjYW4gYmUgMyBv dXRjb21lcyBpbiB0aGlzIGRpc2N1c3Npb246Cj4+Pgo+Pj4gwqAgMSkgQmluZGluZyA9IDAsIGJp dCBpcyBzZXQgdG8gMAo+Pj4gwqAgMikgQmluZGluZyA9IDEsIGJpdCBpcyBzZXQgdG8gMQo+Pj4g wqAgMykgQmluZGluZyBOT1QgcHJlc2VudCBpbiBEVCwgT1RQIGRlZmF1bHQgdmFsdWUgaW4gSFcg cmVtYWlucyAKPj4+IHVudG91Y2hlZAo+Pj4KPj4+IFNheSBhIHBsYXRmb3JtIHVwZGF0ZXMgdG8g YSBsYXRlciBrZXJuZWwgdmVyc2lvbiwgYnV0IHN0aWNrcyB3aXRoIAo+Pj4gZXhpc3RpbmcgRFQK Pj4+IEZXIChpLmUuIHRoZSBuZXcgYm9vbGVhbiBiaW5kaW5nIGlzbid0IHByZXNlbnQgaW4gRlcp LCB0aGVuIHRoZSAKPj4+IGZvbGxvd2luZyBjb3VsZAo+Pj4gaGFwcGVuOgo+Pj4KPj4+IMKgIDEp IE9UUCBmb3IgREE5MDYxLzIgaGFzIHRoaXMgYml0IHNldCB0byAxLCBzeXN0ZW0gZXhwZWN0YXRp b24gaXMgCj4+PiB0aGF0IHdhdGNoZG9nCj4+PiDCoMKgwqDCoCB0cmlnZ2VycyBTSFVURE9XTi4K Pj4+IMKgIDIpIE5ldyBkcml2ZXIgY2hlY2tzIGV4aXN0YW5jZSBvZiAnZGxnLHdkdC1zZCcgYnV0 IGl0J3Mgb2J2aW91c2x5IAo+Pj4gbm90IHRoZXJlIHNvCj4+PiDCoMKgwqDCoCBhc3N1bWVzIHRo ZSBiaXQgc2hvdWxkIGJlIHNldCB0byAwIGFuZCBkb2VzIHNvCj4+PiDCoCAzKSBXaGVuIHRoZSB3 YXRjaGRvZyBmaXJlcywgaXQgd2lsbCBubyBsb25nZXIgdHJpZ2dlciBTSFVURE9XTiBidXQgCj4+ PiBpbnN0ZWFkCj4+PiDCoMKgwqDCoCBQT1dFUi1ET1dOIGR1ZSB0byBiaW5hcnkgaGFuZGxpbmcg b2YgbmV3IGJvb2xlYW4gYmluZGluZy4KPj4+Cj4+Cj4+IFRoaXMgd2FzIG15IHRoaW5raW5nIGV4 YWN0bHkuIEkgYWxzbyBmaXJzdCB0aG91Z2h0IGFib3V0IGJvb2xlYW4gCj4+IHZhbHVlLCBidXQg SSB0aGVuIG1vdmVkIHRvIHRoZSBpbnRlZ2VyIHZhbHVlIG9mIDAgb3IgMSBhZnRlciBjaGVja2lu ZyAKPj4gdGhlIE9UUCBkZWZhdWx0IGZvciB0aGlzIGJpdC4gVGhlIGRhOTA2MiBJJ20gd29ya2lu ZyB3aXRoIGhhcyB0aGUgYml0IAo+PiBzZXQgdG8gMSBieSBkZWZhdWx0Lgo+IAo+IFRoYXQgbmVl ZHMgdG8gYmUgYmUgZG9jdW1lbnRlZC4KPiAKPiBHdWVudGVyCgpPaywgSSB3aWxsIGFkZCBhIG5v dGUgYWJvdXQgdGhlIGRlZmF1bHQgdmFsdWUgYW5kIGhvdyBpdCBpcyBkZWZpbmVkIGJ5IApPVFAu IFdpbGwgc3VibWl0IGEgdjMuCgpUaGFua3MgZm9yIHJldmlldy4KCkJSLApBbmRyZWoKCl9fX19f X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fCmxpbnV4LWFybS1rZXJu ZWwgbWFpbGluZyBsaXN0CmxpbnV4LWFybS1rZXJuZWxAbGlzdHMuaW5mcmFkZWFkLm9yZwpodHRw Oi8vbGlzdHMuaW5mcmFkZWFkLm9yZy9tYWlsbWFuL2xpc3RpbmZvL2xpbnV4LWFybS1rZXJuZWwK