From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from sender4-pp-o94.zoho.com (sender4-pp-o94.zoho.com [136.143.188.94]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id D7EB036D for ; Mon, 23 May 2022 03:31:06 +0000 (UTC) ARC-Seal: i=1; a=rsa-sha256; t=1653276526; cv=none; d=zohomail.com; s=zohoarc; b=D0fkNpDPzsA2EuGEHBR0s+MqO+mReMfgpm1vPEaKabZWS7GCLUFKDHtBMEQImHtzsumnZC2aHxPkCzvQUoqXJy5Q4KbfNKGZT8/gdLanpTGwTrCu34DpkXu5zdfKftzy8c30AgYcE24aKGgkoTmzAgFUhBaCG4lpTIi0d0Bwgi8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653276526; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=fvKlICVNUUrLCUJvTxodNTr2NlUW+NUhpKNpJF53DY0=; b=M5S+FFVK6Mhl0bVPiR9i3uk+3C1QFX8ha2wsSgNM5KxXxStPxj2+5vg4WDqC9U5HDxjzHRKUnhKH37m7236YjiP56ExUuu4o41yriXIxbw/x8YhUDOcet+wHEf04BC2KWpr575xMR/c0zgOchLvjquyzkjx9Z+rRar5mUeJOgoc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zohomail.com; spf=pass smtp.mailfrom=lchen.firstlove@zohomail.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653276526; s=zm2022; d=zohomail.com; i=lchen.firstlove@zohomail.com; h=Date:Date:From:From:To:To:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Feedback-ID:Message-Id:Reply-To:Cc; bh=fvKlICVNUUrLCUJvTxodNTr2NlUW+NUhpKNpJF53DY0=; b=OuYUp2YImrVwOfdieSiPpSIXEbfglaJJTnlzPpPX7jW3vw02wQxzycOBC8jdz97x MywoLJvK04gBjkPnZFDVauUc0GXZlmgslGUdquwSt95negFNDg1LMyvDkf+9LxyxFQn 0obl3z7FfW6YIlLB0iGe309DAuRXcHTe1gCd1EHI= Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1653276524341734.1163480582672; Sun, 22 May 2022 20:28:44 -0700 (PDT) Received: from [45.12.140.94] by mail.zoho.com with HTTP;Sun, 22 May 2022 20:28:44 -0700 (PDT) Date: Sun, 22 May 2022 20:28:44 -0700 From: Li Chen To: "Mark Brown" , "linux-kernel" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "linux-gpio" , "Linus Walleij" , "linux-arm-kernel" , "Patrice Chotard" , "linux-sunxi" , "Liam Girdwood" , "Jaroslav Kysela" , "Takashi Iwai" , "Chen-Yu Tsai" , "Jernej Skrabec" , "Samuel Holland" , "Philipp Zabel" Message-ID: <180eef5bf1c.ce3c2e5460752.6975656435857169231@zohomail.com> In-Reply-To: <180eef39205.122d47c8260721.2430302798386025245@zohomail.com> References: <180e702a15f.e737e37e45859.3135149506136486394@zohomail.com> <180eef39205.122d47c8260721.2430302798386025245@zohomail.com> Subject: [PATCH v3 3/4] pinctrl: bcm: Use regmap_field_{set/clear}_bits helpers Precedence: bulk X-Mailing-List: linux-sunxi@lists.linux.dev List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail Feedback-ID: rr080112263aae783704b494f131d3dbd000002d3a325e92674abb122f82f22c7a9c5da378767f82d6032c:zu08011227505fe070e568cc739ba225340000b822ef5bf7536055237e90505f92f98fcc7d4acca3a8b480f8:rf0801122c1810a98d6b346697f9da013c00009478e6a0e2a5388c91658b745d4c18fecd2cc3a43e4d0d843db1977bfd61:ZohoMail From: Li Chen Appropriately change calls to regmap_field_update_bits() with regmap_field_clear_bits() for improved readability. Signed-off-by: Li Chen --- drivers/pinctrl/bcm/pinctrl-bcm6358.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6358.c b/drivers/pinctrl/bcm/pinctrl-bcm6358.c index 9f6cd7447887..b03dfcb171d1 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm6358.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm6358.c @@ -300,7 +300,7 @@ static int bcm6358_gpio_request_enable(struct pinctrl_dev *pctldev, return 0; /* disable all functions using this pin */ - return regmap_field_update_bits(priv->overlays, mask, 0); + return regmap_field_clear_bits(priv->overlays, mask); } static const struct pinctrl_ops bcm6358_pctl_ops = { -- 2.36.1 From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from bombadil.infradead.org (bombadil.infradead.org [198.137.202.133]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.lore.kernel.org (Postfix) with ESMTPS id E9397C433EF for ; Mon, 23 May 2022 09:35:32 +0000 (UTC) DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=lists.infradead.org; s=bombadil.20210309; h=Sender: Content-Transfer-Encoding:Content-Type:List-Subscribe:List-Help:List-Post: List-Archive:List-Unsubscribe:List-Id:MIME-Version:Subject:References: In-Reply-To:Message-ID:To:From:Date:Reply-To:Cc:Content-ID: Content-Description:Resent-Date:Resent-From:Resent-Sender:Resent-To:Resent-Cc :Resent-Message-ID:List-Owner; bh=tzodOrNxWdSgQOdTMwhBb7uzFwR6g0MYWp1HckrDpMY=; b=quQ6NF5PopjyKs/mEYj/v2gcrY wyFVbC69RcjzjBxky48LsC1GdHHcc9nq+V4AxvsSb+nDEBF30VjQMiIe8dKLZSGIxXnOkrPLwCiNs Y9ff9x5DrEZVaBlXSu9wU+SJn8bWGFE9Mn0qI10ypXLRe01wwuH61Rm7ltoFZG2x74B5rTOjyYoHn BVlKTKJQqzr5BsWQyMvgTMNfpcS/fCRdmOXpx6b2ZSg7pMdYYa1JKPdkXF8oItGAkvT80O2Ns9HA/ bouvyzYIRBfbmYc4MLwJWCST34YczFjk6wFtnQJegG6WFnnVQsWAlgN7iBNdiRvZMEAeGeip0gyaj jNQaGXHA==; Received: from localhost ([::1] helo=bombadil.infradead.org) by bombadil.infradead.org with esmtp (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt4Ra-002sQp-2I; Mon, 23 May 2022 09:33:44 +0000 Received: from desiato.infradead.org ([2001:8b0:10b:1:d65d:64ff:fe57:4e05]) by bombadil.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nt2rV-002AAA-4k for linux-arm-kernel@bombadil.infradead.org; Mon, 23 May 2022 07:52:21 +0000 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=infradead.org; s=desiato.20200630; h=Content-Transfer-Encoding:Content-Type :MIME-Version:Subject:References:In-Reply-To:Message-ID:To:From:Date:Sender: Reply-To:Cc:Content-ID:Content-Description; bh=fvKlICVNUUrLCUJvTxodNTr2NlUW+NUhpKNpJF53DY0=; b=UdcP4QnRiq3pblWXrz3kPvFG0j 4uHmak9z8FZ0RJB7/P5TeQJXhFwt/ch4uvBd0z/0im84RZCfdQYxhkM8Re9PCQys82SM+jUscynEq Qqk5uI7+62oDrBFKnVzo9n8DVBw6qXGrhvZRqa1Ubo1G1xip13/nUOAwbXP6C9xsEZ9lnFy9id5zz LSeIEknoeyG3063TeUKnZZKNmbZLNOaKDuolLvyqviI1eoG54I0gMbeSTJ8ThLHSnivNnbj6mKXaF e8UOk6UbUqXWqeijo63J8MjTmCND+OYvE7/05Sisrn2UFso+GKC0+dS/oBox33fKoV3SoAs2NJGF3 gIG0sLhA==; Received: from sender4-pp-o94.zoho.com ([136.143.188.94]) by desiato.infradead.org with esmtps (Exim 4.94.2 #2 (Red Hat Linux)) id 1nsymb-000nJT-9z for linux-arm-kernel@lists.infradead.org; Mon, 23 May 2022 03:31:03 +0000 ARC-Seal: i=1; a=rsa-sha256; t=1653276526; cv=none; d=zohomail.com; s=zohoarc; b=D0fkNpDPzsA2EuGEHBR0s+MqO+mReMfgpm1vPEaKabZWS7GCLUFKDHtBMEQImHtzsumnZC2aHxPkCzvQUoqXJy5Q4KbfNKGZT8/gdLanpTGwTrCu34DpkXu5zdfKftzy8c30AgYcE24aKGgkoTmzAgFUhBaCG4lpTIi0d0Bwgi8= ARC-Message-Signature: i=1; a=rsa-sha256; c=relaxed/relaxed; d=zohomail.com; s=zohoarc; t=1653276526; h=Content-Type:Content-Transfer-Encoding:Date:From:In-Reply-To:MIME-Version:Message-ID:References:Subject:To; bh=fvKlICVNUUrLCUJvTxodNTr2NlUW+NUhpKNpJF53DY0=; b=M5S+FFVK6Mhl0bVPiR9i3uk+3C1QFX8ha2wsSgNM5KxXxStPxj2+5vg4WDqC9U5HDxjzHRKUnhKH37m7236YjiP56ExUuu4o41yriXIxbw/x8YhUDOcet+wHEf04BC2KWpr575xMR/c0zgOchLvjquyzkjx9Z+rRar5mUeJOgoc= ARC-Authentication-Results: i=1; mx.zohomail.com; dkim=pass header.i=zohomail.com; spf=pass smtp.mailfrom=lchen.firstlove@zohomail.com; dmarc=pass header.from= DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; t=1653276526; s=zm2022; d=zohomail.com; i=lchen.firstlove@zohomail.com; h=Date:Date:From:From:To:To:Message-ID:In-Reply-To:References:Subject:Subject:MIME-Version:Content-Type:Content-Transfer-Encoding:Feedback-ID:Message-Id:Reply-To:Cc; bh=fvKlICVNUUrLCUJvTxodNTr2NlUW+NUhpKNpJF53DY0=; b=OuYUp2YImrVwOfdieSiPpSIXEbfglaJJTnlzPpPX7jW3vw02wQxzycOBC8jdz97x MywoLJvK04gBjkPnZFDVauUc0GXZlmgslGUdquwSt95negFNDg1LMyvDkf+9LxyxFQn 0obl3z7FfW6YIlLB0iGe309DAuRXcHTe1gCd1EHI= Received: from mail.zoho.com by mx.zohomail.com with SMTP id 1653276524341734.1163480582672; Sun, 22 May 2022 20:28:44 -0700 (PDT) Received: from [45.12.140.94] by mail.zoho.com with HTTP;Sun, 22 May 2022 20:28:44 -0700 (PDT) Date: Sun, 22 May 2022 20:28:44 -0700 From: Li Chen To: "Mark Brown" , "linux-kernel" , "Greg Kroah-Hartman" , "Rafael J. Wysocki" , "linux-gpio" , "Linus Walleij" , "linux-arm-kernel" , "Patrice Chotard" , "linux-sunxi" , "Liam Girdwood" , "Jaroslav Kysela" , "Takashi Iwai" , "Chen-Yu Tsai" , "Jernej Skrabec" , "Samuel Holland" , "Philipp Zabel" Message-ID: <180eef5bf1c.ce3c2e5460752.6975656435857169231@zohomail.com> In-Reply-To: <180eef39205.122d47c8260721.2430302798386025245@zohomail.com> References: <180e702a15f.e737e37e45859.3135149506136486394@zohomail.com> <180eef39205.122d47c8260721.2430302798386025245@zohomail.com> Subject: [PATCH v3 3/4] pinctrl: bcm: Use regmap_field_{set/clear}_bits helpers MIME-Version: 1.0 Importance: Medium User-Agent: Zoho Mail X-Mailer: Zoho Mail Feedback-ID: rr080112263aae783704b494f131d3dbd000002d3a325e92674abb122f82f22c7a9c5da378767f82d6032c:zu08011227505fe070e568cc739ba225340000b822ef5bf7536055237e90505f92f98fcc7d4acca3a8b480f8:rf0801122c1810a98d6b346697f9da013c00009478e6a0e2a5388c91658b745d4c18fecd2cc3a43e4d0d843db1977bfd61:ZohoMail X-CRM114-Version: 20100106-BlameMichelson ( TRE 0.8.0 (BSD) ) MR-646709E3 X-CRM114-CacheID: sfid-20220523_043101_761626_177E3E02 X-CRM114-Status: GOOD ( 13.77 ) X-BeenThere: linux-arm-kernel@lists.infradead.org X-Mailman-Version: 2.1.34 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit Sender: "linux-arm-kernel" Errors-To: linux-arm-kernel-bounces+linux-arm-kernel=archiver.kernel.org@lists.infradead.org From: Li Chen Appropriately change calls to regmap_field_update_bits() with regmap_field_clear_bits() for improved readability. Signed-off-by: Li Chen --- drivers/pinctrl/bcm/pinctrl-bcm6358.c | 2 +- 1 file changed, 1 insertion(+), 1 deletion(-) diff --git a/drivers/pinctrl/bcm/pinctrl-bcm6358.c b/drivers/pinctrl/bcm/pinctrl-bcm6358.c index 9f6cd7447887..b03dfcb171d1 100644 --- a/drivers/pinctrl/bcm/pinctrl-bcm6358.c +++ b/drivers/pinctrl/bcm/pinctrl-bcm6358.c @@ -300,7 +300,7 @@ static int bcm6358_gpio_request_enable(struct pinctrl_dev *pctldev, return 0; /* disable all functions using this pin */ - return regmap_field_update_bits(priv->overlays, mask, 0); + return regmap_field_clear_bits(priv->overlays, mask); } static const struct pinctrl_ops bcm6358_pctl_ops = { -- 2.36.1 _______________________________________________ linux-arm-kernel mailing list linux-arm-kernel@lists.infradead.org http://lists.infradead.org/mailman/listinfo/linux-arm-kernel