From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-3.5 required=3.0 tests=DKIM_INVALID,DKIM_SIGNED, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH,MAILING_LIST_MULTI,SPF_HELO_NONE, SPF_PASS autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id CB6E2C3A59E for ; Mon, 2 Sep 2019 21:35:22 +0000 (UTC) Received: from lists.gnu.org (lists.gnu.org [209.51.188.17]) (using TLSv1.2 with cipher ECDHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by mail.kernel.org (Postfix) with ESMTPS id 8CACF2168B for ; Mon, 2 Sep 2019 21:35:22 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=fail reason="signature verification failed" (4096-bit key) header.d=crudebyte.com header.i=@crudebyte.com header.b="KzVnOskK" DMARC-Filter: OpenDMARC Filter v1.3.2 mail.kernel.org 8CACF2168B Authentication-Results: mail.kernel.org; dmarc=none (p=none dis=none) header.from=nongnu.org Authentication-Results: mail.kernel.org; spf=pass smtp.mailfrom=qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Received: from localhost ([::1]:40210 helo=lists1p.gnu.org) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4tyr-0004JH-F5 for qemu-devel@archiver.kernel.org; Mon, 02 Sep 2019 17:35:21 -0400 Received: from eggs.gnu.org ([2001:470:142:3::10]:37078) by lists.gnu.org with esmtp (Exim 4.90_1) (envelope-from ) id 1i4tpP-00014l-QZ for qemu-devel@nongnu.org; Mon, 02 Sep 2019 17:25:36 -0400 Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71) (envelope-from ) id 1i4tpN-0001jL-MS for qemu-devel@nongnu.org; Mon, 02 Sep 2019 17:25:35 -0400 Received: from kylie.crudebyte.com ([5.189.157.229]:52283) by eggs.gnu.org with esmtps (TLS1.0:RSA_AES_256_CBC_SHA1:32) (Exim 4.71) (envelope-from ) id 1i4tpN-0001fz-As for qemu-devel@nongnu.org; Mon, 02 Sep 2019 17:25:33 -0400 DKIM-Signature: v=1; a=rsa-sha256; q=dns/txt; c=relaxed/relaxed; d=crudebyte.com; s=kylie; h=Content-Type:Content-Transfer-Encoding: MIME-Version:References:In-Reply-To:Message-ID:Date:Subject:Cc:To:From:Sender :Reply-To:Content-ID:Content-Description:Resent-Date:Resent-From: Resent-Sender:Resent-To:Resent-Cc:Resent-Message-ID:List-Id:List-Help: List-Unsubscribe:List-Subscribe:List-Post:List-Owner:List-Archive; bh=C1vQFTE47z/tL5iJLtpo/naFHfnUi1fyTdlWVddhaoo=; b=KzVnOskKmcR2DqFDpl4NK0ed4m XcZVk7TKWwt1h9M/oamU08bBfSU/aR/kilm9TXUDTGs+7twbKYRkDFde9EAPnaHinvbqrNKPvh/vu qkA59suqar2ShklI/u08AmcPvsu31N9cnL0NznCbQCo14GDHLKFOEk94dEyKPZL81Q8uTvGeu2vgZ PKQcWyhNLZE+CJP2bVwYeSB1bsRW1XqH6323vVjpxWPLJWU/Ti2IIUS6gWeberQZwjf7UJ7zetaZ9 eOGr8F2nzSSVo71sn3HssURP82FwUpLL6vRJm5HxFh5lxjcrG3jV0TJ3rYEMnwYCh14pt+B9MKJyR 8rXHtj6RM3UHqabeZTXOxz8kjq3+sH6i7ayMNkPXBBgfyW/3u5qOWPzkZchqprZJ+5waqTgkaE+WQ 9YnZUF3NsSIQfkyR/aAHZKiOtv9k3eHDHIqKOsKaTzGea4vZj5RFv+b3Sb+749EUv050GwrhHCaZg 23gvSqCE9eT99pKeywXGsIKjTa6kMYrAZaNq0G0u+pvx7zcU4AVy2iGhSuOUqMnnLk8ps9SOVJoK0 D2e2TH6KJ+gRtWatYQiUiA4rnslMOqlX5XWC7F+3lInmf4aIesj2lGRwnJuYHL611qAt4j5q95D9B iudo1pnWStT1YYTvNaJh2KwDnvHw2IOY/YM7+HlHY=; To: qemu-devel@nongnu.org Date: Mon, 02 Sep 2019 23:25:29 +0200 Message-ID: <1811575.MgG7zZa6in@silver> In-Reply-To: <20190902134934.6b013f1a@bahia.lan> References: <1985382.8LBUmpxoXr@silver> <20190902134934.6b013f1a@bahia.lan> MIME-Version: 1.0 Content-Transfer-Encoding: 7Bit Content-Type: text/plain; charset="us-ascii" X-detected-operating-system: by eggs.gnu.org: GNU/Linux 2.2.x-3.x [generic] X-Received-From: 5.189.157.229 Subject: Re: [Qemu-devel] [PATCH v6 2/4] 9p: Added virtfs option 'multidevs=remap|forbid|warn' X-BeenThere: qemu-devel@nongnu.org X-Mailman-Version: 2.1.23 Precedence: list List-Id: List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , From: Christian Schoenebeck via Qemu-devel Reply-To: Christian Schoenebeck Cc: Daniel =?ISO-8859-1?Q?P=2E_Berrang=E9?= , Stefan Hajnoczi , Christian Schoenebeck , Greg Kurz , "Dr. David Alan Gilbert" , Antonios Motakis Errors-To: qemu-devel-bounces+qemu-devel=archiver.kernel.org@nongnu.org Sender: "Qemu-devel" On Montag, 2. September 2019 13:49:34 CEST Greg Kurz wrote: > On Sun, 01 Sep 2019 20:56:16 +0200 > > Christian Schoenebeck wrote: > > On Freitag, 30. August 2019 14:22:38 CEST Greg Kurz wrote: > > > Some more comments below. > > > > [snip] > > > > > > diff --git a/hw/9pfs/9p.c b/hw/9pfs/9p.c > > > > index 8cc65c2c67..c96ea51116 100644 > > > > --- a/hw/9pfs/9p.c > > > > +++ b/hw/9pfs/9p.c > > > > @@ -25,6 +25,7 @@ > > > > > > > > #include "trace.h" > > > > #include "migration/blocker.h" > > > > #include "sysemu/qtest.h" > > > > [snip] > > > > > > @@ -3672,8 +3807,13 @@ int v9fs_device_realize_common(V9fsState *s, > > > > const > > > > V9fsTransport *t,> > > > > > > > > goto out; > > > > > > > > } > > > > > > > > + s->root_ino = stat.st_ino; > > > > > > This isn't used anywhere. It looks like a leftover of the readdir fix > > > in v5. > > > > Yes, both correct. I intentionally left it though, since I found it a > > natural complement always capturing the root inode along to the root > > device. > Fair enough. The local backend opens an fd to the root directory, to be used > by any access to the 9p share. I think root_dev/root_ino should be obtained > with fstat() on this fd, to be sure they are consistent. Maybe add an extra > struct stat * argument to the init function ? I'd rather see this done as a > preparatory "backend to cache 9p root device/inode during init" patch. Convinced. I'll drop root_ino from this patch set for now.