From mboxrd@z Thu Jan 1 00:00:00 1970 From: Thomas Monjalon Subject: Re: [PATCH v7 0/5] kni: add API to set link status on kernel interface Date: Fri, 26 Oct 2018 19:43:50 +0200 Message-ID: <1811735.4e0LzYgYzU@xps> References: <20180911232906.18352-1-dg@adax.com> <20181024222631.30461-1-dg@adax.com> <816862ee-8042-4c66-93c8-6ceb57be4999@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7Bit Cc: dev@dpdk.org, Ferruh Yigit , Igor Ryzhov , Stephen Hemminger , bruce.richardson@intel.com, nhorman@tuxdriver.com To: Dan Gora Return-path: Received: from out3-smtp.messagingengine.com (out3-smtp.messagingengine.com [66.111.4.27]) by dpdk.org (Postfix) with ESMTP id 9621A2BE3 for ; Fri, 26 Oct 2018 19:43:48 +0200 (CEST) In-Reply-To: <816862ee-8042-4c66-93c8-6ceb57be4999@intel.com> List-Id: DPDK patches and discussions List-Unsubscribe: , List-Archive: List-Post: List-Help: List-Subscribe: , Errors-To: dev-bounces@dpdk.org Sender: "dev" 25/10/2018 14:30, Ferruh Yigit: > On 10/24/2018 11:26 PM, Dan Gora wrote: > >> Note that checkpatches.sh compains about patch 1/5, but this appears > >> to be a bug with check-symbol-change or something. If I move the > >> fragment of the patch modifying rte_kni_version.map to the bottom of > >> the patch file, it doesn't complain any more... I just don't really > >> have time to investigate this right now. Yes we have some false positives with this tool. Neil, please, would you have time to look at it? > > Dan Gora (5): > > kni: add API to set link status on kernel interface > > kni: set default carrier state of interface > > examples/kni: monitor and update link status continually > > examples/kni: add log msgs to show and clear stats > > examples/kni: improve zeroing statistics > > For series, > Acked-by: Ferruh Yigit Applied with a fix for meson build