From mboxrd@z Thu Jan 1 00:00:00 1970 From: Doug Ledford Subject: Re: [RFCv2 00/15] RFCv2: Consolidated userspace RDMA library repo Date: Fri, 26 Aug 2016 23:34:47 -0400 Message-ID: <1811977a-47ec-dc5f-22a4-acf56bb750d3@redhat.com> References: <1471889618-1605-1-git-send-email-jgunthorpe@obsidianresearch.com> <01dc01d1fcb0$a1dd3ed0$e597bc70$@opengridcomputing.com> <20160822214352.GB11695@obsidianresearch.com> <20160823185441.GA1233@obsidianresearch.com> <20160825173916.GC20612@obsidianresearch.com> Mime-Version: 1.0 Content-Type: multipart/signed; micalg=pgp-sha256; protocol="application/pgp-signature"; boundary="Qgkbg9IgCDr28rXGTXpfCleqBAklQoaFn" Return-path: In-Reply-To: <20160825173916.GC20612-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Jason Gunthorpe Cc: Steve Wise , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Devesh Sharma' , 'Hal Rosenstock' , 'Mike Marciniszyn' , 'Moni Shoua' , 'Sean Hefty' , 'Tatyana Nikolova' , 'Vladimir Sokolovsky' , 'Yishai Hadas' List-Id: linux-rdma@vger.kernel.org This is an OpenPGP/MIME signed message (RFC 4880 and 3156) --Qgkbg9IgCDr28rXGTXpfCleqBAklQoaFn Content-Type: multipart/mixed; boundary="LdFjH42mExLxm1F0F57CfhGwfNbADVKeH" From: Doug Ledford To: Jason Gunthorpe Cc: Steve Wise , linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, 'Devesh Sharma' , 'Hal Rosenstock' , 'Mike Marciniszyn' , 'Moni Shoua' , 'Sean Hefty' , 'Tatyana Nikolova' , 'Vladimir Sokolovsky' , 'Yishai Hadas' Message-ID: <1811977a-47ec-dc5f-22a4-acf56bb750d3-H+wXaHxf7aLQT0dZR+AlfA@public.gmane.org> Subject: Re: [RFCv2 00/15] RFCv2: Consolidated userspace RDMA library repo References: <1471889618-1605-1-git-send-email-jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> <01dc01d1fcb0$a1dd3ed0$e597bc70$@opengridcomputing.com> <20160822214352.GB11695-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> <20160823185441.GA1233-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> <20160825173916.GC20612-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> In-Reply-To: <20160825173916.GC20612-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org> --LdFjH42mExLxm1F0F57CfhGwfNbADVKeH Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: quoted-printable On 8/25/2016 1:39 PM, Jason Gunthorpe wrote: > On Thu, Aug 25, 2016 at 10:20:15AM -0400, Doug Ledford wrote: >> On 8/23/2016 2:54 PM, Jason Gunthorpe wrote: >>> On Mon, Aug 22, 2016 at 03:43:52PM -0600, Jason Gunthorpe wrote: >>> >>>> The full install to / is still a small TODO, it is part and parcel >>>> with doing the packaging, in my mind. >>> >>> I just pushed a basic starting point rpm spec file, it still needs to= >>> be split into multiple subpackages, but it is installable with all th= e >>> usual paths. >> >> You can do that, but I routinely tell upstream maintainers that we don= 't >> touch their spec files. Every distro modifies the spec file so heavil= y >> for their own custom installation that it just doesn't make much sense= >> to worry about it at the upstream level. Build one that can be used >> when running rpmbuild -ta and that's all you need. >=20 > I'm not sure I understand your comment. >=20 > Are you saying we don't need a specfile in upstream? I would include a spec file, it just need not be complex. So much of what goes into one is distro specific, that there is a directly proportional relationship between the complexity of the provided spec file and chances that it will actually not be useful on anything other than the one OS it was written on. > How does upstream > test the build infrastructure? The downstream distros are really on the hook for that. Making sure the make/cmake build works well is our main goal. The spec files and other packaging files are templates, nothing more than that really. > Are you saying the simple one .rpm is all we need? Yep. > Is that really > useful to developers if it clashes with the distro packaging? Yes. It's likely that no matter what we do, there will be differences between how distro package things up and how we do. The developer will need to manually uninstall the distro packages and then install the package we provide. > How do > we test the build system parts that help the package splitting? I wouldn't even go there :-) > Isn't it easier for downstream to have recommended packaging to > reference? It is. But they don't always follow it regardless. > Eg I think it was a dis-service to other distros not to update the > reference verbs spec file with the libnl dependency. I wonder how many > downstreams noticed this change and are still building verbs properly? We do. But I was involved with the patches for the support and I was still in charge of our packages at the time, so I knew. But even if we had updated the spec file in the tarball, it wouldn't have mattered. Whenever we import a new package, part of the import is to create our own spec file. If there is a template, we might start from there, but we essentially fork it immediately. We have to in order to maintain our own spec %changelog. So changes to the template spec in the tarball likely would have been missed just like the change to the configure scrip= t. --=20 Doug Ledford GPG Key ID: 0E572FDD --LdFjH42mExLxm1F0F57CfhGwfNbADVKeH-- --Qgkbg9IgCDr28rXGTXpfCleqBAklQoaFn Content-Type: application/pgp-signature; name="signature.asc" Content-Description: OpenPGP digital signature Content-Disposition: attachment; filename="signature.asc" -----BEGIN PGP SIGNATURE----- Version: GnuPG v2 Comment: Using GnuPG with Thunderbird - http://www.enigmail.net/ iQIcBAEBCAAGBQJXwQpXAAoJELgmozMOVy/dlq0P/REBbW5ybLh1mTUzXkAil7wd s23Nf6gvBIhsj6d9S5HFqAE1hXvpQ84KnW4u5Gm1LXH2TDZKjJ79IdqVrC8+zmog KjhSBMlTxDrX0uWHevZZjQ+NjOjJ/7Uw/C8tkiDEON8usI5wZC1P8w9XbrD66Spz 3b6xlOuqV0IwbD9AWaNYP3IDSOTrT7EhKUFqaq8fKgSEJ9U1qg6JqbEX9VXT5kLw tWGz+VmJA+K7G9U9i4Gu/SZIMPeP+DVdaGWvO7XcgXD7kbC3dozjJGnf5tE99N+R LfbNzz+crbfasEizZqqol2qTT0Z3zZlENrUCdhrdghgO3U88lrt57xI9S7EKerJN yzQsNlCki51OBQXMU972/tMmAl5vDSp+hNxaDexVRBMhkVWum9C47G/3NioCHwZk cXuZ46ZMC0oPQch2/ekCPpaWUOzWeuPJ5IMgftBsGenvGhS04qAo4Ul3DaIXhW/W OhN+hP4USvpODd7lgsh1I1tJx2YO4e+xt+Zieq43xUPks79wXsanvcnsJrrlyepG bwFofVnPau/vXvOjjYLPY9MidYegFg7ixUCIjDkZyvFXA2JaSXGHbUSntrlkM9Gi 97EZNjnqTbRWDNEgIh99Zhx3DP0xZBVHPb8bBlDT5ZoUOeeSDCZqNAs0OyiIhktB NhjosmXSUXdVbC+xQO2A =O7Av -----END PGP SIGNATURE----- --Qgkbg9IgCDr28rXGTXpfCleqBAklQoaFn-- -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html