From mboxrd@z Thu Jan  1 00:00:00 1970
From: Vincent JARDIN <vincent.jardin@6wind.com>
Subject: Re: [PATCH v5 18/29] app/testpmd: use VFD APIs on i40e
Date: Tue, 20 Dec 2016 16:19:40 +0100
Message-ID: <1812ab01-ee86-f160-3f9b-6e807a909237@6wind.com>
References: <20161216143919.4909-1-ferruh.yigit@intel.com>
 <20161216190257.6921-1-ferruh.yigit@intel.com>
 <20161216190257.6921-19-ferruh.yigit@intel.com>
 <716260c7-4120-9984-3c46-02ad50b11a94@6wind.com>
 <625f5a53-e51e-7fb0-b477-c452e9217f41@intel.com>
Mime-Version: 1.0
Content-Type: text/plain; charset=windows-1252; format=flowed
Content-Transfer-Encoding: 8bit
Cc: Jingjing Wu <jingjing.wu@intel.com>, Helin Zhang <helin.zhang@intel.com>,
 Wenzhuo Lu <wenzhuo.lu@intel.com>, Chen Jing D <jing.d.chen@intel.com>,
 Bernard Iremonger <bernard.iremonger@intel.com>
To: Ferruh Yigit <ferruh.yigit@intel.com>, dev@dpdk.org
Return-path: <dev-bounces@dpdk.org>
Received: from mail-wm0-f53.google.com (mail-wm0-f53.google.com [74.125.82.53])
 by dpdk.org (Postfix) with ESMTP id E4668FBA3
 for <dev@dpdk.org>; Tue, 20 Dec 2016 16:19:43 +0100 (CET)
Received: by mail-wm0-f53.google.com with SMTP id f82so133542365wmf.1
 for <dev@dpdk.org>; Tue, 20 Dec 2016 07:19:43 -0800 (PST)
In-Reply-To: <625f5a53-e51e-7fb0-b477-c452e9217f41@intel.com>
List-Id: DPDK patches and discussions <dev.dpdk.org>
List-Unsubscribe: <http://dpdk.org/ml/options/dev>,
 <mailto:dev-request@dpdk.org?subject=unsubscribe>
List-Archive: <http://dpdk.org/ml/archives/dev/>
List-Post: <mailto:dev@dpdk.org>
List-Help: <mailto:dev-request@dpdk.org?subject=help>
List-Subscribe: <http://dpdk.org/ml/listinfo/dev>,
 <mailto:dev-request@dpdk.org?subject=subscribe>
Errors-To: dev-bounces@dpdk.org
Sender: "dev" <dev-bounces@dpdk.org>

Le 19/12/2016 à 12:03, Ferruh Yigit a écrit :
> And it is always possible to move these into ethdev layer, when multiple
> PMDs supports same feature.
> I agree this is something that needs to keep an eye on it, and be sure
> if an API is generic, move it into eth_dev layer.

you are right, you have a good point, it is better to try this approach, 
and let's generalize later.

thank you for your comments,
   Vincent