From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=ham autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id F4104C4338F for ; Tue, 10 Aug 2021 21:34:58 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id D93C261077 for ; Tue, 10 Aug 2021 21:34:58 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234538AbhHJVfT (ORCPT ); Tue, 10 Aug 2021 17:35:19 -0400 Received: from us-smtp-delivery-124.mimecast.com ([170.10.133.124]:52209 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S233625AbhHJVfS (ORCPT ); Tue, 10 Aug 2021 17:35:18 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628631295; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=cDJeQ1IVHivnnNjVy+6TxvfQSLwRaCeXGyL2mLJIpfs=; b=c4ndNfGC+W/riANjeHZHhAa6OWRDwrR9SyIHmrnTYU/6a1AezE4qjBkM9IkG8U9+CViptU Ykeliiimdd5xJeQiSKQQis6bcerMllMUceBhVlq8NAg4ddBCFcZN3UjkGohCriEOxsZ18e 3ITQ7jTMG6zKviyif7yVjkLjbhID0QQ= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-10-5MSDVLBIOhmregoOV89k5g-1; Tue, 10 Aug 2021 17:34:53 -0400 X-MC-Unique: 5MSDVLBIOhmregoOV89k5g-1 Received: from smtp.corp.redhat.com (int-mx08.intmail.prod.int.phx2.redhat.com [10.5.11.23]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id D84236409B; Tue, 10 Aug 2021 21:34:52 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id A359527CA8; Tue, 10 Aug 2021 21:34:51 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-80-willy@infradead.org> References: <20210715033704.692967-80-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 079/138] mm/filemap: Add readahead_folio() MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1813749.1628631290.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 22:34:50 +0100 Message-ID: <1813750.1628631290@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.23 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > The pointers stored in the page cache are folios, by definition. > This change comes with a behaviour change -- callers of readahead_folio() > are no longer required to put the page reference themselves. This matches > how readpage works, rather than matching how readpages used to work. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig For some of the things I'm looking at, this is actually inconvenient, but I guess I can take an extra ref if I need it. Reviewed-by: David Howells