From mboxrd@z Thu Jan  1 00:00:00 1970
Received: from [140.186.70.92] (port=39914 helo=eggs.gnu.org)
	by lists.gnu.org with esmtp (Exim 4.43) id 1PfAsy-0001Af-Ps
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 07:42:09 -0500
Received: from Debian-exim by eggs.gnu.org with spam-scanned (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1PfAsx-0006qI-IA
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 07:42:08 -0500
Received: from cantor2.suse.de ([195.135.220.15]:53410 helo=mx2.suse.de)
	by eggs.gnu.org with esmtp (Exim 4.71)
	(envelope-from <agraf@suse.de>) id 1PfAsx-0006q8-Bu
	for qemu-devel@nongnu.org; Tue, 18 Jan 2011 07:42:07 -0500
Mime-Version: 1.0 (Apple Message framework v1082)
Content-Type: text/plain; charset=us-ascii
From: Alexander Graf <agraf@suse.de>
In-Reply-To: <4D3586AE.8010509@redhat.com>
Date: Tue, 18 Jan 2011 13:42:04 +0100
Content-Transfer-Encoding: quoted-printable
Message-Id: <18137BBF-3546-4EFC-9F09-1E69C92F1630@suse.de>
References: <1292879604-22268-1-git-send-email-agraf@suse.de>
	<1292879604-22268-4-git-send-email-agraf@suse.de>
	<4D3586AE.8010509@redhat.com>
Subject: [Qemu-devel] Re: [PATCH 3/8] ahci: send init d2h fis on fis enable
List-Id: qemu-devel.nongnu.org
List-Unsubscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=unsubscribe>
List-Archive: <http://lists.nongnu.org/archive/html/qemu-devel>
List-Post: <mailto:qemu-devel@nongnu.org>
List-Help: <mailto:qemu-devel-request@nongnu.org?subject=help>
List-Subscribe: <http://lists.nongnu.org/mailman/listinfo/qemu-devel>,
	<mailto:qemu-devel-request@nongnu.org?subject=subscribe>
To: Kevin Wolf <kwolf@redhat.com>
Cc: Joerg Roedel <Joerg.Roedel@amd.com>, Gerd Hoffmann <kraxel@redhat.com>, qemu-devel Developers <qemu-devel@nongnu.org>, Sebastian Herbszt <herbszt@gmx.de>


On 18.01.2011, at 13:25, Kevin Wolf wrote:

> Am 20.12.2010 22:13, schrieb Alexander Graf:
>> The drive sends a d2h init fis on initialization. Usually, the guest =
doesn't
>> receive fises yet at that point though, so the delivery is deferred.
>>=20
>> Let's reflect that by sending the init fis on fis receive enablement.
>>=20
>> Signed-off-by: Alexander Graf <agraf@suse.de>
>=20
> Hm... If I read the spec right, the real solution wouldn't be an
> init_d2h_sent flag, but implementing a queue for FISes that are =
received
> when the guest hasn't set FRE yet.
>=20
> I'm not against taking a hack like this, but maybe leave a comment
> somewhere at least.

Yes, they'd get queued. In practice it doesn't really matter that much, =
which is why the hack works :). But you're right - a comment would be =
nice.


Alex