From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.5 required=3.0 tests=BAYES_00,DKIMWL_WL_HIGH, DKIM_SIGNED,DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS, INCLUDES_CR_TRAILER,MAILING_LIST_MULTI,SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 78E93C4338F for ; Tue, 10 Aug 2021 21:54:49 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 5955560F13 for ; Tue, 10 Aug 2021 21:54:49 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234946AbhHJVzK (ORCPT ); Tue, 10 Aug 2021 17:55:10 -0400 Received: from us-smtp-delivery-124.mimecast.com ([216.205.24.124]:56994 "EHLO us-smtp-delivery-124.mimecast.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234859AbhHJVzI (ORCPT ); Tue, 10 Aug 2021 17:55:08 -0400 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=redhat.com; s=mimecast20190719; t=1628632485; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: in-reply-to:in-reply-to:references:references; bh=HURkytPMW1jYOFriQemgfAiLPlwMlS6WXiAU+lsajVI=; b=daB8D8L3+T1/xVFfv4L2MENU1j7kjL0ONncwqwkQqNRQsSfyWXIyPdavy9JuaNmHo+sha5 G9hfhQ3ztakAhlCQHugXtdd1LGmzH8VUhmMfeKvrm89UI/KFZAj+dwZJqOp8aU9YNhbmOf hYJgtUtBEPfpcxKDBiBOQis9rizDgDo= Received: from mimecast-mx01.redhat.com (mimecast-mx01.redhat.com [209.132.183.4]) (Using TLS) by relay.mimecast.com with ESMTP id us-mta-461-M2730V9LPqyEH1IGWgyY1Q-1; Tue, 10 Aug 2021 17:54:42 -0400 X-MC-Unique: M2730V9LPqyEH1IGWgyY1Q-1 Received: from smtp.corp.redhat.com (int-mx07.intmail.prod.int.phx2.redhat.com [10.5.11.22]) (using TLSv1.2 with cipher AECDH-AES256-SHA (256/256 bits)) (No client certificate requested) by mimecast-mx01.redhat.com (Postfix) with ESMTPS id A28C692500; Tue, 10 Aug 2021 21:54:40 +0000 (UTC) Received: from warthog.procyon.org.uk (unknown [10.22.32.7]) by smtp.corp.redhat.com (Postfix) with ESMTP id 6D4D610016FB; Tue, 10 Aug 2021 21:54:39 +0000 (UTC) Organization: Red Hat UK Ltd. Registered Address: Red Hat UK Ltd, Amberley Place, 107-111 Peascod Street, Windsor, Berkshire, SI4 1TE, United Kingdom. Registered in England and Wales under Company Registration No. 3798903 From: David Howells In-Reply-To: <20210715033704.692967-86-willy@infradead.org> References: <20210715033704.692967-86-willy@infradead.org> <20210715033704.692967-1-willy@infradead.org> To: "Matthew Wilcox (Oracle)" Cc: dhowells@redhat.com, linux-kernel@vger.kernel.org, linux-mm@kvack.org, linux-fsdevel@vger.kernel.org, Christoph Hellwig Subject: Re: [PATCH v14 085/138] mm/filemap: Add filemap_alloc_folio MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-ID: <1814675.1628632478.1@warthog.procyon.org.uk> Date: Tue, 10 Aug 2021 22:54:38 +0100 Message-ID: <1814676.1628632478@warthog.procyon.org.uk> X-Scanned-By: MIMEDefang 2.84 on 10.5.11.22 Precedence: bulk List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Matthew Wilcox (Oracle) wrote: > Reimplement __page_cache_alloc as a wrapper around filemap_alloc_folio > to allow filesystems to be converted at our leisure. Increases > kernel text size by 133 bytes, mostly in cachefiles_read_backing_file(). > pagecache_get_page() shrinks by 32 bytes, though. > > Signed-off-by: Matthew Wilcox (Oracle) > Reviewed-by: Christoph Hellwig > ... > +static inline struct page *__page_cache_alloc(gfp_t gfp) > +{ > + return &filemap_alloc_folio(gfp, 0)->page; > +} Might be worth a note that this *will* return NULL if the allocation fails, though I guess it's deprecated? Reviewed-by: David Howells