From mboxrd@z Thu Jan 1 00:00:00 1970 From: Bob Peterson Date: Tue, 20 Feb 2018 10:36:16 -0500 (EST) Subject: [Cluster-devel] [PATCH] gfs2: Fix fallocate chunk size In-Reply-To: <20180219225113.17682-1-agruenba@redhat.com> References: <20180219225113.17682-1-agruenba@redhat.com> Message-ID: <1821636171.4802829.1519140976672.JavaMail.zimbra@redhat.com> List-Id: To: cluster-devel.redhat.com MIME-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 7bit ----- Original Message ----- | The chunk size of allocations in __gfs2_fallocate is calculated | incorrectly. The size can collapse, causing __gfs2_fallocate to | allocate one block at a time, which is very inefficient. This needs | fixing in two places: | | In gfs2_quota_lock_check, always set ap->allowed to UINT_MAX to indicate | that there is no quota limit. This fixes callers that rely on | ap->allowed to be set even when quotas are off. | | In __gfs2_fallocate, reset max_blks to UINT_MAX in each iteration of the | loop to make sure that allocation limits from one resource group won't | spill over into another resource group. | | Signed-off-by: Andreas Gruenbacher Hi, Thanks. This is now pushed to the for-next branch of the linux-gfs2 tree: https://git.kernel.org/pub/scm/linux/kernel/git/gfs2/linux-gfs2.git/commit/fs/gfs2?h=for-next&id=3fc7c7e1cfaac17cb7b0bfd54e5abf9b1ef2b819 Regards, Bob Peterson Red Hat File Systems