Re: [PATCH 1/3] nettle: add nettle to poky

[Paul Eggleton <paul.eggleton@linux.intel.com>]

Hi Valentin,

On Wednesday 30 April 2014 18:39:31 Valentin Popa wrote:
> Newer versions of gnutls depends on nettle.
> 
> Signed-off-by: Valentin Popa <valentin.popa@intel.com>
> ---
>  meta/recipes-support/nettle/nettle_2.7.1.bb | 22 ++++++++++++++++++++++
>  1 file changed, 22 insertions(+)
>  create mode 100644 meta/recipes-support/nettle/nettle_2.7.1.bb
> 
> diff --git a/meta/recipes-support/nettle/nettle_2.7.1.bb
> b/meta/recipes-support/nettle/nettle_2.7.1.bb new file mode 100644
> index 0000000..eb7c9de
> --- /dev/null
> +++ b/meta/recipes-support/nettle/nettle_2.7.1.bb
> @@ -0,0 +1,22 @@
> +DESCRIPTION = "A low level cryptographic library"

Since this value is short, could you please set it as SUMMARY instead?

> +HOMEPAGE = "http://www.lysator.liu.se/~nisse/nettle/"
> +SECTION = "libs"
> +LICENSE = "GPLv2+"

Is this license value correct? From the documentation:

"Nettle is distributed under the GNU Lesser General Public License (LGPL), see 
the file COPYING.LIB for details"

It looks like it might be even more complicated than that, since there is also 
a GPLv2 copying file in the 2.7.1 source.

> +LIC_FILES_CHKSUM =
> "file://COPYING.LIB;md5=2d5025d4aa3495befef8f17206a5b0a1"

Given the above we'd probably want to checksum more than just this file.

Cheers,
Paul

-- 

Paul Eggleton
Intel Open Source Technology Centre