From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hefty, Sean" Subject: RE: [PATCH v4 1/9] rdma/cm: define native IB address Date: Mon, 11 Feb 2013 18:02:41 +0000 Message-ID: <1828884A29C6694DAF28B7E6B8A8237368B99D59@ORSMSX101.amr.corp.intel.com> References: <1358891797-14625-1-git-send-email-sean.hefty@intel.com> <1358891797-14625-2-git-send-email-sean.hefty@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1358891797-14625-2-git-send-email-sean.hefty@intel.com> Content-Language: en-US Sender: netdev-owner@vger.kernel.org To: "linux-rdma@vger.kernel.org" , "netdev@vger.kernel.org" , "David Miller (davem@davemloft.net)" , Roland Dreier List-Id: linux-rdma@vger.kernel.org > Define AF_IB and sockaddr_ib to allow the rdma_cm to use native IB > addressing. > > Signed-off-by: Sean Hefty > --- > include/linux/socket.h | 2 + > include/rdma/ib.h | 89 ++++++++++++++++++++++++++++++++++++++++++++++++ > 2 files changed, 91 insertions(+), 0 deletions(-) > create mode 100644 include/rdma/ib.h > > diff --git a/include/linux/socket.h b/include/linux/socket.h > index 9a546ff..17a33f7 100644 > --- a/include/linux/socket.h > +++ b/include/linux/socket.h > @@ -167,6 +167,7 @@ struct ucred { > #define AF_PPPOX 24 /* PPPoX sockets */ > #define AF_WANPIPE 25 /* Wanpipe API Sockets */ > #define AF_LLC 26 /* Linux LLC */ > +#define AF_IB 27 /* Native InfiniBand address */ ... > diff --git a/include/rdma/ib.h b/include/rdma/ib.h ... > +struct sockaddr_ib { > + unsigned short int sib_family; /* AF_IB */ > + __be16 sib_pkey; > + __be32 sib_flowinfo; > + struct ib_addr sib_addr; > + __be64 sib_sid; > + __be64 sib_sid_mask; > + __u64 sib_scope_id; > +}; Dave/Roland/anyone, is there any feedback on this approach? If there's hesitation to add new address families to socket.h, I could instead use definitions local to the rdma_cm. This has the potential to result in conflicts if the rdma_cm is expanded for other address families, though such conflicts seem unlikely. - Sean