From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hefty, Sean" Subject: RE: [PATCH v4 16/19] IB/mad: Add Intel Omni-Path Architecture defines Date: Fri, 3 Apr 2015 23:33:55 +0000 Message-ID: <1828884A29C6694DAF28B7E6B8A82373A8FBD708@ORSMSX109.amr.corp.intel.com> References: <1423092585-26692-1-git-send-email-ira.weiny@intel.com> <1423092585-26692-17-git-send-email-ira.weiny@intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="us-ascii" Content-Transfer-Encoding: 8BIT Return-path: In-Reply-To: <1423092585-26692-17-git-send-email-ira.weiny-ral2JQCrhuEAvxtiuMwx3w@public.gmane.org> Content-Language: en-US Sender: linux-rdma-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: "roland-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org" Cc: "linux-rdma-u79uwXL29TY76Z2rM5mHXA@public.gmane.org" , "jgunthorpe-ePGOBjL8dl3ta4EC/59zMFaTQe2KTcn/@public.gmane.org" , "hal-LDSdmyG8hGV8YrgS2mwiifqBs+8SCbDb@public.gmane.org" , "Weiny, Ira" List-Id: linux-rdma@vger.kernel.org > /* Registration table sizes */ > #define MAX_MGMT_CLASS 80 > -#define MAX_MGMT_VERSION 8 > +#define MAX_MGMT_VERSION 0x83 It's unfortunate that this results in a big jump in used versions. Mad_priv.h defines this: struct ib_mad_port_private { ... struct ib_mad_mgmt_version_table version[MAX_MGMT_VERSION]; struct ib_mad_mgmt_version_table { struct ib_mad_mgmt_class_table *class; struct ib_mad_mgmt_vendor_class_table *vendor; }; This ends up allocating about 2K of data per port of NULL pointers. Not a huge deal, but still. I don't have a great fix here. Maybe the version[] array can be the necessary size, with some sort of simple mapping function from version to the index? -- To unsubscribe from this list: send the line "unsubscribe linux-rdma" in the body of a message to majordomo-u79uwXL29TY76Z2rM5mHXA@public.gmane.org More majordomo info at http://vger.kernel.org/majordomo-info.html