From mboxrd@z Thu Jan 1 00:00:00 1970 From: "Hefty, Sean" Subject: RE: [PATCH v5 00/27] IB/Verbs: IB Management Helpers Date: Wed, 22 Apr 2015 16:40:49 +0000 Message-ID: <1828884A29C6694DAF28B7E6B8A82373A8FC64BD@ORSMSX109.amr.corp.intel.com> References: <5534B8C9.506@profitbricks.com> <20150422024123.GA18675@phlsvsds.ph.intel.com> Mime-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: base64 Return-path: In-Reply-To: <20150422024123.GA18675@phlsvsds.ph.intel.com> Content-Language: en-US Sender: linux-kernel-owner@vger.kernel.org To: "Weiny, Ira" , Liran Liss Cc: Michael Wang , Roland Dreier , Hal Rosenstock , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "hal@dev.mellanox.co.il" , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , "raisch@de.ibm.com" , infinipath , Eli Cohen , "Latif, Faisal" , Jack Morgenstein , Or Gerlitz , Haggai Eran , Tom Talpey , Jason Gunthorpe , Doug Ledford List-Id: linux-rdma@vger.kernel.org PiA+IFNvLCBJIHRoaW5rIHRoYXQgb3VyICJvbGQtdHJhbnNwb3J0IiBiZWxvdyBpcyBqdXN0IGZp bmUuDQo+ID4gTm8gbmVlZCB0byBjaGFuZ2UgaXQgKGFuZCB5b3UgYXJlbid0LCBzaW5jZSBpdCBp cyBjdXJyZW50bHkgaW1wbGVtZW50ZWQNCj4gYXMgYSBmdW5jdGlvbikuDQo+IA0KPiBJIHRoaW5r IHRoZXJlIGlzIGEgbmVlZCB0byBjaGFuZ2UgdGhpcy4gIEVuY29kaW5nIHRoZSB0cmFuc3BvcnQg aW50byB0aGUNCj4gbm9kZQ0KPiB0eXBlIGlzIG5vdCBhIGdvb2QgaWRlYS4gIEhhdmluZyBkaWZm ZXJlbnQgInRyYW5zcG9ydCBzZW1hbnRpY3MiIHdoaWxlDQo+IHN0aWxsDQo+IHJldHVybmluZyB0 aGUgc2FtZSB0cmFuc3BvcnQgZm9yIHRoZSBwb3J0IGlzIGNvbmZ1c2luZy4NCj4gDQo+IFRoZSBv bmx5IHRoaW5nIHdoaWNoIGlzIGNsZWFyIGN1cnJlbnRseSBpcyBMaW5rIExheWVyLg0KPiANCj4g QnV0IHRoZSB1c2Ugb2YgIkxpbmsgTGF5ZXIiIGluIHRoZSBjb2RlIGlzIHNvIGNvbnZvbHV0ZWQg dGhhdCBpdCBpcyB2ZXJ5DQo+IGNvbmZ1c2luZy4NCg0KSSBhZ3JlZS4NCg0KT25lIGNvdWxkIGlt cGxlbWVudCBzb2Z0d2FyZSBpV2FycCBvciBJQm9VRFAgKFJvQ0V2MikgcHJvdG9jb2xzIHRoYXQg Y291bGQgcnVuIG92ZXIgYW55IGxpbmsgbGF5ZXIgYW5kIGludGVyb3BlcmF0ZSB3aXRoIGV4aXN0 aW5nIEhXIHNvbHV0aW9ucy4gIFRoZSBzdGFjayBzaG91bGRuJ3QgYmUgZGVhbGluZyB3aXRoIHRo ZSBsaW5rIGxldmVsIGF0IGFsbCwgd2l0aCB0aGUgZXhjZXB0aW9uIG9mIHVzZXIgc3BhY2UgY29t cGF0aWJpbGl0eS4NCg0KPiBEZWZpbmUgVHJhbnNwb3J0PyAgVGhlcmUgaGFzIGJlZW4gYSBsb3Qg b2YgZGlzY3Vzc2lvbiBvdmVyIHdoYXQgYQ0KPiB0cmFuc3BvcnQgaXMNCj4gaW4gVmVyYnMuDQoN CklNTywgd2Ugc2hvdWxkIHJlcGxhY2UgdXNpbmcgdGhlIHdvcmQgJ3RyYW5zcG9ydCcgd2l0aCBq dXN0ICdyZG1hX3Byb3RvY29sJy4gIEFuZCBldmVuIHRoZW4gSSdtIG5vdCBjb252aW5jZWQgdGhh dCBhbnl0aGluZyBzaG91bGQgY2FyZSwgYmV5b25kIHVzZXIgc3BhY2UgY29tcGF0aWJpbGl0eS4g IFRoZSBjYXBzIGFyZSB3aGF0IG1hdHRlci4NCg0KLSBTZWFuDQoNCg== From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S966711AbbDVQk7 (ORCPT ); Wed, 22 Apr 2015 12:40:59 -0400 Received: from mga02.intel.com ([134.134.136.20]:41519 "EHLO mga02.intel.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S966695AbbDVQkw (ORCPT ); Wed, 22 Apr 2015 12:40:52 -0400 X-ExtLoop1: 1 X-IronPort-AV: E=Sophos;i="5.11,624,1422950400"; d="scan'208";a="699260595" From: "Hefty, Sean" To: "Weiny, Ira" , Liran Liss CC: Michael Wang , Roland Dreier , Hal Rosenstock , "linux-rdma@vger.kernel.org" , "linux-kernel@vger.kernel.org" , "hal@dev.mellanox.co.il" , Tom Tucker , Steve Wise , Hoang-Nam Nguyen , "raisch@de.ibm.com" , infinipath , Eli Cohen , "Latif, Faisal" , "Jack Morgenstein" , Or Gerlitz , Haggai Eran , Tom Talpey , "Jason Gunthorpe" , Doug Ledford Subject: RE: [PATCH v5 00/27] IB/Verbs: IB Management Helpers Thread-Topic: [PATCH v5 00/27] IB/Verbs: IB Management Helpers Thread-Index: AQHQe0QQ0Q91AMGo0kiEmbfJYbtAQ51YltgAgAAznQCAAHRP0A== Date: Wed, 22 Apr 2015 16:40:49 +0000 Message-ID: <1828884A29C6694DAF28B7E6B8A82373A8FC64BD@ORSMSX109.amr.corp.intel.com> References: <5534B8C9.506@profitbricks.com> <20150422024123.GA18675@phlsvsds.ph.intel.com> In-Reply-To: <20150422024123.GA18675@phlsvsds.ph.intel.com> Accept-Language: en-US Content-Language: en-US X-MS-Has-Attach: X-MS-TNEF-Correlator: x-originating-ip: [10.22.254.139] Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Sender: linux-kernel-owner@vger.kernel.org List-ID: X-Mailing-List: linux-kernel@vger.kernel.org Content-Transfer-Encoding: 8bit X-MIME-Autoconverted: from base64 to 8bit by nfs id t3MGf4rD022425 > > So, I think that our "old-transport" below is just fine. > > No need to change it (and you aren't, since it is currently implemented > as a function). > > I think there is a need to change this. Encoding the transport into the > node > type is not a good idea. Having different "transport semantics" while > still > returning the same transport for the port is confusing. > > The only thing which is clear currently is Link Layer. > > But the use of "Link Layer" in the code is so convoluted that it is very > confusing. I agree. One could implement software iWarp or IBoUDP (RoCEv2) protocols that could run over any link layer and interoperate with existing HW solutions. The stack shouldn't be dealing with the link level at all, with the exception of user space compatibility. > Define Transport? There has been a lot of discussion over what a > transport is > in Verbs. IMO, we should replace using the word 'transport' with just 'rdma_protocol'. And even then I'm not convinced that anything should care, beyond user space compatibility. The caps are what matter. - Sean {.n++%ݶw{.n+{G{ayʇڙ,jfhz_(階ݢj"mG?&~iOzv^m ?I